Hi team
Thanks for your feedback!
Here is the voting result:
Our existing convention (customized based on Angular) is chosen!
~~
Our existing convention votes:
5, +1: Yu, Alex, Yunze, Jun, Qiang,
1, +0: tison
Angular convention votes:
1, +1: tison
~~
I’ll close this discussion and
Hi team,
Feel free to choose your desired convention **before EOD 8/16 (UTC +8)**.
We'll close this discussion and move to the next topic after that time.
Thank you!
Yu and mangoGoForward
On Mon, Aug 15, 2022 at 6:27 PM Yu wrote:
> Hi tison,
>
> Thanks for your suggestions!
>
> > But followi
Hi tison,
Thanks for your suggestions!
> But following the Conventional Commits will ensure we can use the
toolchain
built around it, such as semantic release[1].
Our customized convention can use the semantic release tool as well.
> Also, Conventional Commits
have a standard to name a BREAKING
To clarify, I don't have a strong feeling about either convention.
According to the reason above, I'd prefer the Angular convention, while +0
for the customized convention.
Best,
tison.
tison 于2022年8月14日周日 23:40写道：
> Technically, the regexp of both conventions are:
>
> * Angular convention - /
Technically, the regexp of both conventions are:
* Angular convention - /^(\w*)(?:\((.*)\))?!?: (.*)$/
* Customized conventions - /^\[(\w*)\](?:\[(.*)\])?: (.*)$/
So, there're technically equal from the customized convention perspective,
or the Angular convention contains all expressiveness of th
I agree that the customized one is better. +1 on the customized one.
Jun M 于2022年8月12日周五 10:51写道：
> +1 on the customized one.
>
>
> Cheers
> momo-jun
>
>
--
BR,
Qiang Huang
+1 on the customized one.
Cheers
momo-jun
+1 on the customized one
Thanks,
Yunze
> 2022年8月12日 00:25，Alexander Preuss
> 写道：
>
> Hi together,
>
> Thank you for driving this topic!
> I agree that our customized convention is better than the Angular one.
>
> +1 on the customized one
>
> Best,
> Alex
>
>
>
> On Thu, Aug 11, 2022 a
Hi together,
Thank you for driving this topic!
I agree that our customized convention is better than the Angular one.
+1 on the customized one
Best,
Alex
On Thu, Aug 11, 2022 at 11:02 AM Yu wrote:
> Hi team,
>
> For PIP 198: Standardize PR Naming Convention using GitHub Actions [1], we've
>
Hi team,
For PIP 198: Standardize PR Naming Convention using GitHub Actions [1], we've
got many different suggestions on implementation details. Let's discuss
them one by one.
Discussion topic:
For PR titles, which convention should we follow?
- Angular convention [2] - Our exis
10 matches
Mail list logo
