RE: [DISCUSSION] PIP-129: Introduce intermediate state for ledger deletion

2022-01-13 Thread Zhanpeng Wu
Looks there is no objection, I will start the official vote for PIP-129 On 2022/01/12 01:58:27 Zhanpeng Wu wrote: > https://github.com/apache/pulsar/issues/13526 > > > > ## Motivation > > Under the current ledger-trimming design in > `org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl#inter

Re: [DISCUSSION] PIP-129: Introduce intermediate state for ledger deletion

2022-01-11 Thread Hang Chen
+1 Good Job. Looking forward to this feature. Best, Hang PengHui Li 于2022年1月12日周三 10:54写道: > > +1 It's a nice approach for making sure the ledger can be deleted correctly. > > Regards, > Penghui > > On Wed, Jan 12, 2022 at 10:23 AM Zhanpeng Wu > wrote: > > > https://github.com/apache/pulsar/iss

Re: [DISCUSSION] PIP-129: Introduce intermediate state for ledger deletion

2022-01-11 Thread PengHui Li
+1 It's a nice approach for making sure the ledger can be deleted correctly. Regards, Penghui On Wed, Jan 12, 2022 at 10:23 AM Zhanpeng Wu wrote: > https://github.com/apache/pulsar/issues/13526 > > > > ## Motivation > > Under the current ledger-trimming design in > `org.apache.bookkeeper.m

[DISCUSSION] PIP-129: Introduce intermediate state for ledger deletion

2022-01-11 Thread Zhanpeng Wu
https://github.com/apache/pulsar/issues/13526 ## Motivation Under the current ledger-trimming design in `org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl#internalTrimLedgers`, we need to collect those ledgers that need to be deleted first, and then perform the asynchronous deletion of t