Re: [DISCUSS] Support custom compressionType for pulsar functions

2023-02-28 Thread Pengcheng Jiang
Use `LZ4` as zero value seems better, I will update Rui Fu 于2023年3月1日周三 11:12写道: > +1, very useful, just one question: why not set the `LZ4` as the “zero” > value instead? Like for the enum with following orders: `LZ4`, `NONE`, > `ZLIB`, `ZSTD` and `SNAPPY`? So it will remain the backward compat

Re: [DISCUSS] Support custom compressionType for pulsar functions

2023-02-28 Thread Rui Fu
+1, very useful, just one question: why not set the `LZ4` as the “zero” value instead? Like for the enum with following orders: `LZ4`, `NONE`, `ZLIB`, `ZSTD` and `SNAPPY`? So it will remain the backward compatibility. Best, Rui Fu On Mar 1, 2023 at 10:18 +0800, Neng Lu , wrote: > +1 for the cha

Re: [DISCUSS] Support custom compressionType for pulsar functions

2023-02-28 Thread Neng Lu
+1 for the change. On 2023/02/28 01:06:51 Pengcheng Jiang wrote: > Hello, community: > > ### Motivation > > Currently, pulsar functions are using `LZ4` as the compression type, and > users cannot change it, yet some users may want to custom this behavior. > > ### Modifications > > Add a `Compr

[DISCUSS] Support custom compressionType for pulsar functions

2023-02-27 Thread Pengcheng Jiang
Hello, community: ### Motivation Currently, pulsar functions are using `LZ4` as the compression type, and users cannot change it, yet some users may want to custom this behavior. ### Modifications Add a `CompressionType` field(which is an enum) to the `ProducerSpec` in the `Function.proto`; thi