Re: [DISCUSS] Support `brokerMaxConnectionsPerIp` on Pulsar proxy

2022-08-16 Thread Qiang Huang
Good idea. The implementation should provide an appropriate exception to prevent the client from reconnecting continuously if it reaches the limitation. Do other modules also need this? Michael Marshall 于2022年8月16日周二 13:52写道: > Good idea, it makes sense to me to add this to the proxy. > > > BTW,

Re: [DISCUSS] Support `brokerMaxConnectionsPerIp` on Pulsar proxy

2022-08-15 Thread Michael Marshall
Good idea, it makes sense to me to add this to the proxy. > BTW, are there any side effects from the implementation? Reading through the code from https://github.com/apache/pulsar/pull/10754, it looks like the cost is minimal. The broker maintains counters for each IP address, and they are increm

Re: [DISCUSS] Support `brokerMaxConnectionsPerIp` on Pulsar proxy

2022-08-15 Thread Haiting Jiang
Sounds good. It's good for server stability. BTW, are there any side effects from the implementation? On Tue, Aug 16, 2022 at 10:33 AM mattison chao wrote: > Hi, All > > Pulsar has the `brokerMaxConnectionsPerIp` configuration at the > broker, we can use it to limit the maximum connections per

[DISCUSS] Support `brokerMaxConnectionsPerIp` on Pulsar proxy

2022-08-15 Thread mattison chao
Hi, All Pulsar has the `brokerMaxConnectionsPerIp` configuration at the broker, we can use it to limit the maximum connections per IP. The original motivation and PR here: https://github.com/apache/pulsar/pull/10754 IMO, we can also apply it to pulsar-proxy, because when a large number of proxy