Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-18 Thread Christophe Bornet
+1 Le mer. 10 août 2022 à 09:36, Zike Yang a écrit : > Hi, Pulsar community > > Currently, Java tests consume significant CI resources. And it is not > necessary to run all the tests for changes that are only on the C++ or > python parts of the code. I have created a PR [0] to improve the CI by

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-17 Thread mattison chao
I support it. +1 Best, Mattison On Tue, 16 Aug 2022 at 17:33, Enrico Olivelli wrote: > > +1 > > Enrico > > Il giorno mar 16 ago 2022 alle ore 11:32 Nicolò Boschi > ha scritto: > > > > A big +1 for this! > > > > Nicolò Boschi > > > > > > Il giorno dom 14 ago 2022 alle ore 06:20 Qiang Huang < > >

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-16 Thread Enrico Olivelli
+1 Enrico Il giorno mar 16 ago 2022 alle ore 11:32 Nicolò Boschi ha scritto: > > A big +1 for this! > > Nicolò Boschi > > > Il giorno dom 14 ago 2022 alle ore 06:20 Qiang Huang < > qiang.huang1...@gmail.com> ha scritto: > > > +1. It can help reduce a lot of useless duplication of test cases. > >

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-16 Thread Nicolò Boschi
A big +1 for this! Nicolò Boschi Il giorno dom 14 ago 2022 alle ore 06:20 Qiang Huang < qiang.huang1...@gmail.com> ha scritto: > +1. It can help reduce a lot of useless duplication of test cases. > > Michael Marshall 于2022年8月11日周四 09:58写道: > > > Great suggestion, +1. > > > > - Michael > > > >

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-13 Thread Qiang Huang
+1. It can help reduce a lot of useless duplication of test cases. Michael Marshall 于2022年8月11日周四 09:58写道: > Great suggestion, +1. > > - Michael > > On Wed, Aug 10, 2022 at 8:38 PM Dave Fisher wrote: > > > > Yes, please! > > > > Sent from my iPhone > > > > > On Aug 10, 2022, at 5:39 PM, PengHui

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-10 Thread Michael Marshall
Great suggestion, +1. - Michael On Wed, Aug 10, 2022 at 8:38 PM Dave Fisher wrote: > > Yes, please! > > Sent from my iPhone > > > On Aug 10, 2022, at 5:39 PM, PengHui Li wrote: > > > > +1 > > > > Best, > > Penghui > > > >> On Wed, Aug 10, 2022 at 10:52 PM Yunze Xu > >> wrote: > >> > >> LGTM >

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-10 Thread Dave Fisher
Yes, please! Sent from my iPhone > On Aug 10, 2022, at 5:39 PM, PengHui Li wrote: > > +1 > > Best, > Penghui > >> On Wed, Aug 10, 2022 at 10:52 PM Yunze Xu >> wrote: >> >> LGTM >> >> Thanks, >> Yunze >> >> >> >> >>> 2022年8月10日 15:36,Zike Yang 写道: >>> >>> Hi, Pulsar community >>> >>

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-10 Thread PengHui Li
+1 Best, Penghui On Wed, Aug 10, 2022 at 10:52 PM Yunze Xu wrote: > LGTM > > Thanks, > Yunze > > > > > > 2022年8月10日 15:36,Zike Yang 写道: > > > > Hi, Pulsar community > > > > Currently, Java tests consume significant CI resources. And it is not > > necessary to run all the tests for changes that

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-10 Thread Yunze Xu
LGTM Thanks, Yunze > 2022年8月10日 15:36,Zike Yang 写道: > > Hi, Pulsar community > > Currently, Java tests consume significant CI resources. And it is not > necessary to run all the tests for changes that are only on the C++ or > python parts of the code. I have created a PR [0] to improve the

[DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-10 Thread Zike Yang
Hi, Pulsar community Currently, Java tests consume significant CI resources. And it is not necessary to run all the tests for changes that are only on the C++ or python parts of the code. I have created a PR [0] to improve the CI by skipping unnecessary tests when there are only CPP/Python changes