Re: [DISCUSS] Recent Checkstyle PRs

2022-01-12 Thread PengHui Li
I have no objection to the motivation. Just one thing is the PR changed many files, I guess we will get many conflicts there. With a few conflicts, we can handle them confidently and submit them directly to branches. If there are many conflicts, I would suggest creating PR direct to the branch so

Re: [DISCUSS] Recent Checkstyle PRs

2022-01-12 Thread Neng Lu
Hi all, Not all modules enable the checkstyle. I think we need to make sure the behavior is consistent across all modules. On Wed, Jan 12, 2022 at 9:42 AM Michael Marshall wrote: > Hi Pulsar Community, > > I notice that we have had several recent PRs adding checkstyle to more > of our modules:

[DISCUSS] Recent Checkstyle PRs

2022-01-12 Thread Michael Marshall
Hi Pulsar Community, I notice that we have had several recent PRs adding checkstyle to more of our modules: https://github.com/apache/pulsar/pull/13409 https://github.com/apache/pulsar/pull/13413 https://github.com/apache/pulsar/pull/13343 https://github.com/apache/pulsar/pull/13284 https://githu