+1
The metrics, CLI, Admin API changes will directly face our users.
I think a proposal will ask the whole community to consider the rationality of
modifying it
Not only the people in review know it
Thanks,
Tao Jiuming
> 2022年12月7日 11:38，PengHui Li 写道：
>
> Hi all,
>
> I would like to start
Hi Penghui:
< All of the discussions here are about the Admin API / CLI changes
< he metrics changes are about adding new metrics added, adding new labels,
< removing labels, etc. It's not about the implementations. A bug fix usually
< happens to the implementation, not the API definition or metri
Hi Bo,
> yes, need a proposal for Admin API/CLI and metrics changes. but It is
> difficult for us to judge whether a PR is a bug fix or needs PIP or
> doc/required through automatic detection. We can standardize the
> committer review process and increase the description of the review
> document,
> Is it time to require a proposal for Admin API/CLI and metrics changes?
yes, need a proposal for Admin API/CLI and metrics changes. but It is
difficult for us to judge whether a PR is a bug fix or needs PIP or
doc/required through automatic detection. We can standardize the
committer review proc
I have pushed out a PR to update the PR template and PIP for metrics changes
https://github.com/apache/pulsar/pull/18961
PTAL.
Thanks,
Penghui
On Wed, Dec 7, 2022 at 4:17 PM Haiting Jiang wrote:
> +1 for enforcing the PIP procedures.
>
> > And the CI can try to add labels `doc required` or `w
+1 for enforcing the PIP procedures.
> And the CI can try to add labels `doc required` or `wants/proposal`
> according to the list selections.
Is it possible that the CI can check if there is a "voted" PIP linking
to this PR.
And the label can be manually added by committers if the PR author
miss
> I agree a proposal would be better before adding a PR. But the
document part must be a part of such a proposal.
Make sense. It looks like we should have a checklist for the proposal.
The documentation changes should be listed in the proposal.
> Can the PR template/GitHub process check that if e
Sent from my iPhone
> On Dec 6, 2022, at 9:45 PM, Yunze Xu wrote:
>
> Hi Penghui,
>
>> But maybe some are missed.
>
> That's the point. Each PR that adds or modifies a metric item must be
> labeled with "doc-required" and the related documents should be added.
> However, these PRs are near
Hi Penghui,
> But maybe some are missed.
That's the point. Each PR that adds or modifies a metric item must be
labeled with "doc-required" and the related documents should be added.
However, these PRs are nearly all labeled with "doc-not-needed".
I agree a proposal would be better before adding
Hi Yunze,
All the metrics are listed here
https://pulsar.apache.org/docs/2.10.x/reference-metrics/
But maybe some are missed.
Thanks,
Penghui
On Wed, Dec 7, 2022 at 11:46 AM Yunze Xu
wrote:
> I agree. It should have required the PIP.
>
> I have another question. Is there any document to descr
I agree. It should have required the PIP.
I have another question. Is there any document to describe these
metrics? I think the metrics body should be documented well to avoid
breaking changes. Some external applications might parse the metrics
according to a specific structure.
Thanks,
Yunze
On
Hi all,
I would like to start a discussion about requiring a proposal for Admin
API/CLI
and metrics changes.
Here are some recent examples that changed the Admin API but without
proposals.
I just checked the commit logs. Maybe some have a proposal. Just forgot to
add
the proposal link to the PR.
12 matches
Mail list logo
