Re: [DISCUSS] PIP 197: Add Schema hash and equals to public API

2022-08-12 Thread Alexander Preuss
Hi Enrico, Thank you for chiming in. I understand your concerns regarding the state of a Schema instance. However, what would be the reason for keeping SchemaHash as part of the private API? Of course, a user could re-create its functionality in their own code but then why should we not offer this

Re: [DISCUSS] PIP 197: Add Schema hash and equals to public API

2022-08-11 Thread Enrico Olivelli
A Schema instance is stateful (and contians mutable state) and in the end it contains a reference to the PulsarClient instance that is using it. Look at how AutoConsume schema works for instance. I don't think it is possible to support such API in the general case. If you want to use it as a key

[DISCUSS] PIP 197: Add Schema hash and equals to public API

2022-08-05 Thread Alexander Preuss
Hello Pulsar community, I would like to start a discussion about PIP 197: Add Schema hash and equals to public API. You can find the proposal at https://github.com/apache/pulsar/issues/16959 as well as pasted below. Looking forward to hearing your thoughts, Alex ## Motivation Currently, the `Sc