Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

2023-09-11 Thread Zike Yang
+1 for me. Thanks, Zike Yang On Mon, Sep 11, 2023 at 11:13 AM Cong Zhao wrote: > > Hi, guys > > I noticed that the only globally ordered fields in the metadata are > 'publishTime' and 'entryIndex' (offset), so I split the previous method into > `findEntryByPublishTime` and `findEntryByEntryInd

Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

2023-09-10 Thread Cong Zhao
Hi, guys I noticed that the only globally ordered fields in the metadata are 'publishTime' and 'entryIndex' (offset), so I split the previous method into `findEntryByPublishTime` and `findEntryByEntryIndex`, this will make method definitions more precise. The method returns the entry directly i

Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

2023-08-27 Thread Cong Zhao
Hi Penghui, Thanks for the suggestion. First, I changed the method to findFirstEntryMetadata because I think it's more common to look for the first matching entry compared to finding the entry of the last match, e.g. to look for the first position greater than or equal to a specific publish ti

Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

2023-08-27 Thread PengHui Li
Hi Cong, Thanks for driving the proposal. Is it better to use `readNewestCompactedEntry(@Nonnull Predicate condition)` So that you don't need to introduce a new interface, RawEntryMetadata And it's a more general solution for the TopicCompactionService. WDYT? Regards, Penghui On Tue, Jul 25, 2

[DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

2023-07-24 Thread Cong Zhao
Hi Pulsar Community, I am writing to start the discussion on PIP 286 PR with PIP contents: https://github.com/apache/pulsar/pull/20867 Thanks, Cong Zhao