Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Thanks for the PIP. Looks good to me +1 (non-binding) Zike Yang On Mon, Jul 17, 2023 at 9:05 AM PengHui Li wrote: > > Thanks, > > It looks good to me. > > Regards, > Penghui > > On Sun, Jul 16, 2023 at 8:18 PM Baodi Shi wrote: > > > Hi, Penghui. > > > > Could you please help add a section to ex

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Thanks, It looks good to me. Regards, Penghui On Sun, Jul 16, 2023 at 8:18 PM Baodi Shi wrote: > Hi, Penghui. > > Could you please help add a section to explain the compatibility guarantee? > > Others look good to me. > > > Added it, PTAL. > > > Thanks, > Baodi Shi > > > On Jul 14, 2023 at 18:

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Hi, Penghui. Could you please help add a section to explain the compatibility guarantee? > Others look good to me. Added it, PTAL. Thanks, Baodi Shi On Jul 14, 2023 at 18:27:34, PengHui Li wrote: > Could you please help add a section to explain the compatibility guarantee? > Others look go

Re: [DISCUSS] PIP-281: Add notifyError method on PushSource

Could you please help add a section to explain the compatibility guarantee? Others look good to me. Regards, Penghui On Fri, Jul 14, 2023 at 6:07 PM Baodi Shi wrote: > Hi, All > > I opened a new PIP design PR. > I am looking forward to your feedback. > > https://github.com/apache/pulsar/pull/20

[DISCUSS] PIP-281: Add notifyError method on PushSource

Hi, All I opened a new PIP design PR. I am looking forward to your feedback. https://github.com/apache/pulsar/pull/20807 This is a very simple change and is forward-compatible. Sorry, I didn't notice that this change required PIP before, so the rel