Re: [DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-06-01 Thread Pengcheng Jiang
pr is created: https://github.com/apache/pulsar/pull/20455 Pengcheng Jiang 于2023年6月1日周四 15:49写道: > Sure, I will create a PR and update the issue when development is done > > Asaf Mesika 于2023年5月31日周三 16:39写道: > >> Pengcheng, would you be willing to be the inaugural PIP in our PIP >> submission

Re: [DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-06-01 Thread Pengcheng Jiang
Sure, I will create a PR and update the issue when development is done Asaf Mesika 于2023年5月31日周三 16:39写道: > Pengcheng, would you be willing to be the inaugural PIP in our PIP > submission process? > Yesterday, we officially moved from the GitHub issue to a markdown file for > PIP submissions. >

Re: [DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-05-31 Thread Asaf Mesika
Pengcheng, would you be willing to be the inaugural PIP in our PIP submission process? Yesterday, we officially moved from the GitHub issue to a markdown file for PIP submissions. For you, it basically means moving your proposal to a markdown file and submitting a PR (and deleting the content in t

Re: [DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-05-30 Thread Neng Lu
thanks for the improvements, +1 On Tue, May 30, 2023 at 2:20 AM Pengcheng Jiang wrote: > Hi Mesika: > > Thanks for the suggestions, I updated the pip, and for the rest questions: > > 5. yes, all config goes through arguments instead of a file > 6. it should be a JSON string that can be deseriali

Re: [DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-05-30 Thread Pengcheng Jiang
Hi Mesika: Thanks for the suggestions, I updated the pip, and for the rest questions: 5. yes, all config goes through arguments instead of a file 6. it should be a JSON string that can be deserialized to a `Map`, updated in pip 7. it should be `pulsar-admin functions localrun` command, updated in

Re: [DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-05-29 Thread Asaf Mesika
Hi Pengcheng, Looks like a solid improvement, definitely helping people using their own state store. I have a few comments: 1. Background knowledge should explain what is a state storage 2. Move problem description from Background Knowledge to Motivation. I'm quoting the template to understand

Re: [DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-05-29 Thread Rui Fu
Hi Pengcheng, Thanks for bringing this up, the PIP lgtm, +1. Best, Rui Fu On May 29, 2023 at 13:52 +0800, Enrico Olivelli , wrote: > Looks good > +1 > > Enrico > > Il Lun 29 Mag 2023, 04:47 Pengcheng Jiang > ha scritto: > > > Dear Pulsar community, > > > > I created a pip to make pulsar functio

Re: [DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-05-28 Thread Enrico Olivelli
Looks good +1 Enrico Il Lun 29 Mag 2023, 04:47 Pengcheng Jiang ha scritto: > Dear Pulsar community, > > I created a pip to make pulsar functions' `StateStoreProvider` configurable > with custom configurations: https://github.com/apache/pulsar/issues/20419 > > Any feedback and suggestions are w

[DISCUSS] PIP-272 Add a `StateStoreConfig` to the `WorkerConfig`

2023-05-28 Thread Pengcheng Jiang
Dear Pulsar community, I created a pip to make pulsar functions' `StateStoreProvider` configurable with custom configurations: https://github.com/apache/pulsar/issues/20419 Any feedback and suggestions are welcome Sincerely Pengcheng Jiang