Re: [DISCUSS] PIP-244: Refactor ByteBuf release method

2023-01-30 Thread Dave Fisher
t;>logger.warn("Failed to release a message: {}", msg, var2); >>>} >>> } >>> ``` >>> >>> When `release` throws an exception, it means the logic is wrong. For >>> example, you have released a ByteBuf whose refcnt is 1 twice.

Re: [DISCUSS] PIP-244: Refactor ByteBuf release method

2023-01-30 Thread Shiji Lu
ample, you have released a ByteBuf whose refcnt is 1 twice. We > > should make it clear where fast-fail is not allowed and catch the > > exception in these places. > > > > Thanks, > > Yunze > > > > On Sun, Jan 29, 2023 at 7:57 PM steven lu wrote: > > &

Re: [DISCUSS] PIP-244: Refactor ByteBuf release method

2023-01-30 Thread Enrico Olivelli
where fast-fail is not allowed and catch the > exception in these places. > > Thanks, > Yunze > > On Sun, Jan 29, 2023 at 7:57 PM steven lu wrote: > > > > [DISCUSS] PIP-244: Refactor ByteBuf release method > > Hello everyone. I hope you guys are all doing well. I would l

Re: [DISCUSS] PIP-244: Refactor ByteBuf release method

2023-01-29 Thread Yunze Xu
steven lu wrote: > > [DISCUSS] PIP-244: Refactor ByteBuf release method > Hello everyone. I hope you guys are all doing well. I would like to start > the discussion for PIP-244 https://github.com/apache/pulsar/issues/19350, > Please let me know if you have any concerns or questions.

[DISCUSS] PIP-244: Refactor ByteBuf release method

2023-01-29 Thread steven lu
[DISCUSS] PIP-244: Refactor ByteBuf release method Hello everyone. I hope you guys are all doing well. I would like to start the discussion for PIP-244 https://github.com/apache/pulsar/issues/19350, Please let me know if you have any concerns or questions. --- Paste original PIP content to