This proposal looks good to me. I left some minor feedback on the PR.
I agree with Enrico that this would be a helpful framework to use
internally in Pulsar.
Thanks,
Michael
On Thu, Jan 19, 2023 at 10:24 AM Andrey Yegorov
wrote:
>
> Hi Haiting,
>
> Currently there are no plans to use TopicEvent
Hi Haiting,
Currently there are no plans to use TopicEvent/EventStage outside of the
TopicEventsListener.
We can refactor that if the situation changes and if these will be reusable
(which I doubt at least for the TopicEvent).
I'd keep it contained in one file/namespace.
On Thu, Jan 19, 2023 at 2
Hi Andrey,
This PIP makes sense to me.
A small question: Is it better to define `TopicEvent` and `EventStage`
outside of `TopicEventsListener`?
Thanks,
Haiting
On Tue, Jan 17, 2023 at 3:51 PM Enrico Olivelli wrote:
>
> I support this PIP.
> This will allow Protocol Handlers to have better kno
I support this PIP.
This will allow Protocol Handlers to have better knowledge of what's
happening on the broker.
I hope that someday we will be able to refactor Broker internals using
this feature and decouple the components.
Enrico
Il giorno lun 16 gen 2023 alle ore 10:27 Yunze Xu
ha scritto:
+1 to me now.
Thanks,
Yunze
On Sat, Jan 14, 2023 at 1:29 AM Andrey Yegorov
wrote:
>
> My bad, I pasted the interface code from a branch with experiment to cancel
> events. This is no longer needed.
> EventProcessingResult result is irrelevant, I updated the PIP.
>
> It is not in the PR.
>
> On F
My bad, I pasted the interface code from a branch with experiment to cancel
events. This is no longer needed.
EventProcessingResult result is irrelevant, I updated the PIP.
It is not in the PR.
On Fri, Jan 13, 2023 at 4:08 AM Yunze Xu
wrote:
> I have some questions about the EventProcessingResu
I have some questions about the EventProcessingResult:
1. What's the difference between FAILURE and NOT_ALLOWED?
2. If we need to return the `message`, which indicates the error IIUC,
would it be better to replace the returned value with a checked
exception?
Thanks,
Yunze
On Fri, Jan 13, 2023 at
Hi,
I am starting discussion for PIP-241: TopicEventListener / topic events for
the BrokerService.
PIP issue: https://github.com/apache/pulsar/issues/19224
### Motivation
Some Protocol Handlers may need to know about the topic-specific events to
update internal caches and/or state.
These mecha
