The new implementation is compatible with the existing tests, otherwise,
there will be a lot of changes in the src and test directories.
Thanks,
Zixuan
Ran Gao 于2024年2月26日周一 19:49写道：
> +1 (non-binding), it's more elegant. There will be a lot of changes, we
> can create some tasks based on comma
> If I am implementing a custom extension of Pulsar Shell/Pulsar Admin,
> currently my code doesn't depend on jcommander
Your PIP is a good design.
I can handle the adaptation of custom extension of Pulsar Shell/Pulsar
Admin, but `org.apache.pulsar.shell.ShellCommandsProvider` needs to be
changed
+1 (non-binding), it's more elegant. There will be a lot of changes, we can
create some tasks based on commands.
- Ran Gao
On 2024/02/21 05:07:46 Zixuan Liu wrote:
> Hi Pulsar Community,
>
> The pulsar CLI(pulsar-admin, pulsar-client, pulsar-shell, and so on) uses
> the jcommander [1] as CLI pa
Il Lun 26 Feb 2024, 02:23 PengHui Li ha scritto:
> +1 Great user experience improvement.
>
> Regards,
> Penghui
>
> On Sat, Feb 24, 2024 at 3:15 AM Zixuan Liu wrote:
>
> > > Can you please share some pointers ?
> >
> > Only `org.apache.pulsar.shell.ShellCommandsProvider#getJCommander` uses
> > j
+1 Great user experience improvement.
Regards,
Penghui
On Sat, Feb 24, 2024 at 3:15 AM Zixuan Liu wrote:
> > Can you please share some pointers ?
>
> Only `org.apache.pulsar.shell.ShellCommandsProvider#getJCommander` uses
> jcommander API. I need to use picocli instead of jcommander, or add a n
> Can you please share some pointers ?
Only `org.apache.pulsar.shell.ShellCommandsProvider#getJCommander` uses
jcommander API. I need to use picocli instead of jcommander, or add a new
method.
Using picocli instead of jcommander will reduce some code, but it will
break the signature of some metho
Il Ven 23 Feb 2024, 04:34 Zixuan Liu ha scritto:
> Thanks for the feedback!
>
> > Please take into account Pulsar Shell extensions
>
> This is a tricky issue, I noticed that it depends on jcommander here,
Can you please share some pointers ? IIRC the shell extensions shouldn't
need jcommander,
Thanks for the feedback!
> Please take into account Pulsar Shell extensions
This is a tricky issue, I noticed that it depends on jcommander here, and I
need to break this interface, and make it compatible with Pulsar Shell
implementation.
I will create a draft PR to migrate the CLI parser from j
+1
Please take into account Pulsar Shell extensions
Enrico
Il Mer 21 Feb 2024, 11:21 Girish Sharma ha
scritto:
> +1 (non-binding)
> It has been a pain trying to figure out what's the exact sub-param name
> given that some of them are 20+ characters long.
>
>
> On Wed, Feb 21, 2024 at 3:47 PM
+1 (non-binding)
It has been a pain trying to figure out what's the exact sub-param name
given that some of them are 20+ characters long.
On Wed, Feb 21, 2024 at 3:47 PM Julien Jakubowski
wrote:
> Thanks for this proposal! That should significantly improve the user
> experience with the CLI.
>
Thanks for this proposal! That should significantly improve the user experience
with the CLI.
> Le 21 févr. 2024 à 06:08, Zixuan Liu a écrit :
>
> Hi Pulsar Community,
>
> The pulsar CLI(pulsar-admin, pulsar-client, pulsar-shell, and so on) uses
> the jcommander [1] as CLI parser, which is a
sounds great!
+1 nonbinding
Zixuan Liu 于2024年2月21日 周三13:08写道：
> Hi Pulsar Community,
>
> The pulsar CLI(pulsar-admin, pulsar-client, pulsar-shell, and so on) uses
> the jcommander [1] as CLI parser, which is an awesome project, but the
> maintainer is not active and cannot keep up with modern CLI
Hi Pulsar Community,
The pulsar CLI(pulsar-admin, pulsar-client, pulsar-shell, and so on) uses
the jcommander [1] as CLI parser, which is an awesome project, but the
maintainer is not active and cannot keep up with modern CLI
features(auto-completion, sub-command, native-images, suggest commands,
13 matches
Mail list logo
