Re: [DISCUSS] Is PIP required for small changes in metrics

2023-04-30 Thread Asaf Mesika
I second everything Yunze said. Just glance over the amount of configuration Pulsar has - it's almost a book. Configuration and metrics are basically the public facing side of Pulsar. We want Pulsar to be easy to use , for it to be an awesome developer experience. It starts by making sure we disc

Re: [DISCUSS] Is PIP required for small changes in metrics

2023-04-27 Thread Yunze Xu
The problem is not related to whether the patch is simple. It is, adding configurations were very casual in the past few years. Let's look at how many configurations we have from a discussion [1] I started a few months ago. Adding a configuration is simple, removing it is hard. Most of these conf

Re: [DISCUSS] Is PIP required for small changes in metrics

2023-04-27 Thread lifepuzzlefun
Totally agree. I have seen some patches with little change worth to do, but stopped making progress, only being told an pip is needed. I think if we have one fast-path for notice small changes like metrics or configuration. some pip to add configuration is also simple enough. like just add an

Re: [DISCUSS] Is PIP required for small changes in metrics

2023-04-27 Thread Rajan Dhabalia
Hi, Thank you Mattison for starting this thread because I am feeling some of the community members are making new contributors' life difficult and trying to enforce rules which were never discussed and discourage them from contributing to Pulsar. I really don't want to see the Pulsar community bec

[DISCUSS] Is PIP required for small changes in metrics

2023-04-27 Thread mattisonchao
Hi, All I've got two questions want to discuss with you guys. 1. I am wondering if we should draft PIP for small metrics changes, e.g: https://github.com/apache/pulsar/pull/20147 2. We haven't declear we should draft a PIP for configuration changes. why?   Refer to: https://github.com/apache/pu