Closing the loop, we merged the PR to set `dismiss_stale_reviews` to
`false` two days ago.
Thanks,
Michael
On Wed, Feb 23, 2022 at 2:52 AM Li Li wrote:
>
> +1
>
> > On Feb 23, 2022, at 4:23 PM, Guangning E wrote:
> >
> > +1
> >
> >
> > Thanks,
> > Guangning
> >
> > Enrico Olivelli 于2022年2月23日周
+1
> On Feb 23, 2022, at 4:23 PM, Guangning E wrote:
>
> +1
>
>
> Thanks,
> Guangning
>
> Enrico Olivelli 于2022年2月23日周三 16:01写道：
>
>> +1
>>
>> Enrico
>>
>> Il Mer 23 Feb 2022, 07:31 PengHui Li ha scritto:
>>
>>> +1
>>>
>>> Before I always thought it was Github added this new feature :)
+1
Thanks,
Guangning
Enrico Olivelli 于2022年2月23日周三 16:01写道：
> +1
>
> Enrico
>
> Il Mer 23 Feb 2022, 07:31 PengHui Li ha scritto:
>
> > +1
> >
> > Before I always thought it was Github added this new feature :)
> > Thanks for sharing the great knowledge.
> >
> > Penghui
> >
> > On Wed, Feb 23,
+1
Enrico
Il Mer 23 Feb 2022, 07:31 PengHui Li ha scritto:
> +1
>
> Before I always thought it was Github added this new feature :)
> Thanks for sharing the great knowledge.
>
> Penghui
>
> On Wed, Feb 23, 2022 at 2:24 PM Michael Marshall
> wrote:
>
> > Hi All,
> >
> > In my recent PR to updat
+1
Before I always thought it was Github added this new feature :)
Thanks for sharing the great knowledge.
Penghui
On Wed, Feb 23, 2022 at 2:24 PM Michael Marshall
wrote:
> Hi All,
>
> In my recent PR to update the `.asf.yaml` to protect release branches,
> I set the `dismiss_stale_reviews` to
Hi All,
In my recent PR to update the `.asf.yaml` to protect release branches,
I set the `dismiss_stale_reviews` to `true` for PRs targeting master
branch [0]. I mistakenly thought this setting would only dismiss PRs
updated by force. Instead, all approvals are dismissed when additional
commits ar
