+1
Paul Gier 于2022年10月1日周六 05:41写道：
> I thought about this a bit more and realized that ldflags doesn't really
> make sense in this case because this is a library, and we don't control the
> user's build environment. It might work fine for the pulsar-perf binary,
> but doesn't really make sense
I thought about this a bit more and realized that ldflags doesn't really
make sense in this case because this is a library, and we don't control the
user's build environment. It might work fine for the pulsar-perf binary,
but doesn't really make sense in the context of users who are consuming the
+1
Passing the git ID and other version information via ldflags would be
better in my opinion than embedding a file. It can be automated in the
Makefile, and the values can go directly into a variable, so you don't have
to do any string parsing. The feature has been around a long time, so we
woul
Have you thought about using ldflags to pass git commit or git tag which
can be the actual version. This will tie into a build system automatically
without additional files. We don't have to maintain the version
information in git and a separate file.
Here is an example.
https://stackoverflow.com/q
Hello Matteo:
Considering that some users are still using the Go 1.15 version, in the
0.9.0 release, we still use the form of hard code and set the form of
pulsar-go-client to the version of 0.9.0. In order to ensure that the 0.9.0
release maintains backward compatibility, we may continue to do th
+1, according to https://go.dev/doc/devel/release#policy (quoted below), the
current live supported go version should be 1.19, 1.18 and 1.17, so I think it
should be fine if we move the pulsar-client-go with 1.16 as the minimum Go SDK
version.
> quote_type
> > Release Policy
> Each major Go rele
+1
It would be good to determine and document a compatibility policy to state
which versions are going to be supported and for how long.
On Wed, Sep 28, 2022 at 8:31 PM 沈家琦 wrote:
> +1
> pulsar-go-client from Go 1.15 to Go 1.16
>
> Thanks
>
> r...@apache.org 于2022年9月29日周四 11:11写道：
>
> > Hello
+1
pulsar-go-client from Go 1.15 to Go 1.16
Thanks
r...@apache.org 于2022年9月29日周四 11:11写道：
> Hello everyone:
>
> In the current version of pulsar-go-client, we do not support embedding the
> version information of pulsar-go-client into
> Client Command to send to the Broker. Now the hard code is
Hello everyone:
In the current version of pulsar-go-client, we do not support embedding the
version information of pulsar-go-client into
Client Command to send to the Broker. Now the hard code is fixed to 0.1.0.
This makes it impossible for us to determine
which version of pulsar-go-client the cur
