Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Enrico Olivelli
Yunze, I have updated the PIP with the code of a sample command. Thank you everyone for your comments, I will start a VOTE. Enrico Il giorno mar 23 ago 2022 alle ore 05:26 Michael Marshall ha scritto: > > This proposal looks good to me. I think it will be a helpful addition > to the pulsar admi

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-22 Thread Michael Marshall
This proposal looks good to me. I think it will be a helpful addition to the pulsar admin tool. I like that the design avoids an unnecessary dependency on JCommander. Thanks, Michael On Mon, Aug 22, 2022 at 1:22 PM Enrico Olivelli wrote: > > Yunze, > > > > Il Lun 22 Ago 2022, 20:20 Enrico Olive

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-22 Thread Enrico Olivelli
Yunze, Il Lun 22 Ago 2022, 20:20 Enrico Olivelli ha scritto: > > > Il Lun 22 Ago 2022, 17:07 Yunze Xu ha > scritto: > >> I will take a look. But I think we should also add a trivial example >> (or a test) in the Apache repo > > I will add integration tests for sure. Currently the PR is only a

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-22 Thread Enrico Olivelli
Il Lun 22 Ago 2022, 17:07 Yunze Xu ha scritto: > I will take a look. But I think we should also add a trivial example > (or a test) in the Apache repo, e.g. just print some messages for an > extended command. Sure. I will update the PIP And the JavaDocs of these interfaces should be > complete

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-22 Thread Yunze Xu
I will take a look. But I think we should also add a trivial example (or a test) in the Apache repo, e.g. just print some messages for an extended command. And the JavaDocs of these interfaces should be complete and more clear. Thanks, Yunze > 2022年8月22日 18:37,Enrico Olivelli 写道: > > Yunze,

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-22 Thread Enrico Olivelli
Yunze, Il giorno lun 22 ago 2022 alle ore 08:06 Yunze Xu ha scritto: > > The motivation and goal LGTM, but the API changes look very simple and > hard to use. Do we have to implement all these interfaces for an admin > extension? If yes, could you show an example in the proposal as a > guidance?

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-21 Thread Yunze Xu
The motivation and goal LGTM, but the API changes look very simple and hard to use. Do we have to implement all these interfaces for an admin extension? If yes, could you show an example in the proposal as a guidance? For example, if I just want to implement a simple command: ```bash ./bin/pulsar

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-19 Thread Nicolò Boschi
+1, it will have a great impact to the Pulsar ecosystem Nicolò Boschi Il giorno ven 19 ago 2022 alle ore 09:13 Zixuan Liu ha scritto: > +1 Great idea. > > > Thanks, > Zixuan > > Enrico Olivelli 于2022年8月18日周四 16:24写道: > > > Hello, > > I have drafted a PIP around this proposal. > > > > PIP link

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-19 Thread Zixuan Liu
+1 Great idea. Thanks, Zixuan Enrico Olivelli 于2022年8月18日周四 16:24写道: > Hello, > I have drafted a PIP around this proposal. > > PIP link: https://github.com/apache/pulsar/issues/17155 > > I am preparing an official PR, I already have a working prototype. > > Copy of the contents of the GH issue

[DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-18 Thread Enrico Olivelli
Hello, I have drafted a PIP around this proposal. PIP link: https://github.com/apache/pulsar/issues/17155 I am preparing an official PR, I already have a working prototype. Copy of the contents of the GH issue is attached for discussion here on the Mailing list. Motivation There are many proje