Re: [DISCUSS] [GO-Client] The behavior of Seek is different with Java Client

2022-12-23 Thread Michael Marshall
+1 Thanks for your thorough description of the issue, Jiaqi Shen. I support changing the go client to match the Java client's semantics. Given that we haven't done the 1.0 release of the go client yet, I think a breaking change is acceptable. The release notes should clearly explain the changed b

Re: [DISCUSS] [GO-Client] The behavior of Seek is different with Java Client

2022-12-23 Thread Haiting Jiang
+1 for fixing this. The client API semanic should stay consistent between different client languages. Thanks, Haiting On Wed, Dec 21, 2022 at 5:37 PM Zike Yang wrote: > > Hi Jiaqi, > > Thanks for raising up this discussion. > This is the wrong behavior for the go client, and it will make it > co

Re: [DISCUSS] [GO-Client] The behavior of Seek is different with Java Client

2022-12-21 Thread Zike Yang
Hi Jiaqi, Thanks for raising up this discussion. This is the wrong behavior for the go client, and it will make it confusing for the go client user. +1 for fixing this wrong implementation even though it will introduce breaking changes. Thanks, Zike Yang On Wed, Dec 21, 2022 at 5:05 PM Yunze Xu

Re: [DISCUSS] [GO-Client] The behavior of Seek is different with Java Client

2022-12-21 Thread Yunze Xu
+1 to me. It's a breaking change, but I think it's more like a wrong implementation in Go client. Thanks, Yunze On Wed, Dec 21, 2022 at 5:00 PM Jiaqi Shen wrote: > > Hi all. > > I noticed that the behavior of go client Seek is different with Java > client, which may confuse the users. > > More d

[DISCUSS] [GO-Client] The behavior of Seek is different with Java Client

2022-12-21 Thread Jiaqi Shen
Hi all. I noticed that the behavior of go client Seek is different with Java client, which may confuse the users. More details here: https://github.com/apache/pulsar-client-go/issues/919. Overall, if go client executes `Seek(id)`, it will reset its position in `id` instead of `id+1` by default.