Re: [DISCUSS] We must change the way we review PIPs

2023-03-30 Thread Nitin Goyal
+1 (non-binding) On Fri, 31 Mar, 2023, 08:41 Jun Ma, wrote: > +1. > > Besides using a single source to lift the review efficiency, adding > control over the design documents is also a good practice from the project > management perspective. > > > Best, > Jun > >

Re: [Vote] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-01-30 Thread Nitin Goyal
gt; - persistent://public/default/local-name-partition-z (rejected by > keyword) > > > - persistent://public/default/local-name-partition-0 (rejected by > keyword) > > > > > > > > > ### API Changes > > > > > > Add a new configuration, `enableStrictTopicName=false`. > > > > > > ### Implementation > > > > > > 1. Add configuration `enableStrictTopicName=false`. > > > 2. Add rejection logic when the user enables `enableStrictTopicName`. > > > 4. Add warning logs to inform users that we do not recommend creating > non-partitioned topics with the keyword `-partition-`. > > > 5. Make `enableStrictTopicName=true` in the next major release. > -- Regards Nitin Goyal

Re: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar

2023-01-19 Thread Nitin Goyal
ongbobo184) as a member of the PMC and we are > > > > > pleased to announce that he has accepted. > > > > > > > > > > He is very active in the community in the past few years and made a > > > lot of > > > > > great contributions > > > > > such as transactions and schemas. > > > > > > > > > > Welcome Bo Cong to the Apache Pulsar PMC. > > > > > > > > > > Best Regards, > > > > > Penghui on behalf of the Pulsar PMC > > > > > > > > -- Regards Nitin Goyal

Re: [DISCUSS] PIP-239: Retry Mechanism per Message

2023-01-16 Thread Nitin Goyal
Hello all, I have a few questions. 1. When a message is NACKed does it still send the commands to the broker? 2. Do we have any plan to replace the ReconsumeLater function with NACK Backoff interface in future? On Tue, Jan 10, 2023 at 7:17 PM Nitin Goyal wrote: > Hello Team, > > T

Re: [VOTE] PIP-239: Retry Mechanism per Message title

2023-01-10 Thread Nitin Goyal
Hello all, I am extremely apologies about the discussion hours. It was my first time to have discussions and voting process and wasn’t aware about the policy. Will keep this in mind from next time. Once again apologies. Sincere Nitin Goyal On Tue, 10 Jan 2023 at 10:04 PM, Dave Fisher wrote

Re: [ANNOUNCE] Yunze Xu as a new PMC member in Apache Pulsar

2023-01-10 Thread Nitin Goyal
Congratulations! Yunze Best Nitin Goyal On Tue, Jan 10, 2023 at 6:06 PM r...@apache.org wrote: > Congrats! Yunze > > Ruguo Yu 于2023年1月10日周二 09:32写道: > > > Congratulations, Yunze! > > > > On 2022/12/29 12:42:36 Haiting Jiang wrote: > > > Hi all, > >

Re: [VOTE] PIP-239: Retry Mechanism per Message title

2023-01-10 Thread Nitin Goyal
y want to > implement this logic in the logic of Nack instead of adding more logic to > the existing ReconsumeLater, because In subsequent version iterations, I > would like to discuss with you whether we want to discard the logic of > ReconsumeLater. > > -- > Thanks > Xi

Re: [VOTE] PIP-239: Retry Mechanism per Message title

2023-01-10 Thread Nitin Goyal
gt; > > Zike Yang > > > > > > > > > > > > On Sun, Jan 8, 2023 at 3:22 PM Haiting Jiang < > > jianghait...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > +1 binding > > > > > > > > > > >

Re: [DISCUSS] PIP-239: Retry Mechanism per Message

2023-01-10 Thread Nitin Goyal
pdate if required. I hope the above content answers most of the doubts about this PIP. On Tue, Jan 10, 2023 at 5:59 PM r...@apache.org wrote: > Thanks for submitting this PIP, Nitin Goyal. > > Seeing that you have submitted a related pull request in the Go SDK > community, I am sorr

Re: [DISCUSS] PIP-239: Retry Mechanism per Message

2023-01-09 Thread Nitin Goyal
adding few properties to it like how many times it get consumed. That also allow other custom properties to be added in newly generated msg.. so if msg needs temporary high retry or change in retry count on msg they can override it using custom properties… Thanks Nitin Goyal On Mon, 9 Jan 2023 at 1

[VOTE] PIP-239: Retry Mechanism per Message title

2023-01-07 Thread Nitin Goyal
hread/b9rfv6t307z439xx3zt2ym4p140qzp06 Proposed changes in pulsar go client library. https://github.com/apache/pulsar-client-go/pull/939 Thanks Nitin Goyal

[DISCUSS] Retry logic per message

2023-01-06 Thread Nitin Goyal
consumers. Proposed PR for go client library: https://github.com/apache/pulsar-client-go/pull/939 The same can be done for other client libraries. -- Regards Nitin Goyal

[DISCUSS] PIP-239: Retry Mechanism per Message

2023-01-04 Thread Nitin Goyal
Hi all, I made a PIP to discuss: https://github.com/apache/pulsar/issues/19136 Thanks, Nitin Goyal

Re: [DISCUSS] Retry logic per message

2023-01-04 Thread Nitin Goyal
er languages can get track of this new feature, > especially it use a new system property to implement this feature. > > > Haiting > > On Wed, Jan 4, 2023 at 6:09 PM Zixuan Liu wrote: > > > > Hi Nitin, > > > > This discussion looks good to me. > > >

[DISCUSS] Retry logic per message

2023-01-04 Thread Nitin Goyal
consumers. Proposed PR for go client library: https://github.com/apache/pulsar-client-go/pull/939 The same can be done for other client libraries. -- Regards Nitin Goyal