, 2023 at 2:02 AM Asaf Mesika wrote:
> Good catch by SpotBugs.
>
> What if in this method
>
> @Override
> public ConsumerStatsRecorder getStats() {
> return stats;
> }
>
> You change return type to ConsumerStats so it's immutable ?
>
>
> On Sat,
would appreciate input on the best path forward.
Thanks,
Kai
On Tue, Mar 7, 2023 at 9:49 AM Kai Levy wrote:
> Yes, that would work.
>
> Kai
>
> On Tue, Mar 7, 2023 at 12:41 AM Asaf Mesika wrote:
>
>> On Mon, Mar 6, 2023 at 6:24 PM Kai Levy wrote:
>>
>> > I ag
Hello,
This thread is to start a vote for PIP-253
Discussion: https://lists.apache.org/thread/570x5yodg0bog4thgtstrgkgpthxmgfd
Issue: https://github.com/apache/pulsar/issues/19698
Voting will be open at least 48 hours.
Thanks!
Kai
Yes, that would work.
Kai
On Tue, Mar 7, 2023 at 12:41 AM Asaf Mesika wrote:
> On Mon, Mar 6, 2023 at 6:24 PM Kai Levy wrote:
>
> > I agree, adding it to the ConsumerStats interface makes more logical
> sense,
> > but I believe the implementation will be harde
I would rather see them as attributes of ConsumerStats .
> > > Add
> > >
> > > ProducerStats deadLetterProducerStats;
> > >
> > > ProducerStats retryLetterProducerStats();
> > >
> > >
> > > On Fri, Mar 3, 2023 at 2:54 AM
y from the consumer.
Kai
On Sun, Mar 5, 2023 at 5:19 AM Asaf Mesika wrote:
> I would rather see them as attributes of ConsumerStats .
> Add
>
> ProducerStats deadLetterProducerStats;
>
> ProducerStats retryLetterProducerStats();
>
>
> On Fri, Mar 3, 2023 at 2:54 AM Ka
Hello!
I created a new PIP because I discovered there's no way for a user to
access the metrics for a consumer's deadLetterProducer /
retryLetterProducer, since it is private to ConsumerImpl.java. I would like
to propose an API change that would expose those statistics. More details
on the github
