[VOTE] PIP-386: Add resetIncludeHead in CommandSubscribe for startMessageIdInclusive implementation

2024-10-16 Thread Jiawen Wang
Sincerely Jiawen Wang

RE: RE: Re: [DISCUSS] PIP-386: Add resetIncludeHead in CommandSubscribe for startMessageIdInclusive implementation

2024-10-16 Thread Jiawen Wang
I'll start a vote on this pip. This is intended to fix issue,and if we want to implement startMessageIdInclusive() in broker side, this pip will not affect the logic, we can do it in other pip later. On 2024/10/15 16:47:49 Jiawen Wang wrote: > Thanks for your reply ! > >

RE: Re: [DISCUSS] PIP-386: Add resetIncludeHead in CommandSubscribe for startMessageIdInclusive implementation

2024-10-15 Thread Jiawen Wang
The previous pr Fixes #23239 <https://github.com/apache/pulsar/issues/23239> is https://github.com/apache/pulsar/pull/23305 On 2024/10/11 04:19:37 Zixuan Liu wrote: > Same PIP: https://github.com/apache/pulsar/issues/14883 > > FYI. > > Jiawen Wang <15...@163.co

RE: Re: [DISCUSS] PIP-386: Add resetIncludeHead in CommandSubscribe for startMessageIdInclusive implementation

2024-10-15 Thread Jiawen Wang
). keep the logic unchange and fix issue in a lighter way. Today I viewed the PIP-150, and it seems a better implementation for startMessageInclusive. I'm not sure about this right now. Maybe we can reopen the pip-150? Thanks Jiawen Wang On 2024/10/11 04:19:37 Zixuan Liu wrote: >

[DISCUSS] PIP-386: Add resetIncludeHead in CommandSubscribe for startMessageIdInclusive implementation

2024-10-09 Thread Jiawen Wang
Hi dev, I proposed a PIP: https://github.com/apache/pulsar/pull/23427, this pip is intended to fix issue https://github.com/apache/pulsar/issues/23239. Please take a look and give your feedback. Best Regards! Jiawen Wang