Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
All the tests get passed and I have merged the PR Thanks Penghui On Wed, Jun 18, 2025 at 7:40 PM PengHui Li wrote: > Here is the PR https://github.com/apache/pulsar/pull/24429 to > revert https://github.com/apache/pulsar/pull/23611 and a related PR > > Thanks, > Penghui > > On Wed, Jun 18, 2025

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
Here is the PR https://github.com/apache/pulsar/pull/24429 to revert https://github.com/apache/pulsar/pull/23611 and a related PR Thanks, Penghui On Wed, Jun 18, 2025 at 6:24 PM WenZhi Feng wrote: > I'm good to only revert from branch-4.0 too. > > Thanks, > Wenzhi Feng. > > > On 2025/06/19 00:3

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread WenZhi Feng
I'm good to only revert from branch-4.0 too. Thanks, Wenzhi Feng. On 2025/06/19 00:36:18 PengHui Li wrote: > > the main problem is that this kind of optimization should never have been > cherry-picked into a stable branch. > > > We should be way more strict in only backporting bug-fixes / > sec

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
> the main problem is that this kind of optimization should never have been cherry-picked into a stable branch. > We should be way more strict in only backporting bug-fixes / security-fixes into stable branches. Every other improvement or feature will roll into the next feature release. +1, I'm g

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread Matteo Merli
Hi WenZhi, the main problem is that this kind of optimization should never have been cherry-picked into a stable branch. We should be way more strict in only backporting bug-fixes / security-fixes into stable branches. Every other improvement or feature will roll into the next feature release.

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread WenZhi Feng
Hi Penghui, Thanks for your reply and the evidence provided. We can fix this problem by improving the implementation of method `getNumberOfDelayedMessages()`, which is a simple patch. I can help to do this. thanks, Wenzhi Feng. On 2025/06/18 23:26:08 PengHui Li wrote: > Hi Wenzhi, > > After up

Re: [DISCUSS] PIP-423: Add Support for Cancelling Individual Delayed Messages

2025-06-18 Thread PengHui Li
Hi SiNan, You can have a new method such as: void skipMessages(String topic, String subName, Map messageIds) Regards, Penghui On Wed, Jun 18, 2025 at 6:56 AM SiNan Liu wrote: > I think it's actually okay too. > > That is to add a new parameter `Map messageIds` to > `skipMessages`, with key as

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
Hi Wenzhi, After upgrading our broker environment from version 3.0.x to 4.0.x, we observed a critical performance regression. The broker's CPU usage has consistently been more than three times higher than pre-upgrade levels, causing it to hit its allocated CPU limit. The stacktrace from the proce

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread WenZhi Feng
-1 until much clearer proof is shown. On 2025/06/18 22:26:26 PengHui Li wrote: > Hi team, > > I am writing to propose an urgent revert of PR #23611 > > - https://github.com/apache/pulsar/pull/23611 > > *Reason for Revert:* > > This PR has introduced a significant performance regression in the

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread WenZhi Feng
Hi PengHui, More detailed information is needed to decide whether to revert. We have launched it to the production environment, and everything seems fine. If there is any evidence indicating that the issue was introduced by this PR, we can either fix it or revert it. However, we cannot revert it

Re: [DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread Matteo Merli
+1 -- Matteo Merli On Wed, Jun 18, 2025 at 3:27 PM PengHui Li wrote: > Hi team, > > I am writing to propose an urgent revert of PR #23611 > > - https://github.com/apache/pulsar/pull/23611 > > *Reason for Revert:* > > This PR has introduced a significant performance regression in the Pulsar > b

[DISCUSS] Urgent: Proposed Revert of PR #23611

2025-06-18 Thread PengHui Li
Hi team, I am writing to propose an urgent revert of PR #23611 - https://github.com/apache/pulsar/pull/23611 *Reason for Revert:* This PR has introduced a significant performance regression in the Pulsar broker. The attached flame graph visually demonstrates increased CPU utilization and time s

[DISCUSS] PIP-428: Change TopicPoliciesService interface to fix consistency issues

2025-06-18 Thread Lari Hotari
Dear Pulsar Community, I'd like to propose PIP-428, which addresses critical consistency issues in the TopicPoliciesService interface and updating topic policies in Pulsar. Problem: The current topic policies implementation has production-impacting issues: - Data corruption when multiple policies

Re: [DISCUSS] PIP-423: Add Support for Cancelling Individual Delayed Messages

2025-06-18 Thread SiNan Liu
I think it's actually okay too. That is to add a new parameter `Map messageIds` to `skipMessages`, with key as `ledgerId` and value as `entryId`. However, `numMessages` is a required parameter, how should this part be designed well? - Set `numMessages` to -1 or 0? And execute the logic of `intern

Re: [DISCUSS] PIP-427: Align 'set-persistence' default for mark-delete rate with broker config

2025-06-18 Thread Lari Hotari
Makes sense, thanks for handling this. -Lari On 2025/06/18 02:52:28 PengHui Li wrote: > Hi everyone, > > I would like to start a discussion on a proposal to improve the default > behavior of the pulsar-admin namespaces set-persistence command. > > *The Problem:* > > Currently, if an operator u