Re: [DISCUSS] PIP-393: Improve performance of Negative Acknowledgement

2024-11-26 Thread Lari Hotari
It's fine to split the implementation in multiple PRs. One detail about the implementation PR title. Please don't add "[pip]" in the PR title of PIP implementations. That prefix is meant to be used for the PIP document PR. -Lari On Tue, 26 Nov 2024 at 12:03, WenZhi Feng wrote: > > Hi Lari. > Tha

Re: [DISCUSS] PIP-393: Improve performance of Negative Acknowledgement

2024-11-26 Thread WenZhi Feng
Hi Lari. Thanks for feedback. It is necessary to reduce the size of dependency which has been added in high level design of the pip. > Would it be possible to cover this important aspect as part of PIP-393 > before taking it to voting? Do you means that we fix this problem as part of the implemen

Re: [VOTE] Release Apache Pulsar 3.3.3 based on 3.3.3-candidate-1

2024-11-26 Thread Philipp Dolif
+1 (non-binding) - Built from source - Checked the signatures of the source and binary release artifacts - Ran pulsar standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function Thanks, Philipp

Re: [VOTE] Release Apache Pulsar 3.0.8 based on 3.0.8-candidate-1

2024-11-26 Thread Philipp Dolif
+1 (non-binding) - Built from source - Checked the signatures of the source and binary release artifacts - Ran pulsar standalone - Checked producer and consumer - Verified the Cassandra connector - Verified the Stateful function Thanks, Philipp

Re: [DISCUSS] PIP-393: Improve performance of Negative Acknowledgement

2024-11-26 Thread Lari Hotari
Great work, Wenzhi. The PIP-393 document should include the high level plan of avoiding to increase the size of the Pulsar client by the size of fastutil jar file. The fastutil jar file is very large, 23MB. We use only a few classes of fastutil. There's fastutil-core library which is smaller, abou