Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-13 Thread 太上玄元道君
+1 nonbinding Matteo Merli 于2024年3月14日周四 09:45写道: > PIP: https://github.com/apache/pulsar/pull/22178 > > WIP PR: https://github.com/apache/pulsar/pull/22179 > > > > > -- > Matteo Merli > >

[VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-13 Thread Matteo Merli
PIP: https://github.com/apache/pulsar/pull/22178 WIP PR: https://github.com/apache/pulsar/pull/22179 -- Matteo Merli

Re: [DISCUSS] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-13 Thread Matteo Merli
I have updated the proposal (and the WIP PR) based on the very helpful feedback received. I will start a VOTE thread for this PIP. Thanks. -- Matteo Merli On Sun, Mar 3, 2024 at 5:14 AM 太上玄元道君 wrote: > +1 > > Enrico Olivelli 于2024年3月3日 周日16:58写道: > > > I support the initiative > > > > Lgtm

Re: [VOTE] PIP-332: peek messages from topic subscription with offset value

2024-03-13 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Mar 11, 2024 at 12:17 PM Yunze Xu wrote: > +1 (binding) > > The proposal overall LGTM. But since the PIP itself and its > implementation are coupled in the same PR, I left minor comments in > that PR directly, which does not affect my +1. > > Thanks, > Yunz