Re: [DISCUSS] PIP-345: Optimize finding message by timestamp

2024-03-11 Thread 太上玄元道君
Hi Dave, Thanks for your review! Perhaps it's because I wrote more detailed steps, but the key points is: 1. Deserialize MessageMetadata once broker received message 2. Pass MessageMetadata to `PublishContext` 3. After add entries finished, get `publishTimestamp` from `PublishContext#messageMetada

Re: [DISCUSS] PIP-345: Optimize finding message by timestamp

2024-03-11 Thread Dave Fisher
What can you say about the time spent to maintain these new ledger fields? I think you are asking to modify the main message logic which is highly optimized., but I’m not sure. Have you tried your code on your own hardware? Do you have performance comparisons of the normal flow? > On Mar 11, 20

Re: [DISCUSS] PIP-345: Optimize finding message by timestamp

2024-03-11 Thread 太上玄元道君
bump 太上玄元道君 于2024年3月11日 周一17:55写道: > bump > > 太上玄元道君 于2024年3月10日周日 06:41写道: > >> Hi Pulsar community, >> >> A new PIP is opened, this thread is to discuss PIP-345: Optimize finding >> message by timestamp. >> >> Motivation: >> Finding message by timestamp is widely used in Pulsar: >> * It is use

[VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-11 Thread Yunze Xu
This is the second release candidate for Apache Pulsar Client C++, version 3.5.0. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/milestone/6?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we ar

Re: [DISCUSS] PIP-345: Optimize finding message by timestamp

2024-03-11 Thread 太上玄元道君
bump 太上玄元道君 于2024年3月10日周日 06:41写道: > Hi Pulsar community, > > A new PIP is opened, this thread is to discuss PIP-345: Optimize finding > message by timestamp. > > Motivation: > Finding message by timestamp is widely used in Pulsar: > * It is used by the `pulsar-admin` tool to get the message id