Re: [VOTE] Release Apache Pulsar Helm Chart 3.2.0 based on 3.2.0-candidate-1

2024-01-17 Thread Lari Hotari
This release vote is cancelled since there's a new vote out for Apache Pulsar Helm Chart 3.2.0-candidate-2: https://lists.apache.org/thread/f0zn9882wmkwcm768v1h38ys6z5qncto -Lari On 2024/01/17 10:07:32 Lari Hotari wrote: > Hello Apache Pulsar Community, > > This is a call for the vote to releas

[VOTE] Release Apache Pulsar Helm Chart 3.2.0 based on 3.2.0-candidate-2

2024-01-17 Thread Lari Hotari
Hello Apache Pulsar Community, This is a call for the vote to release the Apache Pulsar Helm Chart version 3.2.0. Release notes for 3.2.0-candidate-2: https://github.com/apache/pulsar-helm-chart/releases/tag/pulsar-3.2.0-candidate-2 The release candidate is available at: https://dist.apache.org

Re: [VOTE] PIP-330: getMessagesById gets all messages

2024-01-17 Thread Zixuan Liu
This PIP has been approved by 3 +1 (binding): - Jiwei - Yunze - Penghui Thanks, Zixuan Zixuan Liu 于2024年1月15日周一 17:33写道: > Hi Pulsar Community, > > Voting for PIP-330: getMessagesById gets all messages > > PIP: https://github.com/apache/pulsar/pull/21873 > Discussion thread: > https://lists.ap

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread PengHui Li
> I see, it only affects the TTL. We can acknowledge the messages to clean up the data. Then we have to document the `brokerInterceptors` config clearly to say TTL might not work if `AppendBrokerTimestampMetadataInterceptor` is not configured. Yes, and LinLin figured out a better solution to mitig

Re: [VERIFY] Pulsar Release 3.2.0 Candidate 2

2024-01-17 Thread PengHui Li
It looks like something broke the behavior of the querystate from Pulsar Functions. 1. The querystate exit with `Reason: key 'hello' doesn't exist`, which the old version will not exit ``` lipenghui@lipenghuis-MacBook-Pro apache-pulsar-3.2.0 % bin/pulsar-admin functions querystate --tenant test -

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread Yunze Xu
I see, it only affects the TTL. We can acknowledge the messages to clean up the data. Then we have to document the `brokerInterceptors` config clearly to say TTL might not work if `AppendBrokerTimestampMetadataInterceptor` is not configured. Thanks, Yunze On Thu, Jan 18, 2024 at 10:41 AM PengHui

Re: [VOTE] PIP-330: getMessagesById gets all messages

2024-01-17 Thread PengHui Li
+1 (binding) Regards, Penghui On Wed, Jan 17, 2024 at 8:03 PM Yunze Xu wrote: > +1 (binding) > > Thanks, > Yunze > > On Wed, Jan 17, 2024 at 6:55 PM guo jiwei wrote: > > > > +1 (binding) > > > > > > Regards > > Jiwei Guo (Tboy) > > > > > > On Wed, Jan 17, 2024 at 5:39 PM 太上玄元道君 wrote: > > > >

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread PengHui Li
> I don't think we should provide such an option for users. Compared with the serious security issue, the extra overhead (13 bytes) per entry (not per message) should never be a concern. It actually changed the stored data format. As far as I know, there are some users who read data from the offlo

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread PengHui Li
> We should also improve the TTL: > When client publish time > Ledger create time + Ledger rollover time, > and `brokerPublishTime` is not set, > we can make Ledger TTL time = Ledger create time + Ledger rollover time. > This change can make sure entry expires when client clock is not right. Thi

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread Yunze Xu
>From my perspective, it's a serious security issue. The client side could easily make Pulsar's message expiry mechanism not work. Even if it's not a malicious change made by users, it would be hard to figure out what makes the message not expired. > Users can still have a way to disable it if the

Re: [VOTE] PIP-330: getMessagesById gets all messages

2024-01-17 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Wed, Jan 17, 2024 at 6:55 PM guo jiwei wrote: > > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Wed, Jan 17, 2024 at 5:39 PM 太上玄元道君 wrote: > > > +1 nonbinding > > > > > > > 2024年1月17日 17:35,Asaf Mesika 写道: > > > > > > +1 (non-binding) > > > > > > On Tue,

Re: [VOTE] PIP-330: getMessagesById gets all messages

2024-01-17 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Wed, Jan 17, 2024 at 5:39 PM 太上玄元道君 wrote: > +1 nonbinding > > > > 2024年1月17日 17:35,Asaf Mesika 写道: > > > > +1 (non-binding) > > > > On Tue, Jan 16, 2024 at 4:43 AM Dezhi Liu wrote: > > > >> +1 (non-binding) > >> > >> Thanks, > >> Dezhi Liu > >> > >>

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-17 Thread Lin Lin
Only enabled `AppendBrokerTimestampMetadataInterceptor` is not enough. We should also improve the TTL: When client publish time > Ledger create time + Ledger rollover time, and `brokerPublishTime` is not set, we can make Ledger TTL time = Ledger create time + Ledger rollover time. This change c

[VOTE] Release Apache Pulsar Helm Chart 3.2.0 based on 3.2.0-candidate-1

2024-01-17 Thread Lari Hotari
Hello Apache Pulsar Community, This is a call for the vote to release the Apache Pulsar Helm Chart version 3.2.0. Release notes for 3.2.0-candidate-1: https://github.com/apache/pulsar-helm-chart/releases/tag/pulsar-3.2.0-candidate-1 The release candidate is available at: https://dist.apache.org

Re: [VOTE] PIP-330: getMessagesById gets all messages

2024-01-17 Thread 太上玄元道君
+1 nonbinding > 2024年1月17日 17:35,Asaf Mesika 写道: > > +1 (non-binding) > > On Tue, Jan 16, 2024 at 4:43 AM Dezhi Liu wrote: > >> +1 (non-binding) >> >> Thanks, >> Dezhi Liu >> >> On 2024/01/15 09:33:48 Zixuan Liu wrote: >>> Hi Pulsar Community, >>> >>> Voting for PIP-330: getMessagesById g

Re: [VOTE] PIP-330: getMessagesById gets all messages

2024-01-17 Thread Asaf Mesika
+1 (non-binding) On Tue, Jan 16, 2024 at 4:43 AM Dezhi Liu wrote: > +1 (non-binding) > > Thanks, > Dezhi Liu > > On 2024/01/15 09:33:48 Zixuan Liu wrote: > > Hi Pulsar Community, > > > > Voting for PIP-330: getMessagesById gets all messages > > > > PIP: https://github.com/apache/pulsar/pull/2187