[VOTE] Pulsar Client Go Release 0.12.0 Candidate 2

2024-01-14 Thread Zike Yang
Hi everyone, Please review and vote on the release candidate #2 for the version 0.12.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This is the second release candidate for Apache Pulsar Go client, version 0.12.0. The release note/

Re: [VOTE] PIP-325: Add command to abort transaction

2024-01-14 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Mon, Jan 15, 2024 at 10:25 AM guo jiwei wrote: > > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Mon, Jan 15, 2024 at 9:36 AM PengHui Li wrote: > > > +1 (binding) > > > > Regards, > > Penghui > > > > On Mon, Jan 8, 2024 at 4:00 PM Enrico Olivelli > > wrot

Re: [DISCUSS] Break change: could not subscribe partitioned topic with a suffix-matched regexp due to a mistake of PIP-145

2024-01-14 Thread Yubiao Feng
Hi Penghui > Enabled `enableBrokerSideSubscriptionPatternEvaluation` and > setting `patternAutoDiscoveryPeriod` to a little value may > solve the problem. Correct this answer: - Disable `enableBrokerSideSubscriptionPatternEvaluation`(the config on the broker-side) will solve this problem. BYW,

Re: [DISCUSS] Break change: could not subscribe partitioned topic with a suffix-matched regexp due to a mistake of PIP-145

2024-01-14 Thread Yubiao Feng
Hi Penghui > Do we have a workaround for this break change? > Is disabling PIP-145 can help with it? Enabled `enableBrokerSideSubscriptionPatternEvaluation` and setting `patternAutoDiscoveryPeriod` to a little value may solve the problem. Thanks Yubiao Feng On Mon, Jan 15, 2024 at 10:03 AM Pen

Re: [VOTE] PIP-325: Add command to abort transaction

2024-01-14 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Mon, Jan 15, 2024 at 9:36 AM PengHui Li wrote: > +1 (binding) > > Regards, > Penghui > > On Mon, Jan 8, 2024 at 4:00 PM Enrico Olivelli > wrote: > > > +1 (binding) > > > > > > Enrico > > > > Il Lun 8 Gen 2024, 03:55 ruihongzhou ha > > scritto: > > >

Re: [DISCUSS] Always set a broker side timestamp for message and deprecate some API

2024-01-14 Thread PengHui Li
IMO, we should enable `AppendBrokerTimestampMetadataInterceptor` by default. Users can still have a way to disable it if they care about the additional metadata stored in each entry. For the `hasBrokerPublishTime` API. The topic might also have historical data without broker publish time. So, it s

Re: [DISCUSS] Break change: could not subscribe partitioned topic with a suffix-matched regexp due to a mistake of PIP-145

2024-01-14 Thread PengHui Li
Do we have a workaround for this break change? Is disabling PIP-145 can help with it? Regards, Penghui On Fri, Jan 12, 2024 at 6:29 PM Yubiao Feng wrote: > Hi all > > I noticed that the PIP-145 made a break change that caused clients to not > subscribe to partitioned topics with a suffix-matche

Re: [VERIFY] Pulsar Release 3.2.0 Candidate 1

2024-01-14 Thread guo jiwei
Hi Zike, Thanks for reporting this, drop this candidate, I will raise a new candidate after the fix. Regards Jiwei Guo (Tboy) On Fri, Jan 12, 2024 at 10:46 AM Zike Yang wrote: > There is a regression bug introduced in 3.2.0: > https://github.com/apache/pulsar/issues/21888 > The producer na

Re: [VOTE] PIP-325: Add command to abort transaction

2024-01-14 Thread PengHui Li
+1 (binding) Regards, Penghui On Mon, Jan 8, 2024 at 4:00 PM Enrico Olivelli wrote: > +1 (binding) > > > Enrico > > Il Lun 8 Gen 2024, 03:55 ruihongzhou ha > scritto: > > > Hi community, > > > > This thread is to start a vote for PIP-325: Add command to abort > > transaction. > > > > PIP: http