Re: [DISCUSS] PIP-310: Support custom publish rate limiters

2023-11-03 Thread Girish Sharma
Hello Lari, replies inline. On Fri, Nov 3, 2023 at 11:13 PM Lari Hotari wrote: > Hi Girish, > > Thanks for the questions. I'll reply to them > > > does this sharing of the same tcp/ip connection happen across partitions > as > > well (assuming both the partitions of the topic are on the same br

Re: [DISCUSS] PIP-310: Support custom publish rate limiters

2023-11-03 Thread Lari Hotari
Hi Girish, Thanks for the questions. I'll reply to them > does this sharing of the same tcp/ip connection happen across partitions as > well (assuming both the partitions of the topic are on the same broker)? > i.e. producer 127.0.0.1 for partition > `persistent://tenant/ns/topic0-partition0` and

Re: [DISCUSS] PIP-310: Support custom publish rate limiters

2023-11-03 Thread Lari Hotari
Hi Tao, You seemed to miss sending the link that you were referring to. Are you referring to the thread "[discuss] Support fail-fast strategy when broker rate-limited" [1] ? -Lari 1 - https://lists.apache.org/thread/tp2f1ghomj2kw5ltgz8w8k5s58gs88qz On 2023/11/03 12:11:31 太上玄元道君 wrote: > Hi

Re: [DISCUSS] PIP-310: Support custom publish rate limiters

2023-11-03 Thread Girish Sharma
Hello Tao, As I understand, there is a fine balance between rate-limiting, backpressure and not keeping clients waiting. Different use cases may need different approach to rate-limiting and thus, making rate limiter customizable is my first step towards making pulsar more customizable as per need.

Re: [DISCUSS] PIP-310: Support custom publish rate limiters

2023-11-03 Thread 太上玄元道君
Hi Girish, There is also a discussion thread[1] about rate-limiting. I think there is some conflicts between some kind of rate-limiter and backpressure Take the fail-fast strategy as an example: Brokers have to reply to clients after receiving and decode the message, but the broker also has the

Re: [DISCUSS] PIP-310: Support custom publish rate limiters

2023-11-03 Thread Girish Sharma
Hello Lari, Thanks for bringing this to my attention. I went through the links, but does this sharing of the same tcp/ip connection happen across partitions as well (assuming both the partitions of the topic are on the same broker)? i.e. producer 127.0.0.1 for partition `persistent://tenant/ns/topi

Re: [DISCUSS] PIP-310: Support custom publish rate limiters

2023-11-03 Thread Lari Hotari
Hi Girish, In order to address your problem described in the PIP document [1], it might be necessary to make improvements in how rate limiters apply backpressure in Pulsar. Pulsar uses mainly TCP/IP connection level controls for achieving backpressure. The challenge is that Pulsar can share a