Re: [DISCUSS] Cherry-pick #18518 into branch-2.10 and branch-2.11

2023-09-04 Thread mattisonchao
+1 Best, Mattison On 5 Sep 2023 at 10:00 +0800, PengHui Li , wrote: > +1 > > Thanks, > Penghui > > On Fri, Sep 1, 2023 at 3:04 AM Yubiao Feng > wrote: > > > Cherry-picked. > > > > Since the method `isPartitionedTopicBeingDeletedAsync` only exists in > > `branch-3.0`, the change > > > > https://gi

Re: [DISCUSS] Consistent code style (esp. ws/indent) and autotools

2023-09-04 Thread Hang Chen
>While I can agree that a consistent style can help I don’t agree that it is >necessary. If the compiler understands the code then IMO we are good. I agree with Dave's idea. My concern is how much value this change will bring to Pulsar. What's more, it will bring other burdens, such as PR review,

Re: [DISCUSS] Cherry-pick #18518 into branch-2.10 and branch-2.11

2023-09-04 Thread PengHui Li
+1 Thanks, Penghui On Fri, Sep 1, 2023 at 3:04 AM Yubiao Feng wrote: > Cherry-picked. > > Since the method `isPartitionedTopicBeingDeletedAsync` only exists in > `branch-3.0`, the change > > https://github.com/apache/pulsar/pull/18518/files#diff-38fac527320b93f0e9ea2459420f56638299627f7f29c0148

Re: [DISCUSS] PIP-299: A limitation for the max size of cursor metadata to persist

2023-09-04 Thread PengHui Li
Hi Yubiao, Thank you for spearheading the proposal. I believe it would bring about a substantial enhancement in user experience. Additionally, we should contemplate adopting the new approach as the default behavior of Pulsar. The existing configuration has the potential to result in extensive red

Re: [VOTE] PIP-297: Support terminating Function & Connector with the fatal exception

2023-09-04 Thread mattisonchao
+1 (binding) Best, Mattison On 5 Sep 2023 at 09:07 +0800, PengHui Li , wrote: > +1 (binding) > > Thanks, > Penghui > > On Tue, Sep 5, 2023 at 8:40 AM Baodi Shi wrote: > > > +1(non-binding) > > > > > > Thanks, > > Baodi Shi > > > > > > On Sep 5, 2023 at 05:23:38, Enrico Olivelli wrote: > > > > >

Re: [Discuss] Release RPM packages with cxx11 ABI

2023-09-04 Thread PengHui Li
+1 And if we can have a README file under the cpp client distribution directory. It should be great. Users can find the explanation of what legacy means. Regards, Penghui On Mon, Sep 4, 2023 at 7:54 PM Yunze Xu wrote: > Hi all, > > Currently the official released pre-built binaries for Linux i

Re: [VOTE] PIP-297: Support terminating Function & Connector with the fatal exception

2023-09-04 Thread PengHui Li
+1 (binding) Thanks, Penghui On Tue, Sep 5, 2023 at 8:40 AM Baodi Shi wrote: > +1(non-binding) > > > Thanks, > Baodi Shi > > > On Sep 5, 2023 at 05:23:38, Enrico Olivelli wrote: > > > +1 (binding) > > > > Enrico > > > > Il giorno lun 4 set 2023 alle ore 12:32 Zike Yang ha > > scritto: > > > >

Re: [VOTE] PIP-297: Support terminating Function & Connector with the fatal exception

2023-09-04 Thread Baodi Shi
+1(non-binding) Thanks, Baodi Shi On Sep 5, 2023 at 05:23:38, Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il giorno lun 4 set 2023 alle ore 12:32 Zike Yang ha > scritto: > > > Hi, all > > > Since there are no other concerns in the discussion, I'm delighted to > > start the voting pr

Re: [VOTE] PIP-297: Support terminating Function & Connector with the fatal exception

2023-09-04 Thread Enrico Olivelli
+1 (binding) Enrico Il giorno lun 4 set 2023 alle ore 12:32 Zike Yang ha scritto: > > Hi, all > > Since there are no other concerns in the discussion, I'm delighted to > start the voting process for the PIP-297. > > Here is the link to the PIP: https://github.com/apache/pulsar/pull/21079 > > BR,

[Discuss] Release RPM packages with cxx11 ABI

2023-09-04 Thread Yunze Xu
Hi all, Currently the official released pre-built binaries for Linux include: - RPM packages for RedHat-based Linux distros - DEB packages for Debian-based Linux distros - APK packages for Alpine-based Linux distros Though they are provided in different Linux distributions, they are all compiled

Re: [DISCUSS] Consistent code style (esp. ws/indent) and autotools

2023-09-04 Thread 徐昀泽
Well, I’m just back to this thread. Now I’m +1 to this extremely huge change, but to be more friendly to developers, we should document the workarounds for the git blame issue. And we should apply the spotless tool to every active branches. > On Sep 3, 2023, at 19:43, Asaf Mesika wrote: > > I c

[VOTE] PIP-297: Support terminating Function & Connector with the fatal exception

2023-09-04 Thread Zike Yang
Hi, all Since there are no other concerns in the discussion, I'm delighted to start the voting process for the PIP-297. Here is the link to the PIP: https://github.com/apache/pulsar/pull/21079 BR, Zike Yang

[DISCUSS] PIP-299: A limitation for the max size of cursor metadata to persist

2023-09-04 Thread Yubiao Feng
Hi all I proposed this PIP https://github.com/apache/pulsar/pull/21118, to provide a way to limit the max size of cursor metadata to persist. Please take a look and let me know what you think. Thanks Yubiao Feng