Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Joo Hyuk Kim
> `brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec=1` So, the "per-min" config can be more granular. Oh, okay. I thought we would end up only using one of `brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute` `brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec` ... these two. If there

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Heesung Sohn
> but we should also consider per-minute could be too slow for some. Could you clarify this part? `brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute=60` is the same as `brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec=1` So, the "per-min" config can be more granular. Heesung On Thu, Jul

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Joo Hyuk Kim
Hi, I agree that unloading per-sec might too fast, but we should also consider per-minute could be too slow for some. So we might as well add configurability for unload rate (in seconds).But I am concerend that we might end up having too many parameters 🤔 Thanks, JooHyukKim(vince) On Fri, Jul 7,

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Heesung Sohn
Hi, I agree with configuring the `shutdown.unloadNamespaceBundlesGracefully` behavior by a dynamic config. Also, I wonder if the better config is `brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute` to support a slower rate. One bundle unloading per sec could be too fast if there are many top

Re: [VOTE] PIP-273: Enable hostname verification by default

2023-07-06 Thread Michael Marshall
Closing vote as passed with 3 binding +1s (Michael, Yunze, and Enrico) and 1 non-binding +1 (Zixuan). I'll make sure the PRs are up to date and will start requesting reviews to get them merged. Thanks, Michael On Tue, Jun 6, 2023 at 8:54 AM Zixuan Liu wrote: > > +1 (non-binding) > > Thanks, > Z

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Joo Hyuk Kim
Thanks, 🙂 JooHyukKim (vince) On Fri, Jul 7, 2023 at 11:59 AM Joo Hyuk Kim wrote: > > When Pulsar undergoes a graceful shutdown, it unloads all topics, but > there is no limit on the rate of unloading > > Is it possible that following code might already cover what we need here? > > > https://git

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Joo Hyuk Kim
> When Pulsar undergoes a graceful shutdown, it unloads all topics, but there is no limit on the rate of unloading Is it possible that following code might already cover what we need here? https://github.com/apache/pulsar/blob/7636e8989f4d3fc24fce69a356d54e1c550945ed/pulsar-broker/src/main/java/o

RE: [VOTE] Pulsar Node.js Client Release 1.9.0 Candidate 1

2023-07-06 Thread Masahiro Sakamoto
+1 (binding) - verified checksum and signature - confirmed that the build was successful - ran produce/consume Regards, Masahiro Sakamoto Yahoo Japan Corp. E-mail: massa...@yahoo-corp.jp

Re: Request to contribute to Apache Pulsar JIRA maintenance and documentation

2023-07-06 Thread Dave Fisher
Adding the OP who is not subscribed. Sent from my iPhone > On Jul 6, 2023, at 6:35 PM, Yu wrote: > > Hi Yuvaraj, > > Thank you for your willingness to contribute to the Pulsar documentation! > > Feel free to select your desired issues from > https://github.com/apache/pulsar/issues?q=is%3Aope

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Dave Fisher
Hi - Interesting. I’m curious to know what Heesung, Lari, and others think. Best, Dave Sent from my iPhone > On Jul 6, 2023, at 7:01 PM, labuladong wrote: > > Dear Apache Pulsar community, > > > When Pulsar undergoes a graceful shutdown, it unloads all topics, but there > is no limit on t

Re: Request to contribute to Apache Pulsar JIRA maintenance and documentation

2023-07-06 Thread Yu
Hi Yuvaraj, Thank you for your willingness to contribute to the Pulsar documentation! Feel free to select your desired issues from https://github.com/apache/pulsar/issues?q=is%3Aopen+is%3Aissue+label%3Adoc-required . You can find the documentation contribution guide at https://pulsar.apache.org/

[DISCUSS] PIP-281: Optimize Bundle Unload(Transfer) Protocol for ExtensibleLoadManager

2023-07-06 Thread Heesung Sohn
Hi dev, I proposed this PIP, https://github.com/apache/pulsar/pull/20748, to make unloaded clients directly and gracefully connect to new owner brokers without lookups. Please take a look and let me know what you think. Regards, Heesung

Re: [VOTE] Pulsar Node.js Client Release 1.9.0 Candidate 1

2023-07-06 Thread Oguni Hideaki
+1 (non-binding) - Verified checksum and signature - Build from source codes - Verified pub/sub Hideaki Oguni Yahoo Japan Corp.

Re: [VOTE] PIP-276: Add metric `pulsar_topic_load_times

2023-07-06 Thread Yu
Thank you all. We've added the doc in https://github.com/apache/pulsar-site/pull/631 On Mon, Jul 3, 2023 at 11:15 AM guo jiwei wrote: > Close the vote with 4(+1 binding) 2(+1 non-binding) 0(-1) > > binding: > Hang > Yunze > Mattison > Penghui > > non-binding > Yubiao > Asaf > > > Regards >