Hi Zike
> https://github.com/apache/pulsar/pull/20690
cherry-picked into branch-3.0
Thanks
Yubiao Feng
On Fri, Jun 30, 2023 at 12:37 PM Yubiao Feng
wrote:
> Hi Zike
>
> There is a bug fix involving a regression:
> - https://github.com/apache/pulsar/pull/20690
>
> Thanks
> Yubiao Feng
>
> On T
We’ve been seeing this too.
The issue is that the docker build gets it mirror list from Ubuntu, some of the
mirrors are bad, and output reveals that the patching of the original ubuntu
image requires every patch and these eventually stall. We are working on
improvements to mirror selection.
I
My mistake. It looks that for some reason Spotless supports .editorconfig only
for ktlint.
Best,
Kiryl
From: Kiryl Valkovich
Date: Friday, June 30, 2023 at 6:45 AM
To: dev@pulsar.apache.org
Subject: Re: [DISCUSS] Consistent code style (esp. ws/indent) and autotools
Hi,
tison, are you going to
Hi,
tison, are you going to use .editorconfig for specifying indent rules?
https://editorconfig.org/
It looks like Spotless supports it.
https://github.com/diffplug/spotless/issues/734
Flink and many other ASF projects use it.
https://github.com/apache/flink/blob/21eba4ca4cb235a2189c94cdbf3ab
Hi, everyone
Since this PR cherry-picked to branch-2.11, the Docker image build failed.
The reason is this script `
https://github.com/apache/pulsar/blob/branch-2.10/docker/pulsar/scripts/install-pulsar-client.sh`,
ubuntu 20.04 python version is 3.8, but 22.04 python version is 3.10.
Furthermore,
Hi Zike
There is a bug fix involving a regression:
- https://github.com/apache/pulsar/pull/20690
Thanks
Yubiao Feng
On Thu, Jun 1, 2023 at 7:38 PM Zike Yang wrote:
> Hi all,
>
> I would like to propose releasing the Pulsar 3.0.1.
>
> Currently, there are 95 new commits in branch-3.0:
> https:/
I would wait to make changes on a branch immediately after the next patch
releases.
Best,
Dave
Sent from my iPhone
> On Jun 29, 2023, at 8:52 PM, tison wrote:
>
> `git blame` can set a start commit [1] so you can actually blame before the
> format commit. It's integrated with IDEA[2] and Gi
+1 binding
Regards
Jiwei Guo (Tboy)
On Thu, Jun 29, 2023 at 2:38 PM Enrico Olivelli wrote:
> +1 binding
>
> Thank you
> Enrico
>
> Il giorno mer 28 giu 2023 alle ore 08:57 Haiting Jiang
> ha scritto:
> >
> > +1 binding
> >
> > Thanks,
> > Haiting
> >
> > On Wed, Jun 28, 2023 at 10:17 AM houx
`git blame` can set a start commit [1] so you can actually blame before the
format commit. It's integrated with IDEA[2] and GitHub Web UI[3][4] also.
Best,
tison.
[1]
https://stackoverflow.com/questions/5098256/how-can-i-view-prior-commits-with-git-blame
[2]
https://www.jetbrains.com/help/idea/vi
One thing I’m concerned about is that the code reformatting could bring very
wide changes and it’s very unfriendly to the `git blame` command.
The check style plugin was not applied to all modules as well. There were many
PRs to apply the check style plugin for different modules. Take my PR [1] as
> Spotless has an IDEA plugin, but it's for Gradle task only.
I saw this one also 🥲.
> [1] can be used
Nice, IMO having at least one will suffice 👍🏻.
Thanks,
joohyuk
On Fri, Jun 30, 2023 at 11:43 AM tison wrote:
> > IDE
>
> If using the palantir style, [1] can be used. Spotless has an IDEA p
> IDE
If using the palantir style, [1] can be used. Spotless has an IDEA plugin
but it's for Gradle task only.
Best,
tison.
[1] https://plugins.jetbrains.com/plugin/13180-palantir-java-format
Joo Hyuk Kim 于2023年6月30日周五 10:38写道：
> Sounds great.
>
> Another thing is about IDE.
> Pulsar site so
Sounds great.
Another thing is about IDE.
Pulsar site sort of directs contributors to use IntelliJ as shown in
https://pulsar.apache.org/contribute/setup-ide/.
It would be nice if there was IDE support (auto-format, or shortkey-base)
and we can add it to the setup-ide guide also.
Do you know any?
Hi,
I'd like to propose applying a consistent code style (especially whitespace
and indent) with an autotool Spotless.
// Background
Over and over we argue contributors reformat their patch manually for
checkstyle violations, or even whitespace changes that are not detected by
checkstyle. [1]
A
May I make a proposal : adding `remote` flag also? 🙂
#Concern : It seems like we are sort of allowing users to assume what the
ones without `local` flag are (are called by the community).
#Possible Benfit : Users will benefit from not having to think about what `
non-local` clusters are called.
Hi,@tison, @Jarek Potiuk
Thanks for your explanation, I got it.
Thanks,
Baodi Shi
On Jun 29, 2023 at 18:17:24, Jarek Potiuk wrote:
> There is this policy in place that handles it:
> https://infra.apache.org/github-actions-policy.html
>
> It was announced a few months ago and several project
There is this policy in place that handles it:
https://infra.apache.org/github-actions-policy.html
It was announced a few months ago and several projects that saw that
"approve all" policy as unsustainable for their community got the policy
changed.
Example ticket from Airflow:
https://issues.apa
I remember it's an apache org-wise configuration. cc users@infra.a.o.
For now, non-committers can use personal CI tech like[1] to unblock CI
verifications. And if anyone continues contributing and meets trouble with
this inconvenience, I suggest we should nominate the contributor as
committer to h
Hi, all.
For now, non-committer PRs for Go clients do not run CI automatically and
require to committer approval every time.
Can we modify this rule? Only first-time contributors need committer
approval.
Who has permission to modify it?
Thanks,
Baodi Shi
Hi mingze,
Good catch.
I think we should apply this fix to the released versions,
since this PIP is kind of protocol change and only applies to new version.
Thanks,
Haiting
On 2023/06/29 06:07:18 韩明泽 wrote:
> If do not upgrade the version, you can add the following parameters in
> client to solv
20 matches
Mail list logo
