Publick Stable class SchemaInfoImpl breaks

2023-05-05 Thread tison
PR-16380 adds a new field timestamp. With Lombok config auto-generate, it causes the constructor signature to change [2]. Fortunately, we generate a builder class also, and that way remain in compatible. But I'd like to raise this issue that lombok annotation can break interfaces silently, so it

Re: [VOTE] Pulsar Client C++ Release 3.2.0 Candidate 2

2023-05-05 Thread Yunze Xu
There is a serious deadlock issue that I want to include the fix in this release. So I decided to cancel this vote and start another candidate once it's fixed. References: - https://github.com/apache/pulsar-client-cpp/issues/265 - https://github.com/apache/pulsar-client-python/issues/116 Thanks,

Re: [DISCUSS] Retry topic should not create for a retry topic

2023-05-05 Thread Yubiao Feng
Hi Asaf Sorry, I forgot to reply to this message. I submitted a PIP to solve it: Discussion: *https://lists.apache.org/thread/tp25lom2ggztljlo76krsldo270f293j * Issue: https://github.com/apache/pulsar/issues/20033 Vote: https://lis

[VOTE] PIP-263: Just auto-create no-partitioned DLQ And Prevent auto-create a DLQ for a DLQ

2023-05-05 Thread Yubiao Feng
Hi Pulsar Community This thread is to start the vote for PIP 259. Discussion: *https://lists.apache.org/thread/tp25lom2ggztljlo76krsldo270f293j * Issue: https://github.com/apache/pulsar/issues/20033 Voting will stay open for at l

Re: [VOTE] Pulsar Manager Release 0.4.0 Candidate 2

2023-05-05 Thread Haiting Jiang
+1 binding - Verified shasum, and asc of released files. - Build from source with source package and verified basic functionality including add/delete ops on environment/tenant/ns/topic/sub. - Run pulsar-manager with binary package and verified basic functionality including add/delete ops on envir

Re: [DISCUSS] Improve Pulsar Function Source Primitive Schema Mapping

2023-05-05 Thread Rui Fu
Hi Neng, Thanks for bringing this issue up. Using JSON as the default schema and wrapping it with other primitive types are counterintuitive, and +1 to make [2] align with [1] so that both Pulsar Source and Pulsar Sink will make correct support with other primitive types. And as per the code [

[VOTE] Pulsar Manager Release 0.4.0 Candidate 2

2023-05-05 Thread tison
Hi everyone, Please review and vote on the release candidate #1 for the version 0.4.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * Release notes https://git

Re: [Discuss] Should current `ServiceConfiguration` file split by category ?

2023-05-05 Thread Yunze Xu
Oh, I figured out the reason finally. It's caused by the lombok. After I changed all getters and setters with the trivial getters and setters, the completion time was reduced from 15 seconds to 2 seconds. Thanks, Yunze On Fri, May 5, 2023 at 4:30 PM Yunze Xu wrote: > > I think the configuration

Re: [VOTE] Pulsar Client C++ Release 3.2.0 Candidate 2

2023-05-05 Thread Baodi Shi
+1(non-binding) Verify: - SHA512 for source code. - Compilation on MacOS M1(13.2.1) - Run SampleProducer and SampleConsumer Thanks, Baodi Shi On May 5, 2023 at 15:27:44, Yunze Xu wrote: > This is the second release candidate for Apache Pulsar Client C++, > version 3.2.0. > > It f

Re: [Discuss] Should current `ServiceConfiguration` file split by category ?

2023-05-05 Thread Yunze Xu
I think the configuration pojo is the issue. There are hundreds of getters and setters. I did an experiment in my local env. First, copy `ServiceConfiguration` to another class named `PulsarServiceConfiguration`. Then write the following code ```java PulsarServiceConfiguration conf = new PulsarSer

[CANCEL][VOTE] Pulsar Manager Release 0.4.0 Candidate 1

2023-05-05 Thread tison
Let's improve the quality at the very least level and fix the folder name issue. Best, tison. tison 于2023年5月5日周五 15:41写道: > Thanks for your verification and feedback! > > That said, we need to improve the quality of this software to conclude a > new version. > > Given that we're not in a hurry

Re: [VOTE] Pulsar Manager Release 0.4.0 Candidate 1

2023-05-05 Thread tison
Thanks for your verification and feedback! That said, we need to improve the quality of this software to conclude a new version. Given that we're not in a hurry, I'm going to close this RC and make related changes to improve both the release process and user experience. Best, tison. Yunze Xu

[VOTE] Pulsar Client C++ Release 3.2.0 Candidate 2

2023-05-05 Thread Yunze Xu
This is the second release candidate for Apache Pulsar Client C++, version 3.2.0. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/milestone/3?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we ar

Re: [VOTE] Pulsar Manager Release 0.4.0 Candidate 1

2023-05-05 Thread Yunze Xu
When I verified it, I tried to create a super-user by following the guide here [1] but it failed. ```bash CSRF_TOKEN=$(curl http://localhost:7750/pulsar-manager/csrf-token) curl -H "X-XSRF-TOKEN: $CSRF_TOKEN" \ -H "Cookie: XSRF-TOKEN=$CSRF_TOKEN;" \ -H 'Content-Type: application/json' \ -X P