Re: [Discuss] Should current `ServiceConfiguration` file split by category ?

2023-04-30 Thread Asaf Mesika
The Config file size is the issue or the configuration pojo ? On Sun, 30 Apr 2023 at 19:51 lifepuzzlefun wrote: > current file is 3470 line with all pulsar configuration. > it is slow in my local ide. > > > 59 config in loadbalancer. > 17 config in metric. > 64 config in policies. > 41 config fo

Making Pulsar JIRA read only

2023-04-30 Thread Asaf Mesika
Hi, I understand JIRA was used from incubation for issue tracking and at some point GitHub was also used. Since GitHub is mostly used, how about we make JIRA read only ? We can close all tickets there and then RO. (Thanks Dave for background info on this). Asaf

[Discuss] Should current `ServiceConfiguration` file split by category ?

2023-04-30 Thread lifepuzzlefun
current file is 3470 line with all pulsar configuration. it is slow in my local ide. 59 config in loadbalancer. 17 config in metric. 64 config in policies. 41 config for bk client. 50 for managed ledger. 100+ for all other server cofig. if split by category maybe more clear class ServiceConfi

Re: [jira] [Updated] (PULSAR-24) ProducerConfigurationData & ConsumerConfigurationData is not documented with @ApiModelProperty

2023-04-30 Thread Dave Fisher
We do from the start of Incubation. We should make it read only after a quick discussion. Sent from my iPhone > On Apr 30, 2023, at 6:07 AM, Asaf Mesika wrote: > > We have JIRA for Pulsar? > >> On Wed, Apr 26, 2023 at 3:26 PM Adrian Tarau (Jira) wrote: >> >> >> [ >> https://issues.apa

Re: [DISCUSS] Is PIP required for small changes in metrics

2023-04-30 Thread Asaf Mesika
I second everything Yunze said. Just glance over the amount of configuration Pulsar has - it's almost a book. Configuration and metrics are basically the public facing side of Pulsar. We want Pulsar to be easy to use , for it to be an awesome developer experience. It starts by making sure we disc

Re: [jira] [Updated] (PULSAR-24) ProducerConfigurationData & ConsumerConfigurationData is not documented with @ApiModelProperty

2023-04-30 Thread Asaf Mesika
We have JIRA for Pulsar? On Wed, Apr 26, 2023 at 3:26 PM Adrian Tarau (Jira) wrote: > > [ > https://issues.apache.org/jira/browse/PULSAR-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Adrian Tarau updated PULSAR-24: > --- > Descr

Re: [DISCUSS] Always allow non-persistent topics auto creation

2023-04-30 Thread Asaf Mesika
Sounds reasonable to me, although I never used it :) On Thu, Apr 20, 2023 at 11:58 AM Nicolò Boschi wrote: > Hello community, > > I'd like to discuss the current behaviour for the auto creation of non > persistent topics. > Currently, the broker flag "allowAutoTopicCreation" (can be overridden

Re: [DISCUSS] Add checklist for PMC binding vote of PIP

2023-04-30 Thread Asaf Mesika
Is it ok if we use the following vote template? Per comments above, it will be optional, yet recommended. +1 (binding) [v] PIP has all sections detailed in the PIP template (Background, motivation, etc.) [v] A person having basic Pulsar user knowledge, can read the PIP and fully understand it [v]

Re: [DISCUSS] Sorting out pulsar's internal thread pools

2023-04-30 Thread Asaf Mesika
I would check with the veterans like Matteo to see what was the initial reasoning behind sharing threads with the BK client. On Tue, Apr 18, 2023 at 1:59 PM Cong Zhao wrote: > I think this is a good idea for the reasonable use of pulsar threads. > > Thanks, > Cong Zhao > > On 2023/04/18 02:07:5

Re: [DISCUSS] Change PIP template

2023-04-30 Thread Asaf Mesika
Great news: the PR containing the new template of the PIP has been merged. All voters - please check to see the template is used. The most important bit in the template is its header - please mind that when reviewing PIPs. I'm quoting it here: RULES > * Never place a link to an external site lik

[DISCUSS] PIP-265: PR-based system for managing and reviewing PIPs

2023-04-30 Thread Asaf Mesika
Hi, I've summarized all comments from https://lists.apache.org/thread/5kpddlfh5xdbsjmv47ymnk3z6wd92jbh into a PIP. PIP: https://github.com/apache/pulsar/issues/20207 I'm leaving this discussion open for 2-3 days to make sure I haven't missed a comm

Re: [DISCUSS] We must change the way we review PIPs

2023-04-30 Thread Asaf Mesika
I've converted all correspondence here into PIP: https://github.com/apache/pulsar/issues/20207 Also opened a new email thread on it. On Mon, Apr 3, 2023 at 12:46 PM Asaf Mesika wrote: > One issue will be PIP numbering. If we only merge accepted PIPs, but >> all PIPs get numbers, we'll have holes