Re: [DISCUSS] Sorting out pulsar's internal thread pools

2023-04-17 Thread Xiangying Meng
Thank you for bringing up this important topic. I completely agree with this initiative. This would be a great starting point for revisiting and improving the Pulsar codebase. Thanks, Xiangying On Tue, Apr 18, 2023 at 2:18 PM Lin Lin wrote: > This is a good idea. > > Thanks, > Lin Lin > > On 20

Re: [DISCUSS] Sorting out pulsar's internal thread pools

2023-04-17 Thread Lin Lin
This is a good idea. Thanks, Lin Lin On 2023/04/18 02:07:55 mattisonc...@gmail.com wrote: > > Hello, folks. > > I would like to start discussing the pulsar internal thread pool sorting out. > > How did I get this idea? > > Recently, we met some problems with the BK operation timeout. After

Re: [DISCUSS] Add checklist for PMC binding vote of PIP

2023-04-17 Thread Yunze Xu
Basically I think describing how much work the reviewer did to give his +1 is good. Just like the vote for a release, each +1 follows with the verifications he did, e.g. here [1] is a vote for Pulsar 2.11.1 candidate 1: > • Built from the source package (maven 3.8.6 OpenJDK 17.0) > • Ran binary pa

Re: [DISCUSS] Sorting out pulsar's internal thread pools

2023-04-17 Thread Yunze Xu
I agree with this improvement. I had the same idea before but it would take too much time so I didn't continue at that time. Thanks, Yunze On Tue, Apr 18, 2023 at 10:08 AM wrote: > > > Hello, folks. > > I would like to start discussing the pulsar internal thread pool sorting out. > > How did I g

Re: [DISCUSS] forbid user to upload `BYTES` schema

2023-04-17 Thread PengHui Li
I have pushed out a PR to revert this change first. https://github.com/apache/pulsar/pull/20123 Please help review. Thanks, Penghui On Tue, Apr 18, 2023 at 11:36 AM PengHui Li wrote: > > Flink uses the schema to store some kv based properties. If we can > expose all the operations of the topi

Re: [DISCUSS] forbid user to upload `BYTES` schema

2023-04-17 Thread PengHui Li
> Flink uses the schema to store some kv based properties. If we can expose all the operations of the topic level metadata store. We can truly drop the use of uploading the BYTES schema in the Flink connector. After 3.0.0, Pulsar will provide the ability to set properties for a topic https://githu

Re: [VOTE] Pulsar Release 2.11.1 Candidate-2

2023-04-17 Thread PengHui Li
Ah, yes, it works after setting `PULSAR_STANDALONE_USE_ZOOKEEPER=1` We need to push a PR to fix the validation document. +1 (binding) Thanks, Penghui On Mon, Apr 17, 2023 at 11:14 PM Haiting Jiang wrote: > Hi Penghui > > Did you set `PULSAR_STANDALONE_USE_ZOOKEEPER=1` when verifying > Stateful

Re: [VOTE] Pulsar Release 2.10.4 Candidate 4

2023-04-17 Thread guo jiwei
+1 (binding) - Check the signature - Build from the source package - Start the standalone - Validate Pub/Sub and Java Functions - Validate Stateful Functions Regards Jiwei Guo (Tboy) On Mon, Apr 17, 2023 at 8:52 PM PengHui Li wrote: > > +1 (binding) > > - Checked the signature > - Build from th

[DISCUSS] Sorting out pulsar's internal thread pools

2023-04-17 Thread mattisonchao
Hello, folks. I would like to start discussing the pulsar internal thread pool sorting out. How did I get this idea? Recently, we met some problems with the BK operation timeout. After investigating, we found an issue that is we share the IO executor(workgroup) with the Bookkeeper client and

Re: [DISCUSS] forbid user to upload `BYTES` schema

2023-04-17 Thread Yufan Sheng
>I support reverting the PR first and then looking for a long-term solution. Flink uses the schema to store some kv based properties. If we can expose all the operations of the topic level metadata store. We can truly drop the use of uploading the BYTES schema in the Flink connector. On Mon, Apr

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 4

2023-04-17 Thread Yuto Furuta
+1 (non-binding) * verify checksum and signatures * build the source * run producer, consumer, consumer_listener (source/npm) Regards, Yuto Furuta 差出人: Baodi Shi 送信日時: 2023年4月14日 18:12 宛先: dev@pulsar.apache.org 件名: [VOTE] Pulsar Node.js Client Release 1.8.2 Can

RE: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 4

2023-04-17 Thread Masahiro Sakamoto
+1 (binding) - verified checksum and signature - confirmed that the build was successful - ran produce/consume Regards, Masahiro Sakamoto Yahoo Japan Corp. E-mail: massa...@yahoo-corp.jp -Original Message- From: Baodi Shi Sent: Friday, April 14, 2023 6:12 PM To: dev@pulsar.apache.org S

Re: [VOTE] Pulsar Release 2.11.1 Candidate-2

2023-04-17 Thread Haiting Jiang
Hi Penghui Did you set `PULSAR_STANDALONE_USE_ZOOKEEPER=1` when verifying Stateful Functions ? Thanks, Haiting On Mon, Apr 17, 2023 at 7:48 PM PengHui Li wrote: > > The RC version failed to verify the state function > > The output: > > ``` > ~/Downloads/release_2.11.1/apache-pulsar-2.11.1 » bin

Re: [VOTE] Pulsar Release 2.9.5 Candidate 3

2023-04-17 Thread PengHui Li
+1 (binding) - Checked the signature - Build from the source package - Start standalone - Checked cassandra connector - Checked state function Regards, Penghui On Sat, Apr 15, 2023 at 6:08 PM wrote: > +1 (Binding) > > • Built from the source package (maven 3.8.6 OpenJDK 11.0) > • Ran binary

Re: [VOTE] Pulsar Release 2.10.4 Candidate 4

2023-04-17 Thread PengHui Li
+1 (binding) - Checked the signature - Build from the source package - Start standalone - Checked cassandra connector - Checked state function Regards, Penghui On Sat, Apr 15, 2023 at 5:37 PM wrote: > +1 (Binding) > > • Built from the source package (maven 3.8.6 OpenJDK 11) > • Ran binary pa

Re: [VOTE] Pulsar Release 2.11.1 Candidate-2

2023-04-17 Thread PengHui Li
The RC version failed to verify the state function The output: ``` ~/Downloads/release_2.11.1/apache-pulsar-2.11.1 » bin/pulsar-admin functions status --tenant test --namespace test-namespace --name word_count { "numInstances" : 1, "numRunning" : 1, "instances" : [ { "instanceId" : 0,

Re: [Discuss] Suggestion for a "clear" parameter in Pulsar-admin to simplify tenant and namespace cleanup

2023-04-17 Thread Xiangying Meng
Hi Penghui, I appreciate your feedback and completely agree with your concern about the learning curve for Pulsar users. Introducing additional keywords could potentially increase the complexity for users who need to understand the new terms. Therefore, I accept your suggestion to use delete-all-n

Re: [DISCUSS] Add checklist for PMC binding vote of PIP

2023-04-17 Thread PengHui Li
I don't think it will bring more burden on reviewers. It will only provide a checklist for reviewers before you vote +1 or -1. It could be done in 1 minute if you did a great proposal review. Of course, if you are missing some aspects that should be reviewed, This will make the reviewer spend more

Re: [Discuss] Suggestion for a "clear" parameter in Pulsar-admin to simplify tenant and namespace cleanup

2023-04-17 Thread PengHui Li
The new operation will delete all the data and the metadata under a tenant or namespace. I would like to suggest to use `delete-all-namespaces` and `delete-all-topics` The `delete` actually acts as a fact of deleting metadata and data. And `truncate` is for deleting the data. IMO, we'd better not