[pulsar-adapters] Moving Storm adapter to Apache Storm's repo.

2023-03-24 Thread Andrey Yegorov
Hi, It's been awhile since we talked about this in the community meeting but finally this happened. Apache Storm community accepted Pulsar Storm & Spout from pulsar-adapters project https://github.com/apache/storm/tree/master/external/storm-pulsar and I expect this code to get more visibility and

Re: [DISCUSS] PIP-258: Deprecation of the consumer subscribeTopicMode configuration

2023-03-24 Thread Yunze Xu
I think we don't need to do such changes. Instead, we should fix the documentation of `ConsumerBuilder#topicsPattern`. From the implementation here [1], the prefix before "://" in the topic pattern should be ignored. [1] https://github.com/apache/pulsar/blob/f1f8dab972b098be69ad35ab3d307f19284c4e

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-24 Thread 丛搏
Hi, Michael: I thought about it carefully, and using 'startMessageId' is indeed a good idea. But it is more complicated, we need to ensure its absolute correctness, and take performance into consideration. If you can come up with a closed-loop solution based on 'startMessageId', I support you. If

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-24 Thread 丛搏
Hi, PengHui PengHui Li 于2023年3月24日周五 10:16写道: > > Hi Bo, > > > Only support Consumer#redeliverUnacknowledgedMessages() > > > > If we redeliver individual messages, they will be filtered. Because we > can't clear the record latest message in the consumer when redelivering > individual messages. It

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-24 Thread 丛搏
Hi, Yunze : > > > At least it will simplify the process of using cumulative ack with the > > transaction. > > So the transaction use cases assume the cursor will never be reset by > other applications? We cannot ignore the impact brought by this > proposal that resetting the cursor could have an

Re: Unstable codecov action

2023-03-24 Thread Lari Hotari
Thanks for sharing the pain. That's the first step in improving something that is painful. For the flaky tests GitHub Actions workflow pulsar-ci-flaky.yaml, the Codecov upload should be a separate job in the workflow so that the upload could be retried separately without running all tests. This

Re: [VOTE] PIP-254: Support configuring client version with a description suffix

2023-03-24 Thread Yunze Xu
Bump. Please take a look and vote for this proposal. Thanks, Yunze On Mon, Mar 20, 2023 at 3:13 PM Zike Yang wrote: > > +1 (non-binding) > > Thanks, > Zike Yang > > On Wed, Mar 15, 2023 at 3:54 PM Yunze Xu wrote: > > > > Hi all, > > > > This thread is to start the vote for PIP-254. > > > > Disc

Re: Unstable codecov action

2023-03-24 Thread Yunze Xu
The codecov is really annoying to me and never helps me during the coding or reviewing process. Just a complaint from me. I'm also curious how many developers benefit from it. Thanks, Yunze On Tue, Mar 21, 2023 at 6:50 PM tison wrote: > > For example > https://github.com/apache/pulsar/actions/r

Re: [DISCUSS] PIP-260: Client consumer filter received messages

2023-03-24 Thread Yunze Xu
> At least it will simplify the process of using cumulative ack with the > transaction. So the transaction use cases assume the cursor will never be reset by other applications? We cannot ignore the impact brought by this proposal that resetting the cursor could have an unexpected effect. If the