Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-07 Thread SiNan Liu
Hi, Asaf. 1. I guess there's no right or wrong way to code. Your implementation also uses concepts like canRead, writtenSchema, and readSchema, similar to mine. You just got rid of the builder and left the validator, though there are duplicate blocks of code, but I think I can improve on that as w

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-07 Thread SiNan Liu
Hi, bo. 1. I understand what you say, to develop a new `ProtobufNativeAdvancedSchemaCompatibilityCheck`, rather than changing existing `ProtobufNativeSchemaCompatibilityCheck`. But I found a few small problems: (1)ProtobufNativeAdvancedSchemaCompatibilityCheck and ProtobufNativeSchemaCompatibilit

Re: [DISCUSS] Using bouncycastle fips instead bouncycastle non-fips

2023-03-07 Thread Zixuan Liu
> So it means the change is only on the client side, not the broker side? pulsar-functions also depend on BC. In the Pulsar, we only use the BC or BC-FIPS, right now we are using the BC. > we could consider that in the future. current way is to align with the old manner. I talked to jia, BC is u

Re: [VOTE] Pulsar Release 2.10.4 Candidate 1

2023-03-07 Thread guo jiwei
+1 (binding) - Build from the source package - Checked the signature - Publish and consume messages - Verified Function and State Function - Verified Cassandra connector Regards Jiwei Guo (Tboy) On Tue, Mar 7, 2023 at 2:22 PM Xiangying Meng wrote: > > Please ignore the previous email. This comm

Re: [DISCUSS] PMC/Committer Emiratus status

2023-03-07 Thread P. Taylor Goetz
Thanks Dave. All the points you raised are valid. To be clear, my main point is that there’s no good reason to remove inactive contributors from Committership/PMC Membership. Period. I’ll concede that PMCs have the freedom decide on their own if and how to publish their community roster. But I

Re: [DISCUSS] PMC/Committer Emiratus status

2023-03-07 Thread Dave Fisher
Sent from my iPhone > On Mar 7, 2023, at 3:34 PM, P. Taylor Goetz wrote: > >  > >> On Mar 7, 2023, at 6:36 AM, Enrico Olivelli wrote: >> >> Websites tend to quickly become obsolete about this kind of thing, >> because really >> nobody takes care of its own "status" on a project, or that i

Re: [DISCUSS] PMC/Committer Emiratus status

2023-03-07 Thread P. Taylor Goetz
> On Mar 7, 2023, at 6:36 AM, Enrico Olivelli wrote: > > Websites tend to quickly become obsolete about this kind of thing, > because really > nobody takes care of its own "status" on a project, or that it is > "visible" on the website. > It is not for the benefit of anyone. I would beg to dif

Re: [DISCUSS] new idea: reverse reading a topic

2023-03-07 Thread Michael Marshall
> The goal is to start from a known MessageId and read the N message > before this MessageId. Have you looked at the seek implementation to see if it would be feasible to extend the implementation and add a method to "seekBefore" a message id in the way you described? I haven't considered all of t

Re: [DISCUSS] PIP-253: Expose producer metrics for deadLetterProducer and retryLetterProducer

2023-03-07 Thread Kai Levy
Yes, that would work. Kai On Tue, Mar 7, 2023 at 12:41 AM Asaf Mesika wrote: > On Mon, Mar 6, 2023 at 6:24 PM Kai Levy wrote: > > > I agree, adding it to the ConsumerStats interface makes more logical > sense, > > but I believe the implementation will be harder that way, since the > > producer

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-07 Thread 丛搏
SiNan Liu 于2023年3月7日周二 13:22写道: > > Great to see your comment, bo! > > 1. The first way. The protobuf website has a description of the rules, but > no plans to implement them. > https://protobuf.dev/programming-guides/proto/#updating https://groups.google.com/g/protobuf maybe ask here > > 2. I t

Re: [DISCUSS] PIP-249: Pulsar website redesign

2023-03-07 Thread Asaf Mesika
On Wed, Mar 1, 2023 at 3:14 AM tison wrote: > Hi Asaf, > > Here are my two coins: > > 1. Big +1 on the proposed change to a neutral background. The blue > background makes color coordination quite difficult. > 2. Since we already stick the top menu on scrolling, perhaps we don't have > to change

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-07 Thread Asaf Mesika
On Tue, Mar 7, 2023 at 1:01 PM SiNan Liu wrote: > > > > Ok. > > First, the name is confusing. Flags are normally true/false, in your case > > it's a string, so the name should be a Configuration property. > > Second, I agree - you're basically saying we must allow users to keep > > existing imple

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-03-07 Thread Asaf Mesika
Thanks for the modifications. Looking much better! In the LedgerDeletionService start, it will create a producer for sending > pending delete ledger. When deleting a ledger, the producer sends > PendingDeleteLedgerInfo to the system-topic. If the sent succeeds, delete > the ledger id from the whol

Re: [DISCUSS] new idea: reverse reading a topic

2023-03-07 Thread Alexandre DUVAL
Hi Yong, The goal is to start from a known MessageId and read the N message before this MessageId. Best, Kannar On 3/7/23 01:53, Yong Zhang wrote: Hi Kannar, Just interested in what exactly your case. Why do you need to read messages in a reversed order? What is your case? Best, Yong O

Re: [DISCUSS] PMC/Committer Emiratus status

2023-03-07 Thread Enrico Olivelli
Il giorno lun 6 mar 2023 alle ore 23:12 Asaf Mesika ha scritto: > > Tison, > > The suggestion was stated a bit differently: > > Quote: > > Rather, I would recommend a project-level “active/inactive” flag that PMC > members can voluntarily apply to themselves. For example, do a PMC roll > call on p

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-07 Thread SiNan Liu
> > Ok. > First, the name is confusing. Flags are normally true/false, in your case > it's a string, so the name should be a Configuration property. > Second, I agree - you're basically saying we must allow users to keep > existing implementation, or switch to new implementation. Just using a > boo

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-07 Thread Asaf Mesika
On Tue, Mar 7, 2023 at 6:51 AM SiNan Liu wrote: > Thanks for the advice, Asaf. > > 1. > > > For now, there is no official or third-party solution for ProtoBuf > > compatibility. If in the future have better solutions of a third party or > > the official, we develop new ProtobufNativeSchemaValidat

Re: [VOTE] Apache Pulsar Adapters Release 2.11.0 Candidate 3

2023-03-07 Thread Enrico Olivelli
Nice work Christophe, thanks for driving this release +1 (binding) - verified checksums/signatures - built on Mac (M1) on JDK17, all tests passing We need more VOTES :-) Enrico Il giorno gio 2 mar 2023 alle ore 18:48 Christophe Bornet ha scritto: > > This is the release candidate 3 for Apache

Re: [DISCUSS] PIP-253: Expose producer metrics for deadLetterProducer and retryLetterProducer

2023-03-07 Thread Asaf Mesika
On Mon, Mar 6, 2023 at 6:24 PM Kai Levy wrote: > I agree, adding it to the ConsumerStats interface makes more logical sense, > but I believe the implementation will be harder that way, since the > producers are lazily initialized. They won't be available when > ConsumerStats is created, and there