Re: [VOTE] PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2022-12-20 Thread 丛搏
Hi Yunze, add `TopicMessageId ` will couple messageID and `topic name` together, which is very unclear for non-partition-topic. ``` void seek(String topicName, MessageId messageId) throws PulsarClientException; List> getLastTopicMessageId() throws PulsarClientException; ``` If the interface is de

Re: [DISCUSS] PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2022-12-20 Thread 丛搏
Hi Yunze, add `TopicMessageId ` will couple messageID and `topic name` together, which is very unclear for non-partition-topic. ``` void seek(String topicName, MessageId messageId) throws PulsarClientException; List> getLastTopicMessageId() throws PulsarClientException; ``` If the interface is de

Re: [DISCUSS] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-20 Thread 丛搏
Hi, Yunze > This interface is introduced mainly because we > don't have a String parameter in seek and acknowledge before. It's a > tradeoff between compatibility and complexity. I think `MessageIdAdv` and adding `topic name` is more confusing for non-partition-topic and redundant. If we don't c

Re: [DISCUSS] Introduce oshi library to sensory OS resources

2022-12-20 Thread Yubiao Feng
+1 On Mon, Dec 19, 2022 at 6:19 PM wrote: > > Hi, All > > I would like to introduce a new library oshi[1] to help Apache Pulsar > sensory OS resources. It can help us to get away from the complex file > manipulation and cross-platform compatibility issues in some operating > systems. > > code ex

Re: [DISCUSS] Introduce oshi library to sensory OS resources

2022-12-20 Thread 丛搏
+1 (non-binding) Thanks, Bo PengHui Li 于2022年12月21日周三 11:48写道: > > +1 > > Thanks, > Penghui > > On Mon, Dec 19, 2022 at 6:19 PM wrote: > > > > > Hi, All > > > > I would like to introduce a new library oshi[1] to help Apache Pulsar > > sensory OS resources. It can help us to get away from the co

Re: [DISCUSS] Introduce oshi library to sensory OS resources

2022-12-20 Thread PengHui Li
+1 Thanks, Penghui On Mon, Dec 19, 2022 at 6:19 PM wrote: > > Hi, All > > I would like to introduce a new library oshi[1] to help Apache Pulsar > sensory OS resources. It can help us to get away from the complex file > manipulation and cross-platform compatibility issues in some operating > sys

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-20 Thread tison
Thanks for your feedback! @Yu Thanks for sharing the previous thread. I looped in @michaeljmarshall here. @Jun It's possible but causes a new shortcoming: Now you should tell the contributor that the versioned docs are different from the NEXT version docs, lol. If our developers don't complain

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-20 Thread Jun Ma
Is it possible to come up with a compromised solution that has the pros of both sides but minimizes the side effect? I'm thinking maybe it's not necessary to sacrifice the current contribution process, as long as it can greatly reduce the load of back-end actions and source size. For example, if

Re: [DISCUSS] Change the default IO threads and listener threads of Java Client

2022-12-20 Thread 丛搏
+1 Our default configuration is best for most users. Multiple clients are a few cases. Thanks, Bo houxiaoyu 于2022年12月20日周二 16:02写道: > > +1 > > This change might bring thread number increment in case users create many > clients, but too many pulsar clients run in one machine is not a good use > c

Re: [VOTE] PIP-228: Refactor the information architecture of Pulsar client docs

2022-12-20 Thread 丛搏
+1 (non-binding) Thanks, Bo Yu 于2022年12月21日周三 09:51写道: > > +1 > > On Tue, Dec 20, 2022 at 3:12 PM Yunze Xu > wrote: > > > +1 (non-binding) > > > > Thanks, > > Yunze > > > > On Tue, Dec 20, 2022 at 3:06 PM Zike Yang wrote: > > > > > > +1 (non-binding) > > > > > > Thanks, > > > Zike Yang > > > >

Re: [VOTE] PIP-228: Refactor the information architecture of Pulsar client docs

2022-12-20 Thread Yu
+1 On Tue, Dec 20, 2022 at 3:12 PM Yunze Xu wrote: > +1 (non-binding) > > Thanks, > Yunze > > On Tue, Dec 20, 2022 at 3:06 PM Zike Yang wrote: > > > > +1 (non-binding) > > > > Thanks, > > Zike Yang > > > > On Tue, Dec 13, 2022 at 4:38 PM Jun Ma wrote: > > > > > > Hi all, > > > > > > I'm going

Re: [ANNOUNCE] Released Spring for Apache Pulsar, version 0.1.0

2022-12-20 Thread Christophe Bornet
That's awesome Chris, Many thanks to VMWare and all the contributors. This is a really great addition to the Apache Pulsar eco-system ! Christophe Le mar. 20 déc. 2022 à 18:09, Chris Bo a écrit : > The Spring for Apache Pulsar team is proud to announce the initial GA minor > release of the fra

[ANNOUNCE] Released Spring for Apache Pulsar, version 0.1.0

2022-12-20 Thread Chris Bo
The Spring for Apache Pulsar team is proud to announce the initial GA minor release of the framework. The project aims to provide Spring-friendly APIs, building blocks, and programming models for writing Java applications that interact with Apache Pulsar. More details can be found here: https://s

Re: [PROPOSAL] Website precommit and move the source of docs to the site repo

2022-12-20 Thread Jiaqi Shen
+1, it makes sense to me. Thanks, Jiaqi Shen Yu 于2022年12月19日周一 20:57写道: > Hi tison, > > Thanks for raising this up! > > Our community had a similar discussion previously and chose to "keep" the > doc repo stay in the Pulsar main repo at that time. > > [1] lists the pros and cons of "keep" and

Re: [DISCUSS] Change the default IO threads and listener threads of Java Client

2022-12-20 Thread houxiaoyu
+1 This change might bring thread number increment in case users create many clients, but too many pulsar clients run in one machine is not a good use case I think, so this change looks good to me. Thanks, Xiaoyu Hou 于2022年12月20日周二 12:25写道: > +1 > > My concern is whether this change will affe