Re: [DISCUSS] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-17 Thread 丛搏
< For a single-topic consumer, wrapping the topic name is < redundant and might break the existing behavior. In this case, if < `PulsarApiMessageId` extends `TopicMessageId`, the `getTopicName()` < method should return null, which is not a good design [1][2]. For `TopicMessageIdImpl`, it is an ori

Re: [DISCUSS] PIP-229: Add a common interface to get fields of MessageIdData

2022-12-17 Thread Yunze Xu
Hi Bo, Because the topic name is not a part of MessageIdData. It's only used to find the correct internal consumer of a multi-topics consumer. > All I can think of is PulsarApiMessageId extend TopicMessageId(PIP-224[1]) > right? No. The `TopicMessageId` could only be used in a multi-topics cons

Re: [DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-17 Thread 丛搏
> Is it time to require a proposal for Admin API/CLI and metrics changes? yes, need a proposal for Admin API/CLI and metrics changes. but It is difficult for us to judge whether a PR is a bug fix or needs PIP or doc/required through automatic detection. We can standardize the committer review proc