[GitHub] [pulsar] Jason918 added a comment to the discussion: How to avoid repeated consumption in Durable subscription?

2022-10-23 Thread GitBox
GitHub user Jason918 added a comment to the discussion: How to avoid repeated consumption in Durable subscription? > Every time, it is successfully ACKed (is the ACK status information saved > locally?) Not likely, client `ack` need RPC to be persisted to broker. > After restarting the Pul

Re: [VOTE] Pulsar Client C++ Release 3.0.0 Candidate 3

2022-10-23 Thread Kai Wang
+1 (non-binding) Environment: M1 macOS 12.6 and Ubuntu 20.04 x86_64 * verify checksum and signatures * build from the source * run producers and consumers But when I follow `README.md` guide to starting the standalone broker, I get an error. ``` ➜ apache-pulsar-client-cpp-3.0.0 ./pulsar-test-

[GitHub] [pulsar] philixtian edited a discussion: When I set-retention for a partitioned topic by admin cli, whether it will take effect in every partitions ?

2022-10-23 Thread GitBox
GitHub user philixtian edited a discussion: When I set-retention for a partitioned topic by admin cli, whether it will take effect in every partitions ? As the title says, will all partitions get the same retention polices? GitHub link: https://github.com/apache/pulsar/discussions/18168

Re: [DISCUSS] Use SLASHSTAR_STYLE for Java files

2022-10-23 Thread Zike Yang
+1 Thanks, Zike Yang On Mon, Oct 24, 2022 at 1:25 PM Yunze Xu wrote: > > +1 for me. > > Thanks, > Yunze > > On Fri, Oct 21, 2022 at 9:45 AM tison wrote: > > > > Hi, > > > > Here is the pull request: https://github.com/apache/pulsar/pull/17508 > > > > Motivation: > > > > When reformatting Java f

Re: [DISCUSS] Use SLASHSTAR_STYLE for Java files

2022-10-23 Thread Yunze Xu
+1 for me. Thanks, Yunze On Fri, Oct 21, 2022 at 9:45 AM tison wrote: > > Hi, > > Here is the pull request: https://github.com/apache/pulsar/pull/17508 > > Motivation: > > When reformatting Java files, JAVADOC_STYLE cause the license header be > treated as doc comments and it will be affected fr

Re: [VOTE] Pulsar Client C++ Release 3.0.0 Candidate 3

2022-10-23 Thread Zike Yang
+1 (non-binding) * verify checksum and signatures * build from the source * run producers and consumers Thanks, Zike Yang On Sat, Oct 22, 2022 at 5:30 AM Matteo Merli wrote: > > This is the third release candidate for Apache Pulsar Client C++, version > 3.0.0. > > It fixes the following issues

Re: [DISCUSS] PIP-215: Configurable Topic Compaction Strategy

2022-10-23 Thread PengHui Li
Sorry, heesung, I think I used a confusing name "leader election". Actually, I meant to say "topic owner". >From my understanding, the issue is if we are using the table view for a compacted topic. We will always get the last value of a key. But it will not work for the "broker ownership conflict

Re: [PIP-214][broker]Add broker level metrics statistics and expose to prometheus discussion

2022-10-23 Thread PengHui Li
I support the motivation. When I read the document of Prometheus I see "A label with an empty label value is considered equivalent to a label that does not exist." [0] Can we just keep the value of the topic and namespace label empty? And here is a blog that introduced how to deal with the empty l

Re: [VOTE] PIP-212: Default reppDnsResolverClass to ZkBookieRackAffinityMapping

2022-10-23 Thread Zike Yang
+1 (non-binding) Thanks, Zike Yang On Mon, Oct 24, 2022 at 9:37 AM PengHui Li wrote: > > +1 (binding) > > Thanks, > Penghui > > On Sat, Oct 22, 2022 at 4:03 AM Dave Fisher wrote: > > > +1 (binding) > > > > > On Oct 20, 2022, at 11:06 PM, Michael Marshall > > wrote: > > > > > > Bump. In my opin

Re: [VOTE] PIP-212: Default reppDnsResolverClass to ZkBookieRackAffinityMapping

2022-10-23 Thread PengHui Li
+1 (binding) Thanks, Penghui On Sat, Oct 22, 2022 at 4:03 AM Dave Fisher wrote: > +1 (binding) > > > On Oct 20, 2022, at 11:06 PM, Michael Marshall > wrote: > > > > Bump. In my opinion, this is a bug that we need to fix before any new > > releases. It is only a PIP because fixing the bug requi

Re: [DISCUSS] Remove timestamp from Prometheus metrics

2022-10-23 Thread Asaf Mesika
Great addition! It also reduces the Prometheus response size. On Wed, Sep 7, 2022 at 7:47 AM Michael Marshall wrote: > Merged. Depending on whether [0] will be cherry picked to release > branches, I will cherry pick [1] or [2] to all active release > branches. > > Thanks, > Michael > > [0] https

[GitHub] [pulsar] startjava added a comment to the discussion: Who does Reader's represent in NonDurable documents?

2022-10-23 Thread GitBox
GitHub user startjava added a comment to the discussion: Who does Reader's represent in NonDurable documents? i know "Reader" represent Reader.java thank you! GitHub link: https://github.com/apache/pulsar/discussions/18161#discussioncomment-3943177 This is an automatically sent email

Re: [PIP-214][broker]Add broker level metrics statistics and expose to prometheus discussion

2022-10-23 Thread Asaf Mesika
One thing to note: You mentioned a PIP number but I'm not sure this is the right process you follow here for that. On Sun, Oct 23, 2022 at 1:12 PM Asaf Mesika wrote: > The suggestion makes sense to me as well. I've also reviewed your PR. > > On Sun, Oct 23, 2022 at 8:43 AM Haiting Jiang > wrot

Re: [PIP-214][broker]Add broker level metrics statistics and expose to prometheus discussion

2022-10-23 Thread Asaf Mesika
The suggestion makes sense to me as well. I've also reviewed your PR. On Sun, Oct 23, 2022 at 8:43 AM Haiting Jiang wrote: > +1 > Makes sense to me. > > Thanks, > Haiting > > On Sat, Oct 22, 2022 at 3:59 AM yang yijun wrote: > > > > Hi,I have a suggestion to improve the broker. > > > > For deta

Re: [DISCUSS] Pulsar Metrics - Current State and Future Directions

2022-10-23 Thread Asaf Mesika
Thanks, Michael for taking the time to read it. I've added your suggestion to the bottom of the document and I will use them when the time comes to create several PIPs for this. Any other feedback on this from the community would be greatly appreciated! On Fri, Oct 14, 2022 at 7:23 AM Michael Ma