Re: Enable "Update branch" Github button in pull requests

2022-08-17 Thread Nicolò Boschi
Any comments? Nicolò Boschi Il giorno mar 12 lug 2022 alle ore 18:06 Nicolò Boschi ha scritto: > Hi all, > > I'd like to propose to enable the Github button "update branch" in the > pull requests. > > The main reason is that it helps when you want to rebase your pull to the > current master. >

[GitHub] [pulsar-test-infra] tisonkun commented on issue #58: Use Docker container action for docbot

2022-08-17 Thread GitBox
tisonkun commented on issue #58: URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1219054222 Download an image with 12.9MB may be faster than setting up go environment. We can give it a try. -- This is an automated message from the Apache Git Service. To respond to

Re: [DISCUSS] Message redeliveryCount semantics and DLQ

2022-08-17 Thread PengHui Li
Hi Michael, I agree with cherry-picking to release branches. And should be highlighted in the release note. Thanks, Penghui On Thu, Aug 18, 2022 at 12:14 PM Michael Marshall wrote: > The delivery semantics are a very succinct way to describe my concerns, > thanks for your comment Penghui. > >

Re: [DISCUSS] Message redeliveryCount semantics and DLQ

2022-08-17 Thread Michael Marshall
The delivery semantics are a very succinct way to describe my concerns, thanks for your comment Penghui. My only other question is whether we classify the behavior change as a regression that should be fixed in existing releases or if it should only be reverted for 2.12 and beyond. I propose it sh

[GitHub] [pulsar-site] Sherlock113 opened a new pull request, #168: Add a blog to the website

2022-08-17 Thread GitBox
Sherlock113 opened a new pull request, #168: URL: https://github.com/apache/pulsar-site/pull/168 Add a blog to the Pulsar website. Two engineers from Tencent contributed it to the community. It talks about optimization and troubleshooting tips for manging large Pulsar clusters. Previ

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-17 Thread Zixuan Liu
Thank yu for your work! Overall looks good to me, but I would like to request changes. I prefer: - dep (abbr for dependency) -> deps - fcn (abbr for function) -> func - sec (abbr for security) -> security - ts (abbr for tiered storage) -> tiered-storage - txn (abbr for transaction) - rest (change

Re: [DISCUSS] Pulsar 3.0 brainstorming: Going beyond PIP-45 Pluggable metadata interface

2022-08-17 Thread mattison chao
Hi, Lari Thanks for you start this discussion. 1) Metadata consistency from user's point of view > - Summarized well in this great analysis and comment [1] by Zac Bentley >"Ideally, the resolution of all of these issues would be the same: a > management API operation--any operation--should n

Re: [DISCUSS] Add an auth data const for refresh the original auth data

2022-08-17 Thread Zixuan Liu
A little confusing here is that both ProxyClient and DirectProxyHandler pass original authentication and direct authentication data, but the broker can only check if the original authentication data is expired. This is the expected behavior, right? What if the direct authentication data is expired?

Re: [DISCUSS] Add an auth data const for refresh the original auth data

2022-08-17 Thread Zixuan Liu
> So the problem is that the Proxy is not requesting a refresh ? It should be the proxy client. Zixuan Enrico Olivelli 于2022年8月17日周三 23:35写道: > So the problem is that the Proxy is not requesting a refresh ? > > Enrico > > Il giorno mer 17 ago 2022 alle ore 16:26 Zixuan Liu > ha scritto: > > >

Re: [DISCUSS] Skip unnecessary tests when there are only cpp/python related changes

2022-08-17 Thread mattison chao
I support it. +1 Best, Mattison On Tue, 16 Aug 2022 at 17:33, Enrico Olivelli wrote: > > +1 > > Enrico > > Il giorno mar 16 ago 2022 alle ore 11:32 Nicolò Boschi > ha scritto: > > > > A big +1 for this! > > > > Nicolò Boschi > > > > > > Il giorno dom 14 ago 2022 alle ore 06:20 Qiang Huang < > >

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-17 Thread Zike Yang
LGTM. > - Cherry pick changes [4] > Choice A: [fix][broker][branch-2.9] xxx > Choice B: [fix][broker] xxx. And add "cherry pick xxx to branch-2.9" in the > PR description. I prefer A. Thanks, Zike Yang Zike Yang On Wed, Aug 17, 2022 at 7:41 PM Qiang Huang wrote: > > Great work. I prefer "Choic

Re: [DISCUSS] Add an auth data const for refresh the original auth data

2022-08-17 Thread Enrico Olivelli
So the problem is that the Proxy is not requesting a refresh ? Enrico Il giorno mer 17 ago 2022 alle ore 16:26 Zixuan Liu ha scritto: > > Thank @Qiang! > > Update the diagram: > https://drive.google.com/file/d/1E6z0dzXzvW5ZxG6d6YUghL9OikA8j4UC/view?usp=sharing > > Thanks, > Zixuan > > Qiang Huan

Re: [DISCUSS] Apache Pulsar 2.11.0 Release

2022-08-17 Thread Enrico Olivelli
This test is blocking all the PRs and so it is blocking the release: Error: Tests run: 9, Failures: 2, Errors: 0, Skipped: 3, Time elapsed: 21.724 s <<< FAILURE! - in org.apache.pulsar.client.impl.MultiTopicsConsumerImplTest 3681 Error: testParallelSubscribeAsync(org.apache.pulsar.client.impl.Mult

Re: [DISCUSS] Add an auth data const for refresh the original auth data

2022-08-17 Thread Zixuan Liu
Thank @Qiang! Update the diagram: https://drive.google.com/file/d/1E6z0dzXzvW5ZxG6d6YUghL9OikA8j4UC/view?usp=sharing Thanks, Zixuan Qiang Huang 于2022年8月17日周三 19:13写道: > It makes sense to me. BTW, the image is broken. > > Zixuan Liu 于2022年8月17日周三 11:10写道: > > > Note that there are two clients,

Re: [DISCUSS] Apache Pulsar 2.11.0 Release

2022-08-17 Thread Nicolò Boschi
This is another blocker for 2.11.0 for a regression about streaming dispatch that I found in the 2.11 branch https://github.com/apache/pulsar/pull/17143 Nicolò Boschi Il giorno mer 17 ago 2022 alle ore 11:45 Enrico Olivelli < eolive...@gmail.com> ha scritto: > We have this release blocker PR th

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-17 Thread Qiang Huang
Great work. I prefer "Choice A". > Cherry pick changes [4] > Choice A: [fix][broker][branch-2.9] xxx Yunze Xu 于2022年8月17日周三 18:32写道: > LGTM. > > Thanks, > Yunze > > > > > > 2022年8月17日 11:15,Yu 写道: > > > > Hi team, > > > > For PIP 198: Standardize PR Naming Convention using GitHub Actions [1] >

Re: [DISCUSS] PIP-200 Package Pulsar Trino distro and config in a dedicated folder

2022-08-17 Thread tison
Thanks for your feedback! 1. According to the upgrade and downgrade doc, I think the minimum requirements are a release note. Describe the layout change and how users should move the folder. I'll elaborate on the issue and notify you here. 2. It seems Pulsar Helm Chart support 2.9.3 now. I'll inve

Re: [DISCUSS] PIP-200 Package Pulsar Trino distro and config in a dedicated folder

2022-08-17 Thread Qiang Huang
Looks good. I have two points: 1. It is necessary to supplement the upgrade and downgrade documentation in Pulsar. 2. There are 3 issues mentioned in the PIP, should we split it into 3 small issues? Enrico Olivelli 于2022年8月17日周三 17:30写道: > I generally agree with the PIP > > Can you please explai

Re: Spring for Apache Pulsar

2022-08-17 Thread Qiang Huang
Great. It makes the pulsar ecosystem wider and wider tison 于2022年8月17日周三 00:42写道: > Cool! I can't wait to give it a try. > > Soby Chacko 于2022年8月16日 周二22:41写道: > > > Apologies for the duplicate email. I missed adding a subject in my last > > email. > > > > Thank you. > > > > -- Forwarded

Re: [DISCUSS] Add an auth data const for refresh the original auth data

2022-08-17 Thread Qiang Huang
It makes sense to me. BTW, the image is broken. Zixuan Liu 于2022年8月17日周三 11:10写道: > Note that there are two clients, the user client, and the proxy client. > When the original authenticate data expires, the user client cannot send a > request to the proxy to find the broker URL. We haven't tests

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-17 Thread Yunze Xu
LGTM. Thanks, Yunze > 2022年8月17日 11:15,Yu 写道: > > Hi team, > > For PIP 198: Standardize PR Naming Convention using GitHub Actions [1] > > How to define [type] and [scope]? Do these abbreviations LGTY? > > *[Guide] Pulsar Pull Request Naming Convention* [2] contains everything > about the

[GitHub] [pulsar-site] Technoboy- commented on pull request #167: [Don't Merge] Pulsar 2.11.0 release notes

2022-08-17 Thread GitBox
Technoboy- commented on PR #167: URL: https://github.com/apache/pulsar-site/pull/167#issuecomment-1217781431 > @Technoboy- The following content regarding docs can be added to the 2.11.0 release notes. Once we have any updates, I will let you know. > > ### Documentation > This sect

[GitHub] [pulsar-site] Technoboy- commented on pull request #167: [Don't Merge] Pulsar 2.11.0 release notes

2022-08-17 Thread GitBox
Technoboy- commented on PR #167: URL: https://github.com/apache/pulsar-site/pull/167#issuecomment-1217780389 > What about all the Pulsar IO stuff ? https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.11.0+label%3Acomponent%2Fconnector+is%3Aclosed Updated here: https://g

Re: [DISCUSS] Apache Pulsar 2.11.0 Release

2022-08-17 Thread Enrico Olivelli
We have this release blocker PR that is waiting for CI https://github.com/apache/pulsar/pull/17118 the problem is about a new API that has been introduced in 2.11 but the API has a little problem and we must fix it before the API to be released to the public Enrico Il giorno mar 16 ago 2022 alle

Re: [DISCUSS] PIP-200 Package Pulsar Trino distro and config in a dedicated folder

2022-08-17 Thread Enrico Olivelli
I generally agree with the PIP Can you please explain the interactions with the Pulsar Helm chart ? also we have to draw a migration path, because users that will upgrade Pulsar will have to move the configuration files in another location Enrico Il giorno mer 17 ago 2022 alle ore 11:15 tison h

[GitHub] [pulsar-site] Technoboy- commented on pull request #167: [Don't Merge] Pulsar 2.11.0 release notes

2022-08-17 Thread GitBox
Technoboy- commented on PR #167: URL: https://github.com/apache/pulsar-site/pull/167#issuecomment-1217728419 > What about all the Pulsar IO stuff ? https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.11.0+label%3Acomponent%2Fconnector+is%3Aclosed Sorry. I missed it. I will

[DISCUSS] PIP-200 Package Pulsar Trino distro and config in a dedicated folder

2022-08-17 Thread tison
Hello, This is a PIP to package the Pulsar Trino distro and config in a dedicated folder. Link: https://github.com/apache/pulsar/issues/17137 Prototype: https://github.com/apache/pulsar/pull/17062 Below you can find the proposal (I will amend the GH issue while we discuss it). Best, tison. Mot

[GitHub] [pulsar-site] nicoloboschi commented on pull request #167: [Don't Merge] Pulsar 2.11.0 release notes

2022-08-17 Thread GitBox
nicoloboschi commented on PR #167: URL: https://github.com/apache/pulsar-site/pull/167#issuecomment-1217723355 What about all the Pulsar IO stuff ? https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.11.0+label%3Acomponent%2Fconnector+is%3Aclosed -- This is an automated message

[GitHub] [pulsar-site] momo-jun commented on pull request #167: [Don't Merge] Pulsar 2.11.0 release notes

2022-08-17 Thread GitBox
momo-jun commented on PR #167: URL: https://github.com/apache/pulsar-site/pull/167#issuecomment-1217706752 @Technoboy- The following content regarding docs can be added to the 2.11.0 release notes. Once we have any updates, I will let you know. ### Documentation - [PIP-190] Sim