[GitHub] [pulsar-site] urfreespace commented on pull request #124: Fix versioned links for clients

2022-06-27 Thread GitBox
urfreespace commented on PR #124: URL: https://github.com/apache/pulsar-site/pull/124#issuecomment-1168297853 > I think @Anonymitaet can provide more context about it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #124: Fix versioned links for clients

2022-06-27 Thread GitBox
michaeljmarshall commented on PR #124: URL: https://github.com/apache/pulsar-site/pull/124#issuecomment-1168242422 @urfreespace - it looks like the website build for versioned docs is not working correctly. I think something might be broken. The change for this PR didn't get applied, and in

[GitHub] [pulsar-site] michaeljmarshall merged pull request #125: Remove trailing slash from clientVersionUrl

2022-06-27 Thread GitBox
michaeljmarshall merged PR #125: URL: https://github.com/apache/pulsar-site/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pul

[GitHub] [pulsar-site] Anonymitaet commented on pull request #125: Remove trailing slash from clientVersionUrl

2022-06-27 Thread GitBox
Anonymitaet commented on PR #125: URL: https://github.com/apache/pulsar-site/pull/125#issuecomment-1168216222 @urfreespace review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar-site] michaeljmarshall opened a new pull request, #125: Remove trailing slash from clientVersionUrl

2022-06-27 Thread GitBox
michaeljmarshall opened a new pull request, #125: URL: https://github.com/apache/pulsar-site/pull/125 In #124, I incorrectly included a trailing slash, which led to URLS getting generated with `//` at the end. This PR fixes that mistake. -- This is an automated message from the Apache Git

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #124: Fix versioned links for clients

2022-06-27 Thread GitBox
michaeljmarshall commented on PR #124: URL: https://github.com/apache/pulsar-site/pull/124#issuecomment-1168196377 After looking closer at the current website, it worked for https://pulsar.apache.org/docs/client-libraries-python/, but not for https://pulsar.apache.org/docs/2.10.0/client-lib

[GitHub] [pulsar-client-node] massakam commented on pull request #81: Support seting topic schema when creating producers/consumers

2022-06-27 Thread GitBox
massakam commented on PR #81: URL: https://github.com/apache/pulsar-client-node/pull/81#issuecomment-1168189552 @lcartercondon Could you fix the compilation error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #124: Fix versioned links for clients

2022-06-27 Thread GitBox
michaeljmarshall commented on PR #124: URL: https://github.com/apache/pulsar-site/pull/124#issuecomment-1168180993 Correction, it works for the 2.10.0 docs. The other docs appear to be the same. I'll continue debugging this. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #124: Fix versioned links for clients

2022-06-27 Thread GitBox
michaeljmarshall commented on PR #124: URL: https://github.com/apache/pulsar-site/pull/124#issuecomment-1168176968 Confirming that the website-next built and works correctly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar-site] michaeljmarshall merged pull request #124: Fix versioned links for clients

2022-06-27 Thread GitBox
michaeljmarshall merged PR #124: URL: https://github.com/apache/pulsar-site/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pul

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #124: Fix versioned links for clients

2022-06-27 Thread GitBox
michaeljmarshall commented on PR #124: URL: https://github.com/apache/pulsar-site/pull/124#issuecomment-1168160174 Note that I can confirm for the client api that these links are correct. See this link: https://pulsar.apache.org/api/. -- This is an automated message from the Apache Git Se

[GitHub] [pulsar-site] michaeljmarshall opened a new pull request, #124: Fix versioned links for clients

2022-06-27 Thread GitBox
michaeljmarshall opened a new pull request, #124: URL: https://github.com/apache/pulsar-site/pull/124 Fixes https://github.com/apache/pulsar/issues/15984. ## Motivation We have many versioned links in our docs. We replace those links by running `node replace.js` on the script I

[GitHub] [pulsar-site] michaeljmarshall commented on pull request #123: Remove old Python Client docs

2022-06-27 Thread GitBox
michaeljmarshall commented on PR #123: URL: https://github.com/apache/pulsar-site/pull/123#issuecomment-1168156455 Confirming the change had the desired affect. This link https://pulsar.apache.org/api/python/ is now: https://user-images.githubusercontent.com/47911938/176081404-57bd9d0

[GitHub] [pulsar-site] michaeljmarshall merged pull request #123: Remove old Python Client docs

2022-06-27 Thread GitBox
michaeljmarshall merged PR #123: URL: https://github.com/apache/pulsar-site/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pul

[GitHub] [pulsar-site] michaeljmarshall opened a new pull request, #123: Cleanup asf site next

2022-06-27 Thread GitBox
michaeljmarshall opened a new pull request, #123: URL: https://github.com/apache/pulsar-site/pull/123 ## Motivation The current docs are generated in an additive process where we build from the `main` branch and then copy the result to the `asf-site-next` branch. That means incorrect

[GitHub] [pulsar-manager] squallliu opened a new pull request, #469: Fixes #468

2022-06-27 Thread GitBox
squallliu opened a new pull request, #469: URL: https://github.com/apache/pulsar-manager/pull/469 Fixes #468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar-manager] squallliu opened a new issue, #468: namespace policies bugs

2022-06-27 Thread GitBox
squallliu opened a new issue, #468: URL: https://github.com/apache/pulsar-manager/issues/468 1. An error is reported when adding a role to the namespace 2. Adding a role text box and pressing Enter will refresh the page -- This is an automated message from the Apache Git Service. To res

Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-06-27 Thread Baodi Shi
Hi, I found some problems with `FunctionWindows` when I implemented this pip, and I added it to PIP: Implementation[4]. After I submit the first PR, you can refer to it. Thanks, Baodi Shi > On Jun 2, 2022, at 18:4232, 石宝迪 wrote: > >> Ok. I would add in the Compatability change another section