Re: [VOTE] PIP-165: Auto release client useless connections

2022-06-14 Thread Hang Chen
+1 Thanks, Hang Zike Yang 于2022年6月15日周三 10:31写道: > > +1 > > > Zike Yang > > On Wed, Jun 15, 2022 at 10:28 AM Haiting Jiang > wrote: > > > +1 > > > > Haiting > > > > On 2022/06/14 10:28:22 Xiangying Meng wrote: > > > +1 > > > > > > On Tue, Jun 14, 2022 at 3:52 PM Gavin Gao > > wrote: > > > > >

[GitHub] [pulsar-test-infra] Anonymitaet commented on a diff in pull request #43: Implement a new documentation bot

2022-06-14 Thread GitBox
Anonymitaet commented on code in PR #43: URL: https://github.com/apache/pulsar-test-infra/pull/43#discussion_r897534187 ## docbot/README.md: ## @@ -0,0 +1,54 @@ +# Documentation Bot + +Automatically label pull requests based on the checked task list. + +## Usage + +Create a wor

[GitHub] [pulsar-test-infra] Anonymitaet commented on issue #47: Remove Doc Bot Logic To Update PR Descriptions

2022-06-14 Thread GitBox
Anonymitaet commented on issue #47: URL: https://github.com/apache/pulsar-test-infra/issues/47#issuecomment-1155984923 Replied in https://github.com/apache/pulsar-test-infra/pull/43#issuecomment-1155856450 -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [DISCUSS] PIP-177: Add the classLoader field for SchemaDefinition

2022-06-14 Thread Cong Zhao
The priority of the classLoader field will be higher than by the pojoClass.getClassLoader() if with non JSON Schemas. On 2022/06/14 18:54:15 Enrico Olivelli wrote: > Hello, > how will it work with non JSON Schemas ? > > Enrico > > Il giorno mar 14 giu 2022 alle ore 17:57 Cong Zhao > ha scritto

Re: [VOTE] PIP-165: Auto release client useless connections

2022-06-14 Thread Zike Yang
+1 Zike Yang On Wed, Jun 15, 2022 at 10:28 AM Haiting Jiang wrote: > +1 > > Haiting > > On 2022/06/14 10:28:22 Xiangying Meng wrote: > > +1 > > > > On Tue, Jun 14, 2022 at 3:52 PM Gavin Gao > wrote: > > > > > +1 > > > > > > > > > On 2022/06/01 07:11:51 Yubiao Feng wrote: > > > > Hi Pulsar Com

Re: [VOTE] PIP-165: Auto release client useless connections

2022-06-14 Thread Haiting Jiang
+1 Haiting On 2022/06/14 10:28:22 Xiangying Meng wrote: > +1 > > On Tue, Jun 14, 2022 at 3:52 PM Gavin Gao wrote: > > > +1 > > > > > > On 2022/06/01 07:11:51 Yubiao Feng wrote: > > > Hi Pulsar Community: > > > > > > There were some mistakes in the last email, so I have corrected them. > > > >

[GitHub] [pulsar-helm-chart] zymap opened a new pull request, #271: Upgrade the pulsar manager image version to 0.3.0

2022-06-14 Thread GitBox
zymap opened a new pull request, #271: URL: https://github.com/apache/pulsar-helm-chart/pull/271 --- **Motivation** The pulsar manager released 0.3.0, we can upgrade it in our charts. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-helm-chart] zymap merged pull request #270: Enable the pulsar manager in the minikube values

2022-06-14 Thread GitBox
zymap merged PR #270: URL: https://github.com/apache/pulsar-helm-chart/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.a

[GitHub] [pulsar-helm-chart] zymap commented on pull request #270: Enable the pulsar manager in the minikube values

2022-06-14 Thread GitBox
zymap commented on PR #270: URL: https://github.com/apache/pulsar-helm-chart/pull/270#issuecomment-1155881534 Maybe we should upgrade the pulsar-manager to 0.3.0. I can upgrade it in another PR -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar-test-infra] Anonymitaet commented on pull request #43: Implement a new documentation bot

2022-06-14 Thread GitBox
Anonymitaet commented on PR #43: URL: https://github.com/apache/pulsar-test-infra/pull/43#issuecomment-1155856450 > I think we should remove this functionality. If the label is manually added, there is no need for the PR body to have the check box. The end goal is to have the right label on

[GitHub] [pulsar-site] Anonymitaet merged pull request #111: Recommitted the dropped instruction, CI Testing in your Fork

2022-06-14 Thread GitBox
Anonymitaet merged PR #111: URL: https://github.com/apache/pulsar-site/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.a

[GitHub] [pulsar-site] dave2wave merged pull request #117: Update Contributing.md

2022-06-14 Thread GitBox
dave2wave merged PR #117: URL: https://github.com/apache/pulsar-site/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-site] dave2wave merged pull request #112: Update community.js

2022-06-14 Thread GitBox
dave2wave merged PR #112: URL: https://github.com/apache/pulsar-site/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-site] dave2wave merged pull request #115: [docs][website] Update contributing.md to fix link errors

2022-06-14 Thread GitBox
dave2wave merged PR #115: URL: https://github.com/apache/pulsar-site/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-site] dave2wave commented on pull request #116: [docs][website]Update contributing.md

2022-06-14 Thread GitBox
dave2wave commented on PR #116: URL: https://github.com/apache/pulsar-site/pull/116#issuecomment-1155802401 #117 has this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [pulsar-site] dave2wave closed pull request #116: [docs][website]Update contributing.md

2022-06-14 Thread GitBox
dave2wave closed pull request #116: [docs][website]Update contributing.md URL: https://github.com/apache/pulsar-site/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar-site] dave2wave commented on pull request #117: Update Contributing.md

2022-06-14 Thread GitBox
dave2wave commented on PR #117: URL: https://github.com/apache/pulsar-site/pull/117#issuecomment-1155801184 I've viewed this change using `yarn` locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-site] dave2wave commented on pull request #112: Update community.js

2022-06-14 Thread GitBox
dave2wave commented on PR #112: URL: https://github.com/apache/pulsar-site/pull/112#issuecomment-1155799301 I've reviewed the update on my local environment using `yarn` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-site] aarondonwilliams opened a new pull request, #117: Update Contributing.md

2022-06-14 Thread GitBox
aarondonwilliams opened a new pull request, #117: URL: https://github.com/apache/pulsar-site/pull/117 Line 291 changed update to add, since most people would be adding a logo Line 293 changed "To update your company logo" to "To add your company's logo" Line 300-303: Made the example v

[GitHub] [pulsar-site] aarondonwilliams opened a new pull request, #116: [docs][website]Update contributing.md

2022-06-14 Thread GitBox
aarondonwilliams opened a new pull request, #116: URL: https://github.com/apache/pulsar-site/pull/116 Realized after the last PR #115 that there was another one. line 294: https://github.com/apache/pulsar-site/tree/main/site2/website-next/data/users.js Seems like this should be th

[GitHub] [pulsar-site] aarondonwilliams opened a new pull request, #115: [docs][website] Update contributing.md to fix link errors

2022-06-14 Thread GitBox
aarondonwilliams opened a new pull request, #115: URL: https://github.com/apache/pulsar-site/pull/115 In the Website section, line 288: updated the URL to https://github.com/apache/pulsar-site/tree/main/site2/website-next line 294: updated the URL to https://github.com/apache/pulsar-

[GitHub] [pulsar-site] aarondonwilliams commented on pull request #112: Update community.js

2022-06-14 Thread GitBox
aarondonwilliams commented on PR #112: URL: https://github.com/apache/pulsar-site/pull/112#issuecomment-1155663290 @Anonymitaet I did. I will say that I could not find on the website a place that links to the Read me page that you listed above (https://github.com/apache/pulsar-site/tre

Re: [DISCUSS] PIP-177: Add the classLoader field for SchemaDefinition

2022-06-14 Thread Enrico Olivelli
Hello, how will it work with non JSON Schemas ? Enrico Il giorno mar 14 giu 2022 alle ore 17:57 Cong Zhao ha scritto: > > Hello Pulsar Community, > > > Here is a PIP to add the classLoader field for SchemaDefinition. I look > forward to your feedback. > > > PIP: https://github.com/apache/pulsar/

[GitHub] [pulsar-site] heesung-sn commented on pull request #111: Recommitted the dropped instruction, CI Testing in your Fork

2022-06-14 Thread GitBox
heesung-sn commented on PR #111: URL: https://github.com/apache/pulsar-site/pull/111#issuecomment-117678 > Thanks for your contribution! Have you previewed your changes to ensure everything goes as expected? > > If not yet, please [preview your changes locally](https://github.com

[GitHub] [pulsar-test-infra] michaeljmarshall opened a new issue, #47: Remove Doc Bot Logic To Update PR Descriptions

2022-06-14 Thread GitBox
michaeljmarshall opened a new issue, #47: URL: https://github.com/apache/pulsar-test-infra/issues/47 ## Request With the addition of #43 and #44, we have a new doc bot. This bot updates PR descriptions, as can be seen on the PR description in the history of this PR https://github.com

[GitHub] [pulsar-test-infra] michaeljmarshall commented on pull request #43: Implement a new documentation bot

2022-06-14 Thread GitBox
michaeljmarshall commented on PR #43: URL: https://github.com/apache/pulsar-test-infra/pull/43#issuecomment-1155474369 > Able to update PR body automatically when labels is manually selected I think we should remove this functionality. If the label is manually added, there is no need

[GitHub] [pulsar-test-infra] michaeljmarshall commented on a diff in pull request #43: Implement a new documentation bot

2022-06-14 Thread GitBox
michaeljmarshall commented on code in PR #43: URL: https://github.com/apache/pulsar-test-infra/pull/43#discussion_r897085790 ## docbot/README.md: ## @@ -0,0 +1,54 @@ +# Documentation Bot + +Automatically label pull requests based on the checked task list. + +## Usage + +Create

Re: New proposal for chunk messages with shared subscriptions

2022-06-14 Thread Yunze Xu
I opened an initial PR for it: https://github.com/apache/pulsar/pull/16061 It doesn’t adopt any option of the original PIP 37. I think we need another proposal for it, just like the chunked message ID in PIP 107. Thanks, Yunze > 2022年6月7日 22:12,Yunze Xu 写道: > > Hi folks, > > Recently I'm

Re: [VOTE] Pulsar Release 2.10.1 Candidate 1

2022-06-14 Thread Massimiliano Mirelli
Thank you for the rc! +1 (non-binding) * verify sha512 checksums * verify gpg signatures * build pulsar and pulsar-all docker images (massimilianomirelli/pulsar{-all}:2.10.1-rc-1) * execute Fallout distributed system tests on multi-node k8s environment: * Pulsar functions, data-generator-source

[DISCUSS] PIP-177: Add the classLoader field for SchemaDefinition

2022-06-14 Thread Cong Zhao
Hello Pulsar Community, Here is a PIP to add the classLoader field for SchemaDefinition. I look forward to your feedback. PIP: https://github.com/apache/pulsar/issues/16058 Thanks, Cong Zhao

Re: Pulsar Documentation Guides

2022-06-14 Thread Yu
Hi all, Thanks for your feedback! These guides are all available on the Pulsar contribution page [1] and Pulsar readme [2]. The tip is a quick workaround to let everyone access and use them. These guides are WIP and continuously improved. I'll make them as parts of the website and on project-man

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #107: DotPulsar refers to the MySql.Data package, which will cause the consumer status to become 'Faulted' and eventually fail to consume

2022-06-14 Thread GitBox
blankensteiner commented on issue #107: URL: https://github.com/apache/pulsar-dotpulsar/issues/107#issuecomment-1155146768 Sure... btw, you were running the code on a non-Windows system, right? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [DISCUSS] Release Next Pulsar Helm Chart Version

2022-06-14 Thread Enrico Olivelli
Michael, thanks for bringing this up to the attention of the community Il giorno mar 14 giu 2022 alle ore 05:24 Michael Marshall ha scritto: > > Hello Pulsar Community, > > I propose that we release a new version of the Pulsar Helm Chart since > it now supports the 2.10.0 docker image. It looks l

Re: [VOTE] Pulsar Release 2.10.1 Candidate 1

2022-06-14 Thread Enrico Olivelli
+1 (binding) - Run all tests, on Ubuntu, JDK11 - Apache RAT, signatures, digests - Built from source - Tested the docker images and the staged Maven artifacts against multiple applications, including: * protocol handlers * proxy extensions * serve side filters Thanks for driving the release! Enr

[GitHub] [pulsar-site] Anonymitaet merged pull request #114: [feat][workflow] add links of doc contribution guides to Pulsar contribution page

2022-06-14 Thread GitBox
Anonymitaet merged PR #114: URL: https://github.com/apache/pulsar-site/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.a

Re: [VOTE] PIP-165: Auto release client useless connections

2022-06-14 Thread Xiangying Meng
+1 On Tue, Jun 14, 2022 at 3:52 PM Gavin Gao wrote: > +1 > > > On 2022/06/01 07:11:51 Yubiao Feng wrote: > > Hi Pulsar Community: > > > > There were some mistakes in the last email, so I have corrected them. > > > > I would like to start a VOTE on "Auto release client useless connections" > > (P

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #107: DotPulsar refers to the MySql.Data package, which will cause the consumer status to become 'Faulted' and eventually fail to consume

2022-06-14 Thread GitBox
blankensteiner commented on issue #107: URL: https://github.com/apache/pulsar-dotpulsar/issues/107#issuecomment-1154994399 I have just pushed to master. Give the new bits a try and let me know if that floats your boat :-) -- This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #114: [feat][workflow] add links of doc contribution guides to Pulsar contribution page

2022-06-14 Thread GitBox
Anonymitaet opened a new pull request, #114: URL: https://github.com/apache/pulsar-site/pull/114 Preview looks good: https://user-images.githubusercontent.com/50226895/173533563-c35c7372-1f23-43fc-ba5d-9122b04bf7f6.png";> -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar-dotpulsar] justinwujian commented on issue #107: DotPulsar refers to the MySql.Data package, which will cause the consumer status to become 'Faulted' and eventually fail to consume me

2022-06-14 Thread GitBox
justinwujian commented on issue #107: URL: https://github.com/apache/pulsar-dotpulsar/issues/107#issuecomment-1154880516 > Hi @justinwujian DotPulsar does not reference MySql.Data, so that sounds very strange. Could you add a custom exception handler and provide some more info? I al

[GitHub] [pulsar-dotpulsar] justinwujian commented on issue #107: DotPulsar refers to the MySql.Data package, which will cause the consumer status to become 'Faulted' and eventually fail to consume me

2022-06-14 Thread GitBox
justinwujian commented on issue #107: URL: https://github.com/apache/pulsar-dotpulsar/issues/107#issuecomment-1154868333 > Hi @justinwujian DotPulsar does not reference MySql.Data, so that sounds very strange. Could you add a custom exception handler and provide some more info? DotP

[GitHub] [pulsar-dotpulsar] justinwujian commented on issue #107: DotPulsar refers to the MySql.Data package, which will cause the consumer status to become 'Faulted' and eventually fail to consume me

2022-06-14 Thread GitBox
justinwujian commented on issue #107: URL: https://github.com/apache/pulsar-dotpulsar/issues/107#issuecomment-1154867231 > Hi @justinwujian DotPulsar does not reference MySql.Data, so that sounds very strange. Could you add a custom exception handler and provide some more info?

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #107: DotPulsar refers to the MySql.Data package, which will cause the consumer status to become 'Faulted' and eventually fail to consume

2022-06-14 Thread GitBox
blankensteiner commented on issue #107: URL: https://github.com/apache/pulsar-dotpulsar/issues/107#issuecomment-1154860197 Hi @justinwujian DotPulsar does not reference MySql.Data, so that sounds very strange. Could you add a custom exception handler and provide some more info? --

[GitHub] [pulsar-manager] tuteng merged pull request #455: Move version to 0.3.0

2022-06-14 Thread GitBox
tuteng merged PR #455: URL: https://github.com/apache/pulsar-manager/pull/455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apa

[GitHub] [pulsar-dotpulsar] justinwujian opened a new issue, #107: DotPulsar refers to the MySql.Data package, which will cause the consumer status to become 'Faulted' and eventually fail to consume m

2022-06-14 Thread GitBox
justinwujian opened a new issue, #107: URL: https://github.com/apache/pulsar-dotpulsar/issues/107 DotPulsar refers to the MySql.Data package, which will cause the consumer status to become 'Faulted' and eventually fail to consume messages. ![image](https://user-images.githubusercontent.

Re: [VOTE] PIP-165: Auto release client useless connections

2022-06-14 Thread Gavin Gao
+1 On 2022/06/01 07:11:51 Yubiao Feng wrote: > Hi Pulsar Community: > > There were some mistakes in the last email, so I have corrected them. > > I would like to start a VOTE on "Auto release client useless connections" > (PIP-165). > > Proposal Link: [PIP-165] Auto release client useless conn

[GitHub] [pulsar-site] Anonymitaet commented on pull request #111: Recommitted the dropped instruction, CI Testing in your Fork

2022-06-14 Thread GitBox
Anonymitaet commented on PR #111: URL: https://github.com/apache/pulsar-site/pull/111#issuecomment-1154810906 Thanks for your contribution! Have you previewed your changes to ensure everything goes as expected? If not yet, please [preview your changes locally](https://github.com/apa

[GitHub] [pulsar-test-infra] Anonymitaet commented on a diff in pull request #43: Implement a new documentation bot

2022-06-14 Thread GitBox
Anonymitaet commented on code in PR #43: URL: https://github.com/apache/pulsar-test-infra/pull/43#discussion_r896457872 ## docbot/README.md: ## @@ -0,0 +1,54 @@ +# Documentation Bot + +Automatically label pull requests based on the checked task list. + +## Usage + +Create a wor

[GitHub] [pulsar-test-infra] Anonymitaet commented on pull request #43: Implement a new documentation bot

2022-06-14 Thread GitBox
Anonymitaet commented on PR #43: URL: https://github.com/apache/pulsar-test-infra/pull/43#issuecomment-1154806188 > > @maxsxu thanks for your great contribution! We've tested and it works well. Approve from the non-technical side. > > @Anonymitaet how was this tested? all jobs fail in

[GitHub] [pulsar-site] Anonymitaet commented on pull request #112: Update community.js

2022-06-14 Thread GitBox
Anonymitaet commented on PR #112: URL: https://github.com/apache/pulsar-site/pull/112#issuecomment-1154801839 @aarondonwilliams thanks for your contribution! Have you previewed it on your local machine to ensure everything goes fine? Preview steps: https://github.com/apache/pulsar-site/tree