Re: [VOTE] PIP-168: Support zero-copy of NIC to NIC on Proxy

2022-05-30 Thread PengHui Li
+1 Could you please also add the new configuration to the proposal? I see you added in the PR https://github.com/apache/pulsar/pull/15678/files but not present in the proposal Thanks, Penghui On Thu, May 26, 2022 at 9:40 PM zhaocong wrote: > Hi Pulsar Community, > > > I would like to start a V

[GitHub] [pulsar-site] Anonymitaet commented on pull request #100: Suggest pulsar-admin-client

2022-05-30 Thread GitBox
Anonymitaet commented on PR #100: URL: https://github.com/apache/pulsar-site/pull/100#issuecomment-1141590818 @urfreespace @visortelle thanks, commented in new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-05-30 Thread Asaf Mesika
Still new to the PIP process: Shouldn't this PIP be added here ? On Thu, May 12, 2022 at 11:52 AM Baozi wrote: > Hi Pulsar community, > > I open a https://github.com/apache/pulsar/issues/15560 for Function add > NONE delivery se

Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-05-30 Thread Asaf Mesika
On Mon, May 30, 2022 at 4:24 PM Baozi wrote: > Hi, Rui. > > Thanks review. > > > 1. API changes should also contain the changes of `Function.proto`, > including new `ProcessingGuarantees` option and `autoAck`. > > > I added to pip. > > > 2. Please be sure the other language runtimes (like Python,

Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-05-30 Thread Asaf Mesika
Thanks for applying the fixes. 1. Regarding > >- EFFECTIVELY_ONCE: The message is acknowledged *after* the function >finished execution. Depends on pulsar deduplication, and provides >end-to-end effectively once processing. > > I'm not entirely sure that is accurate. The Effectively-O

Re: [DISCUSS] PIP-157 Exclusive Producer: new mode ExclusiveWithFencing

2022-05-30 Thread Christophe Bornet
+1 for "Preemptive". Le ven. 27 mai 2022 à 00:22, Neng Lu a écrit : > Hi All, > > Would "Preemptive" Mode make sense? > > On Wed, May 11, 2022 at 8:56 AM Matteo Merli > wrote: > > > +1 > > > > > > On Tue, May 10, 2022 at 5:56 AM Enrico Olivelli > > wrote: > > > > > Hello, > > > I created a new

Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-05-30 Thread Baozi
Hi, Rui. Thanks review. > 1. API changes should also contain the changes of `Function.proto`, including > new `ProcessingGuarantees` option and `autoAck`. I added to pip. > 2. Please be sure the other language runtimes (like Python, Golang) do > support similar `record.ack()` function from t

Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-05-30 Thread Baozi
Hi, Neng. Thank review. > 1. Instead of deleting the `autoAck`, keep it but not use it in the code. > And documented clearly it's deprecated for the following 2~3 release. And > then delete it. Great! I changed PIP. Refer to the latest pip. https://github.com/apache/pulsar/issues/15560 > 2. Fo

Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-05-30 Thread Baozi
Hi, Mesika. Thanks review. >> 2. I suggest calling it `MANUAL` `ProcessingGuarantee` instead of NONE. As >> you carefully explained, ProcessingGuarantee comes does to the fact that >> the function executor calls acknowledge, in specific timing: Added, Refer to the latest pip. https://github.com

[GitHub] [pulsar-site] visortelle closed pull request #100: Suggest pulsar-admin-client

2022-05-30 Thread GitBox
visortelle closed pull request #100: Suggest pulsar-admin-client URL: https://github.com/apache/pulsar-site/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [pulsar-site] visortelle commented on pull request #100: Suggest pulsar-admin-client

2022-05-30 Thread GitBox
visortelle commented on PR #100: URL: https://github.com/apache/pulsar-site/pull/100#issuecomment-1140991081 Done. https://github.com/apache/pulsar/pull/15839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pulsar-site] urfreespace commented on pull request #100: Suggest pulsar-admin-client

2022-05-30 Thread GitBox
urfreespace commented on PR #100: URL: https://github.com/apache/pulsar-site/pull/100#issuecomment-1140978170 Thanks for @visortelle, but in fact, you need to modify the docs from the `pulsar` repo, https://github.com/apache/pulsar/blob/master/site2/website/versioned_docs/version-2.9.2/clie

[Discussion] Optimize Doc Bot

2022-05-30 Thread Yu
Hi Pulsarers, As you know, to improve the efficiency of documentation management, we introduced the doc Bot to our community last year [1]. It has been run for more than 8 months. During this period, we’ve found some potential and serious issues in doc Bot, which lowers productivity. Consequently