Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-05-29 Thread Rui Fu
Hi Baodi, Nice work. Put some suggestions below, ptal. 1. API changes should also contain the changes of `Function.proto`, including new `ProcessingGuarantees` option and `autoAck`. 2. Please be sure the other language runtimes (like Python, Golang) do support similar `record.ack()` function fr

[GitHub] [pulsar-client-node] MoshePiamenta commented on issue #87: npm install fails on MacOS

2022-05-29 Thread GitBox
MoshePiamenta commented on issue #87: URL: https://github.com/apache/pulsar-client-node/issues/87#issuecomment-1140518425 For me this is still not working. I've tried @cjfff 's advice and I still get an error. BTW this step does not show on the docs: https://pulsar.apache.org/docs/client-l

Re: [DISCUSS] PIP-166: Function add NONE delivery semantics

2022-05-29 Thread Asaf Mesika
1. "Added NONE delivery semantics and delete autoAck config." - Added --> add 2. I suggest calling it `MANUAL` `ProcessingGuarantee` instead of NONE. As you carefully explained, ProcessingGuarantee comes does to the fact that the function executor calls acknowledge, in specific timing: - `AT_MO