[VOTE] Pulsar Client Go Release 0.8.1 Candidate 1

2022-03-08 Thread rfu
Hi everyone, Please review and vote on the release candidate #1 for the version 0.8.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This is the first release candidate for Apache Pulsar Go client, version 0.8.1. It fixes the follo

[GitHub] [pulsar-client-node] hassanzia32 commented on issue #201: Support for Dead Letter Topics in Consumers?

2022-03-08 Thread GitBox
hassanzia32 commented on issue #201: URL: https://github.com/apache/pulsar-client-node/issues/201#issuecomment-1062623571 @nkurihar, thank you for confirming. Is there a timeline on when this would be added, if it exists? Thanks for all your contributions to this client. -- This

Re: [VOTE] Pulsar Release 2.8.3 Candidate 4

2022-03-08 Thread Michael Marshall
Thank you for the validation. Closing this vote with 3 +1(binding) votes. I plan to start the subsequent release work tomorrow. Thanks, Michael On Mon, Mar 7, 2022 at 7:48 PM PengHui Li wrote: > > +1 (binding) > > - Checked signatures > - Run standalone, publish/consume messages > - Checked c

Re: [DISCUSS] PrometheusMetricsServlet performance improvement

2022-03-08 Thread Michael Marshall
Thanks for looking into the prometheus client, Tao Jiuming. I am surprised that it isn't optimized to minimize heap usage. In that case, I think it makes sense to move forward with your solution. Thanks, Michael On Mon, Feb 28, 2022 at 10:23 PM PengHui Li wrote: > > Hi, > > Thanks for the upda

Re: New Feature Proposal: flag to require a non-partitioned topic on Producer/Consumer Builder

2022-03-08 Thread Michael Marshall
> Additionally it would be good to force triggering the creation of a non > partitioned topic even if the namespace/broker is configured to > automatically create partitioned topics I think this additional feature request is a bit more controversial than the fail fast logic discussed earlier. To t

[VOTE] [PIP-144] Making SchemaRegistry implementation configurable

2022-03-08 Thread Aparajita Singh
Hi, I would like to start a vote for PIP-144: https://github.com/apache/pulsar/issues/14395 Discussion thread: https://lists.apache.org/thread/z97cvs8mvhlydv8rbnqk4d0c7mp8rwt3 -- Thanks, Aparajita

Re: [DISCUSS] PIP-145: Improve performance of regex subscriptions

2022-03-08 Thread Michael Marshall
My primary concern is that our event driven messaging platform relies on polling for distribution of system events, like newly created topics. I would love to find a purely event driven solution. I have some additional questions before I reply to the above feedback. How will this feature affect P

[GitHub] [pulsar-client-node] nkurihar commented on issue #201: Support for Dead Letter Topics in Consumers?

2022-03-08 Thread GitBox
nkurihar commented on issue #201: URL: https://github.com/apache/pulsar-client-node/issues/201#issuecomment-1062535047 Unfortunately the node.js client doesn't support the dead letter topic for now. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [VOTE] [PIP-143] Support split bundle by specified boundaries

2022-03-08 Thread Lin Lin
+1 Thanks, Lin Lin

Re: [VOTE] Pulsar Node.js Client Release 1.6.2 Candidate 1

2022-03-08 Thread aaa
Hi Guangning, https://www.npmjs.com/package/pulsar-client Did you upload 1.6.2-rc.1 to the npm registry? I think we should not upload the package which is not voted / verified, at least for the latest package, since users regard it as "stable". Could you change the latest version from 1.6.2-rc.1

Re: [DISUSS] Improve unit test stability

2022-03-08 Thread Baozi
Thank your reply. I agree with the idea mentioned above. However, I have a question: Why don't we fix all the flaky tests first? After, We can not allow all tests to retry. 1. Fix all existing flaky tests. 2. Then, in each PR, for all tests, as long as they fail, let the job fail 3. If there a

Re: [VOTE] PIP-145: Improve performance of regex subscriptions

2022-03-08 Thread PengHui Li
+1 Penghui On Tue, Mar 8, 2022 at 6:11 PM Andras Beni wrote: > Hi Pulsar Community, > > I would like to start a VOTE on "Improve performance of regex > subscriptions" (PIP-145). > > The proposal can be read at https://github.com/apache/pulsar/issues/14505 > and the discussion thead is available

Re: Creating Good Release notes

2022-03-08 Thread PengHui Li
> As you mentioned, ideally, we'd complete classification at merge time, not at release time. We could probably use our GitHub bot to help ensure this classification is completed before merging. +1 Thanks, Penghui On Wed, Mar 9, 2022 at 4:06 AM Michael Marshall wrote: > Hi Penghui, > > I just

Re: [DISUSS] Improve unit test stability

2022-03-08 Thread PengHui Li
> Alternatively, would it be possible to only retry tests that are annotated as "flaky"? This would exclude all new tests, by default, and it'd make it clearer which tests need to be fixed. +1, If a test in other group which we can confirm it is a flaky test, we can move it to flaky group. Pengh

Re: Happy International Women’s Day!

2022-03-08 Thread PengHui Li
Thanks to all the female contributors Penghui On Wed, Mar 9, 2022 at 5:21 AM Sijie Guo wrote: > Best wishes to all the female contributors! > > - Sijie > > On Tue, Mar 8, 2022 at 9:00 AM Yu wrote: > >> Dear Pulsar female contributors, >> >> Success doesn’t come easy and women never give up. Th

Re: [VOTE] Pulsar Node.js Client Release 1.6.2 Candidate 1

2022-03-08 Thread Hiroyuki Sakai
+1 (binding) * Check the license headers * Verify the checksum / signature * Built the source * Ran producer and consumer Regards, Hiroyuki From: Guangning E Sent: Monday, March 7, 2022 19:29 To: Dev ; us...@pulsar.apache.org Subject: [VOTE] Pulsar Node.js Clie

[GitHub] [pulsar-helm-chart] dwn-cadams opened a new issue #241: Field is immutable error when upgrading helm chart after changing zk replica count

2022-03-08 Thread GitBox
dwn-cadams opened a new issue #241: URL: https://github.com/apache/pulsar-helm-chart/issues/241 **Describe the bug** Recently we increased zookeeper replicas from 1 to 3 when moving a cluster to prod. When we did this, we discovered the init jobs (https://github.com/apache/pulsar-helm-c

Re: [Discuss] Create Pulsar client release notes

2022-03-08 Thread Michael Marshall
> Add necessary explanations, such as time-based release plan, release > frequency, semantic versioning, maintenance life cycle, etc. I support adding the release dates and support dates to the downloads page. This makes it clear which downloads are supported and for how long. I am happy to submi

Re: [ANNOUNCE] New Committer: Andrey Yegorov

2022-03-08 Thread Christophe Bornet
Congratulations Andrey ! Le lun. 7 mars 2022 à 20:26, Dave Fisher a écrit : > The Apache Pulsar Project Management Committee (PMC) has invited Andrey > Yegorov > https://github.com/dlg99 to become a committer and we are pleased to > announce that he has accepted. > > Andrey has made great contri

Re: [DISCUSS] Location of Security Page on Website

2022-03-08 Thread Michael Marshall
Thanks for your reply, Yu. I am fine with separating the information in the "Security Policy and Supported Versions" page. First, I think it would make sense to add "reporting a vulnerability" information anywhere that our documentation has contact info (many of the pages you reference have their

[OUTREACH] March '22 Edition of 'Happenings in the Neighborhood' is out now

2022-03-08 Thread Aaron Williams
Hello Apache Pulsar Neighbors, In this issue of Happenings we talk about another new milestone, a preview of the new website, 2 new committers, the community technical meetings, and new events.

Re: Happy International Women’s Day!

2022-03-08 Thread Sijie Guo
Best wishes to all the female contributors! - Sijie On Tue, Mar 8, 2022 at 9:00 AM Yu wrote: > Dear Pulsar female contributors, > > Success doesn’t come easy and women never give up. Thanks for bringing so > much love and support to the Pulsar community. And every man needs a > woman when his l

Re: [ANNOUNCE] New Committer: Andrey Yegorov

2022-03-08 Thread Michael Marshall
Congratulations, Andrey! - Michael On Mon, Mar 7, 2022 at 4:20 PM Andrey Yegorov wrote: > > Thank you! > > On Mon, Mar 7, 2022 at 12:23 PM Enrico Olivelli wrote: > > > Congratulations! > > > > Enrico > > > > Il Lun 7 Mar 2022, 20:26 Dave Fisher ha scritto: > > > > > The Apache Pulsar Project M

Re: [DISUSS] Improve unit test stability

2022-03-08 Thread Michael Marshall
This is a great discussion, thanks for starting it. I support turning off retries for new tests, as Lari suggests. However, I will point out that this change is not the same as the initially proposed change to increase the number of times a new test is run (point (1) in the original email for this

Re: Creating Good Release notes

2022-03-08 Thread Michael Marshall
Hi Penghui, I just started doing something similar for the 2.8.3 release notes. I think a script is a good place to start for creating release notes, but I also think the notes will still need to be revised by a human. I agree with Jonathan's point that a commit log is too detailed for release not

Re: [DISCUSS] Releasing pulsar-client-go 0.8.1

2022-03-08 Thread Michael Marshall
+1 for releasing 0.8.1. Thanks for starting this discussion, Rui. Is there any official ASF protocol for dealing with this situation? I think we should warn users about the unintended GPL dependency included in 0.8.0. Perhaps we can do that by adding a warning to the GitHub Release page for 0.8.0

Happy International Women’s Day!

2022-03-08 Thread Yu
Dear Pulsar female contributors, Success doesn’t come easy and women never give up. Thanks for bringing so much love and support to the Pulsar community. And every man needs a woman when his life is a mess, just like the game of chess — the queen protects the king. Best wishes on International Wom

Re: [DISUSS] Improve unit test stability

2022-03-08 Thread Baozi
Good job! I see. Now we retry all tests by default. What's the reason? The process I understand is: We don't need to retry the unit test. Once the test fails, let the job fail. The difference is that new or modified tests need to be tested many times. As long as there is one failure, the job wi

[GitHub] [pulsar-site] DaveDuggins commented on a change in pull request #8: Integrating changes from community feedback

2022-03-08 Thread GitBox
DaveDuggins commented on a change in pull request #8: URL: https://github.com/apache/pulsar-site/pull/8#discussion_r821652913 ## File path: site2/website-next/docusaurus.config.js ## @@ -143,54 +142,6 @@ module.exports = { position: "right", label: "Docs",

Re: [DISUSS] Improve unit test stability

2022-03-08 Thread Lari Hotari
Here's a PR to disable tests retries for new and modified tests: https://github.com/apache/pulsar/pull/14607 Please review and provide feedback. -Lari On 2022/03/08 11:24:13 Lari Hotari wrote: > I think this is a good idea. In CI, the tests will be retried multiple > times at multiple levels: at

Re: [DISUSS] Improve unit test stability

2022-03-08 Thread Lari Hotari
I think this is a good idea. In CI, the tests will be retried multiple times at multiple levels: at the test class / test method level and at the build level. I'd like to get rid of test retries completely, since that is the reason why the flakiness problem gets worse over time. This was also cove

Re: [VOTE] Pulsar Node.js Client Release 1.6.2 Candidate 1

2022-03-08 Thread Nozomi Kurihara
+1 (binding) * Check the license headers * Verify the checksum / signature * Built the source * Ran producer and consumer Best Regards, Nozomi 2022年3月8日(火) 17:54 Masahiro Sakamoto : > +1 (binding) > > * Checked the license headers > * Verified the checksum and signature > * Built the source and

[VOTE] PIP-145: Improve performance of regex subscriptions

2022-03-08 Thread Andras Beni
Hi Pulsar Community, I would like to start a VOTE on "Improve performance of regex subscriptions" (PIP-145). The proposal can be read at https://github.com/apache/pulsar/issues/14505 and the discussion thead is available at https://lists.apache.org/thread/51y8s6tfw1p1h5dcb9fgzkzd8tw2bqpz . Votin

[GitHub] [pulsar-adapters] eolivelli merged pull request #35: Import dependencies from Pulsar's parent POM

2022-03-08 Thread GitBox
eolivelli merged pull request #35: URL: https://github.com/apache/pulsar-adapters/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

[GitHub] [pulsar-site] Anonymitaet commented on a change in pull request #8: Integrating changes from community feedback

2022-03-08 Thread GitBox
Anonymitaet commented on a change in pull request #8: URL: https://github.com/apache/pulsar-site/pull/8#discussion_r821479500 ## File path: site2/website-next/docusaurus.config.js ## @@ -143,54 +142,6 @@ module.exports = { position: "right", label: "Docs",

[GitHub] [pulsar-site] Anonymitaet commented on a change in pull request #8: Integrating changes from community feedback

2022-03-08 Thread GitBox
Anonymitaet commented on a change in pull request #8: URL: https://github.com/apache/pulsar-site/pull/8#discussion_r821479500 ## File path: site2/website-next/docusaurus.config.js ## @@ -143,54 +142,6 @@ module.exports = { position: "right", label: "Docs",

Re: Creating Good Release notes

2022-03-08 Thread Yu
Hi penghui, > 1. The title of the PR should be refined during the PR review, before merging it. For this item, I'll define the writing rules for PR titles and send them out for review. On Tue, Mar 8, 2022 at 10:00 AM PengHui Li wrote: > For 2.10.0 release, I'm using `gh` command to generate t

RE: [VOTE] Pulsar Node.js Client Release 1.6.2 Candidate 1

2022-03-08 Thread Masahiro Sakamoto
+1 (binding) * Checked the license headers * Verified the checksum and signature * Built the source and ran producer/consumer However, it seems that the tag "v1.6.2-rc.1" has not been pushed to the remote repository yet. https://github.com/apache/pulsar-client-node/tags Would you please push th

Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-08 Thread Zixuan Liu
Good catch! PengHui Li 于2022年3月8日周二 13:37写道: > > We don't support rollback the data of the previous version Once you > enable > this feature. > > If you want to roll back to an old version, need to disable the cursor > compression, > wait a while, or restart the broker first to make sure the cur

Re: [DISUSS] Improve unit test stability

2022-03-08 Thread Enrico Olivelli
Il giorno mar 8 mar 2022 alle ore 03:08 PengHui Li ha scritto: > > I think we can try this idea, it looks like to find a way to > ensure the new changes from the test will not introduce > new uncertainty. Yes, "trying" is good. +1 Enrico > > Penghui > > On Mon, Mar 7, 2022 at 11:27 PM Baozi >

Re: [DISCUSS] Byte schema compatibility issue

2022-03-08 Thread Enrico Olivelli
Il Mar 8 Mar 2022, 06:24 PengHui Li ha scritto: > +1 the byte schema should also abide by the schema compatibility strategy > If I remember correctly, the byte schema should always compatible with > string schema > > Penghui > > > On Tue, Mar 8, 2022 at 10:56 AM guo jiwei wrote: > > > Hi, > >