Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-06 Thread Zixuan Liu
Hi everyone, Good catch! I update my proposal on https://github.com/apache/pulsar/issues/14529, and the compatibility part has been appended: 1. The compression is disabled by default 2. We need to consider how to migrate the old data when this compression has been enabled. If the cursor data hea

Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-06 Thread Zixuan Liu
Hi PengHui, Sorry, the correct URL: https://github.com/apache/pulsar/issues/14529. :( Because of the problem of subscription, the email here is very confusing. PengHui Li 于2022年3月7日周一 12:39写道: > Hi Zixuan, > > Looks like you have added the wrong link for the proposal? > https://github.com/apa

Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-06 Thread Zixuan Liu
Hi Haiting, Good catch! I can add a threshold to decide to compress or not. Best, Zixuan Haiting Jiang 于2022年3月6日周日 12:04写道: > This is a global setting now. But I wonder if we should compress it only > if the size > is over a threshold? Because: > 1. It's not easy for us to notice some manag

Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-06 Thread Zixuan Liu
Hi Mattison, Thanks for your feedback! I think using two configurations is more flexible, and users can set up different compression types. Best, Zixuan mattison chao 于2022年3月6日周日 08:41写道: > Hi, Zi Xuan > > After deep think, I have another question: > > Why don't we combine ledger compaction

Re: [DISUSS] Improve unit test stability

2022-03-06 Thread Haiting Jiang
+1 for this great idea. Although I am not sure if there is an easy and accurate way to "find new or modified unit tests". Thanks, Haiting On 2022/03/07 03:11:47 包子 wrote: > Hi, I want to discuss how to improve the stability of unit testing.I found > that most flaky unit tests can be reproduc lo

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-03-06 Thread guo jiwei
Hi Penghui, After test, we can use #12136 to stop the replicator. Regards Jiwei Guo (Tboy) On Sat, Mar 5, 2022 at 5:31 PM PengHui Li wrote: > > Great point. I was focused on deleting namespaces and missed the case > where the user wants to delete a topic from a replicated namespace. I > a

Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-06 Thread PengHui Li
Hi Zixuan, Looks like you have added the wrong link for the proposal? https://github.com/apache/pulsar/issues/14395 is for PIP-44 Penghui On Mon, Mar 7, 2022 at 12:37 PM PengHui Li wrote: > > This is a global setting now. But I wonder if we should compress it only > if the size > is over a thr

Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-06 Thread PengHui Li
> This is a global setting now. But I wonder if we should compress it only if the size is over a threshold? +1 Penghui On Sun, Mar 6, 2022 at 6:57 PM Enrico Olivelli wrote: > Il Dom 6 Mar 2022, 05:04 Haiting Jiang ha > scritto: > > > This is a global setting now. But I wonder if we should com

[GitHub] [pulsar-site] dave2wave commented on issue #13: Logo and navigation menu bar overlap

2022-03-06 Thread GitBox
dave2wave commented on issue #13: URL: https://github.com/apache/pulsar-site/issues/13#issuecomment-1060181883 I'm not sure that this is setup correctly. as at one width it's ok but then a slightly wider window it's not. Can it always take the narrower approach https://user-images.github

[DISUSS] Improve unit test stability

2022-03-06 Thread 包子
Hi, I want to discuss how to improve the stability of unit testing.I found that most flaky unit tests can be reproduc locally and only need to be executed a few more times. Can we add the following mandatory constraints to ensure the stability of unit testing of code? 1. If new / modified unit

Re: [DISCUSS] Releasing pulsar-client-go 0.8.1

2022-03-06 Thread r...@apache.org
+1 -- Thanks Xiaolong Ran PengHui Li 于2022年3月5日周六 18:10写道: > +1 > > Penghui > > On Sat, Mar 5, 2022 at 4:58 AM Matteo Merli > wrote: > > > +1 Thanks Rui, we should eliminate the GPL dependency ASAP. > > > > > > > > -- > > Matteo Merli > > > > > > On Thu, Mar 3, 2022 at 2:08 AM Rui Fu wrote:

[GitHub] [pulsar-site] urfreespace merged pull request #14: fix: Logo and navigation menu bar overlap

2022-03-06 Thread GitBox
urfreespace merged pull request #14: URL: https://github.com/apache/pulsar-site/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [pulsar-site] urfreespace closed issue #13: Logo and navigation menu bar overlap

2022-03-06 Thread GitBox
urfreespace closed issue #13: URL: https://github.com/apache/pulsar-site/issues/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

[GitHub] [pulsar-site] urfreespace opened a new pull request #14: fix: Logo and navigation menu bar overlap

2022-03-06 Thread GitBox
urfreespace opened a new pull request #14: URL: https://github.com/apache/pulsar-site/pull/14 fix: https://github.com/apache/pulsar-site/issues/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-site] dave2wave opened a new issue #13: Logo and navigation menu bar overlap

2022-03-06 Thread GitBox
dave2wave opened a new issue #13: URL: https://github.com/apache/pulsar-site/issues/13 See the screenshot: https://user-images.githubusercontent.com/29803617/156935251-71402bd0-b3b0-4e7e-81d1-6d64e63c1082.png";> -- This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar-site] dave2wave merged pull request #12: Fixed Rewrites by adding flags [R=301,DPI,L]

2022-03-06 Thread GitBox
dave2wave merged pull request #12: URL: https://github.com/apache/pulsar-site/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[GitHub] [pulsar-site] dave2wave opened a new pull request #12: Fixed Rewrites by adding flags [R=301,DPI,L]

2022-03-06 Thread GitBox
dave2wave opened a new pull request #12: URL: https://github.com/apache/pulsar-site/pull/12 Flags are described here: https://httpd.apache.org/docs/current/rewrite/flags.html I'm making a PR to better expose the fix. -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-manager] HartmutDIL commented on issue #283: Pulsar Manager keeps saying "This environment is error. Please check it"

2022-03-06 Thread GitBox
HartmutDIL commented on issue #283: URL: https://github.com/apache/pulsar-manager/issues/283#issuecomment-1059977409 I was able to solve the problem in the meantime. The reason was that JWT was switched on and therefore an unauthorized access attempt occurred which was of course rejected.

[GitHub] [pulsar-client-node] hassanzia32 opened a new issue #201: Support for Dead Letter Queueus in Consumers?

2022-03-06 Thread GitBox
hassanzia32 opened a new issue #201: URL: https://github.com/apache/pulsar-client-node/issues/201 Does the nodeJS client currently support [dead letter queues](https://pulsar.apache.org/docs/en/concepts-messaging/#dead-letter-topic)? -- This is an automated message from the Apache Git Se

Re: [DISCUSSION][PIP-146] ManagedCursorInfo compression

2022-03-06 Thread Enrico Olivelli
Il Dom 6 Mar 2022, 05:04 Haiting Jiang ha scritto: > This is a global setting now. But I wonder if we should compress it only > if the size > is over a threshold? Good idea Enrico Because: > 1. It's not easy for us to notice some managed cursor info is too large in > advance, normally it