[GitHub] [pulsar-client-node] tuteng opened a new pull request #196: Fixed pulsar client node mac install script

2022-02-24 Thread GitBox
tuteng opened a new pull request #196: URL: https://github.com/apache/pulsar-client-node/pull/196 * Fixed pulsar client node install script on mac * Update read me doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[DISCUSS] Likely Deadlock Scenario In 2.9, Possibly 2.10

2022-02-24 Thread Michael Marshall
Hello Pulsar Community, I am in the process of investigating what I believe to be a broker deadlock scenario that affects branch-2.9 and likely branch-2.10. (I haven't had a chance to check branch-2.8 yet.) I quickly described some of the details in this issue [0]. The deadlock is related to wait

Re: [VOTE] Pulsar Node.js Client Release 1.6.0 Candidate 1

2022-02-24 Thread Guangning E
Thanks, I also noticed another issue with the installation on mac, I'll fix them and then start a vote for candidate 2 Thanks, Guangning Hiroyuki Sakai 于2022年2月25日周五 10:32写道: > Hi, Guangning > > I can't unpack pulsar-client-node-1.6.0.tar.gz. > Would you please check this file? > > > $ wget > h

Re: [DISCUSS] PrometheusMetricsServlet performance improvement

2022-02-24 Thread Michael Marshall
> Old codes, I think at that time, prometheus is not popular yet I think there is likely more explanation here, since we could have switched any time in the past few years when prometheus was already popular. Before we add caching to our metrics generation, I think we should consider migrating to

Re: [DISCUSS] Dismiss Stale Code Reviews

2022-02-24 Thread Michael Marshall
Closing the loop, we merged the PR to set `dismiss_stale_reviews` to `false` two days ago. Thanks, Michael On Wed, Feb 23, 2022 at 2:52 AM Li Li wrote: > > +1 > > > On Feb 23, 2022, at 4:23 PM, Guangning E wrote: > > > > +1 > > > > > > Thanks, > > Guangning > > > > Enrico Olivelli 于2022年2月23日周

Re: [discuss] prometheus metrics doesn't satisfy with OpenMetrics format

2022-02-24 Thread Michael Marshall
> I am working on bumping Prometheus client to 0.12.0 What is the motivation for the update? If it is security related, that might help us make a decision here. > If we want to be compatible with Open Metrics, I suggest adding metrics > named `_total` in a release version like 2.10.0, and removin

Re: [DISCUSS] PrometheusMetricsServlet performance improvement

2022-02-24 Thread Jiuming Tao
> I have a historical question. Why do we write and maintain our own > code to generate the metrics response instead of using the prometheus > client library? Old codes, I think at that time, prometheus is not popular yet >> I have learned that the /metrics endpoint will be requested by more tha

Re: [DISCUSS] PrometheusMetricsServlet performance improvement

2022-02-24 Thread Michael Marshall
I have a historical question. Why do we write and maintain our own code to generate the metrics response instead of using the prometheus client library? > I have learned that the /metrics endpoint will be requested by more than > one metrics collect system. In practice, when does this happen? >

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-02-24 Thread Michael Marshall
Regarding the namespace "terminated" concept, I just noticed that we already have a "deleted" field in a namespace's policies [0]. There is even a comment that says: > // set the policies to deleted so that somebody else cannot acquire this > namespace I am not familiar with this feature, but it

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-02-24 Thread Michael Marshall
Hi Dave, > automatically delete tenants and namespaces for not containing topics I don't think that is what we are discussing. I agree that the initial email says just that, though, which is why I asked above: >> When there are no user-created topics under a namespace, >> Namespace should be del

[GitHub] [pulsar-manager] JackrayWang commented on issue #447: Deploy from bin package error

2022-02-24 Thread GitBox
JackrayWang commented on issue #447: URL: https://github.com/apache/pulsar-manager/issues/447#issuecomment-1050495540 I can run it and use it in my env。But use this shell `cd pulsar-manager cp -r ../dist ui ./bin/pulsar-manager --redirect.host=http://localhost --redirect.port=9527

Re: [VOTE] Pulsar Release 2.8.3 Candidate 3

2022-02-24 Thread Jiuming Tao
+1 > 2022年2月25日 上午11:44,Michael Marshall 写道: > > This is the third release candidate for Apache Pulsar, version 2.8.3. > > It fixes the following issues: > https://github.com/apache/pulsar/compare/v2.8.2...v2.8.3-candidate-3 > > *** Please download, test and vote on this release. This vote wi

[VOTE] Pulsar Release 2.8.3 Candidate 3

2022-02-24 Thread Michael Marshall
This is the third release candidate for Apache Pulsar, version 2.8.3. It fixes the following issues: https://github.com/apache/pulsar/compare/v2.8.2...v2.8.3-candidate-3 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we are voting

[GitHub] [pulsar-site] urfreespace commented on a change in pull request #6: config and style updates

2022-02-24 Thread GitBox
urfreespace commented on a change in pull request #6: URL: https://github.com/apache/pulsar-site/pull/6#discussion_r814436861 ## File path: site2/website-next/src/pages/index.js ## @@ -1,4 +1,5 @@ -import React, { useEffect, componentDidMount } from "react"; +import React, { us

Re: [VOTE] Pulsar Node.js Client Release 1.6.0 Candidate 1

2022-02-24 Thread Hiroyuki Sakai
Hi, Guangning I can't unpack pulsar-client-node-1.6.0.tar.gz. Would you please check this file? $ wget https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/pulsar-client-node-1.6.0-candidate-1/pulsar-client-node-1.6.0.tar.gz $ tar xvzf ./pulsar-client-node-1.6.0.tar.gz tar: Error o

[GitHub] [pulsar-site] urfreespace commented on a change in pull request #6: config and style updates

2022-02-24 Thread GitBox
urfreespace commented on a change in pull request #6: URL: https://github.com/apache/pulsar-site/pull/6#discussion_r814412578 ## File path: site2/website-next/src/pages/index.js ## @@ -129,7 +130,13 @@ export default function Home() { ]; useEffect((d) => { startWaves

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-02-24 Thread Dave Fisher
Hi - I hope I’m understanding what’s being discussed. If we are going to automatically delete tenants and namespaces for not containing topics then we need to make both of these automatic actions configurable with a default to NOT do so. Otherwise we break existing use cases. Automatic deletio

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-02-24 Thread Michael Marshall
> The old producer/consumer should be closed after applying the changes from > this proposal. Penghui, are you suggesting that we implement the namespace/tenant terminated logic after completing this PIP? For the sake of discussion, if we implement the namespace terminated logic first, we could f

[GitHub] [pulsar-manager] hsluoyz commented on pull request #446: Add support for casdoor

2022-02-24 Thread GitBox
hsluoyz commented on pull request #446: URL: https://github.com/apache/pulsar-manager/pull/446#issuecomment-1049904925 @tuteng please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-02-24 Thread PengHui Li
> If we want to solve this problem, we need to add some sync resources like lock/state, I think it’s a harm for us, we don’t need to do that. I think we can make the namespace/tenants to the inactive state first so that we can avoid any new producer/consumer connect to the topic under the namespac

Re: [VOTE] Pulsar Release 2.10.0 Candidate 1

2022-02-24 Thread PengHui Li
Hi all, I have cherry-picked the fixes to branch-2.10 and will roll out the new RC tomorrow. If you find any potential breaking changes, please share the information there. Best, Penghui On Wed, Feb 23, 2022 at 1:56 PM PengHui Li wrote: > Thanks Dave, > > Yes, this is also what I want to ask,

[GitHub] [pulsar-client-node] Matt-Esch commented on issue #191: Segault with pulsar 2.9.1 and node 16.13.2

2022-02-24 Thread GitBox
Matt-Esch commented on issue #191: URL: https://github.com/apache/pulsar-client-node/issues/191#issuecomment-1049731870 It's quite trivial to reproduce if you queue up some operations on a producer and close the client immediately afterwards. -- This is an automated message from the Ap