Re: [VOTE] PIP-129: Introduce intermediate state for ledger deletion

2022-01-19 Thread Lin Lin
+1

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2022-01-19 Thread PengHui Li
> What is the justification for avoiding the new protobuf field? If we add a structured field to a map of , we are still modifying the protocol, even if we aren't modifying the protobuf. Not all cases need a new field named init_subscription when creating producer, and users will not touch the met

[GitHub] [pulsar-helm-chart] sijie commented on pull request #127: Antiaffinity with zone topology for high availability

2022-01-19 Thread GitBox
sijie commented on pull request #127: URL: https://github.com/apache/pulsar-helm-chart/pull/127#issuecomment-1017163937 @sdwerwed: I think the zone affinity would work for stateless components. I don't think it will work well for stateful components. Because the location of bookie and zoo

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #206: Upgrade default images for Grafana & Pulsar Manager

2022-01-19 Thread GitBox
lhotari opened a new pull request #206: URL: https://github.com/apache/pulsar-helm-chart/pull/206 - Grafana Dashboard image from v0.0.10 to v0.0.16 - changes: https://github.com/streamnative/apache-pulsar-grafana-dashboard/compare/d50e2758...v0.0.16 - Pulsar Manager from

[GitHub] [pulsar-helm-chart] lhotari commented on a change in pull request #155: Add grafana data persistence support.

2022-01-19 Thread GitBox
lhotari commented on a change in pull request #155: URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r788376370 ## File path: charts/pulsar/values.yaml ## @@ -988,6 +988,24 @@ grafana: requests: memory: 250Mi cpu: 0.1 + volumes: +# us

[GitHub] [pulsar-helm-chart] sijie commented on a change in pull request #205: Tiered Storage config

2022-01-19 Thread GitBox
sijie commented on a change in pull request #205: URL: https://github.com/apache/pulsar-helm-chart/pull/205#discussion_r788375908 ## File path: charts/pulsar/values.yaml ## @@ -410,6 +410,69 @@ zookeeper: usePolicy: true maxUnavailable: 1 +## Tiered Storage +## +sto

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2022-01-19 Thread Michael Marshall
> I think that, good or bad, the impression that users have that the DLQ > is not a "normal" topic Thanks for your perspective, Matteo. I still prefer my alternative design that bypasses subscription creation, but it seems there is insufficient interest in it, so we should move forward discussing

[GitHub] [pulsar-helm-chart] sijie commented on pull request #205: Tiered Storage config

2022-01-19 Thread GitBox
sijie commented on pull request #205: URL: https://github.com/apache/pulsar-helm-chart/pull/205#issuecomment-1017148847 @MarvinCai @tuteng can you review this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #205: Tiered Storage config

2022-01-19 Thread GitBox
lhotari commented on pull request #205: URL: https://github.com/apache/pulsar-helm-chart/pull/205#issuecomment-1017145232 @sijie @codelipenghui @eolivelli @addisonj This PR would be a valuable addition to Apache Pulsar Helm chart. Please review. -- This is an automated message from the

[GitHub] [pulsar-helm-chart] pellicano commented on pull request #205: Tiered Storage config

2022-01-19 Thread GitBox
pellicano commented on pull request #205: URL: https://github.com/apache/pulsar-helm-chart/pull/205#issuecomment-1016813035 Thanks for the comments @michaeljmarshall! Let me know if there's anything else. -- This is an automated message from the Apache Git Service. To respond to the m

[DISCUSSION] PIP-137: Add SystemTopicNameManager to manage system topic names.

2022-01-19 Thread mattison chao
Original issue : https://github.com/apache/pulsar/issues/13794 Original pull request : https://github.com/apache/pulsar/pull/13813 Pasted below for quoting convenience. --- ## Motivation - The current system topic names are scattered and difficult to maintain and dynamically configure.

[GitHub] [pulsar-helm-chart] dragonls commented on pull request #113: Add multi volume support in bookkeeper.

2022-01-19 Thread GitBox
dragonls commented on pull request #113: URL: https://github.com/apache/pulsar-helm-chart/pull/113#issuecomment-1016190040 ping @eolivelli @sijie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t