Re: Dropping Presto SQL in 2.9.0 - status ?

2021-12-16 Thread Lari Hotari
Hi Marvin, Great work on the Trino PR! It's been a lot of work to get it to match the Trino code conventions. I hope we could drop Presto & Pulsar SQL from the apache/pulsar code repository as planned in PIP-62[1], "PIP 62: Move connectors, adapters and Pulsar Presto to separate repositories", wh

Re: [VOTE] Apache Pulsar 2.9.1 candidate 2

2021-12-16 Thread PengHui Li
Checked: - Build from the src - Check signatures - Follow the validation process But when I try to verify PulsarSQL, got following exceptions: ``` 2021-12-17T14:58:18.958+0800 ERROR remote-task-callback-3 io.prestosql.execution.StageStateMachine Stage 20211217_065818_1_cahiv.1 failed com.goo

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-16 Thread mattison chao
+1 On Fri, 17 Dec 2021 at 13:56, 陳智弘 wrote: > +1 > > Sijie Guo 於 2021年12月17日 週五 12:38 寫道: > > > +1 > > > > On Tue, Dec 14, 2021 at 11:20 AM Matteo Merli wrote: > > > > > https://github.com/apache/pulsar/issues/13306 > > > > > > > > > Pasted below for quoting convenience. > > > > > > > > >

[PR] Pulsar non root docker image

2021-12-16 Thread Michael Marshall
Hi Pulsar Community, I opened a PR to make our pulsar and pulsar-all docker images non root and OpenShift compliant [0]. As some may remember, we had issues with these changes before due to lack of testing. I plan to test thoroughly before we merge this PR, and it'd be great to have others test to

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-16 Thread Enrico Olivelli
+1 Enrico Il Ven 17 Dic 2021, 05:36 Sijie Guo ha scritto: > +1 > > On Tue, Dec 14, 2021 at 10:03 AM Matteo Merli wrote: > > > https://github.com/apache/pulsar/issues/13304 > > > > > > Pasted below for quoting convenience. > > > > --- > > > > > > ## Motivation > > > > After all the work don

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-16 Thread 陳智弘
+1 Sijie Guo 於 2021年12月17日 週五 12:38 寫道: > +1 > > On Tue, Dec 14, 2021 at 11:20 AM Matteo Merli wrote: > > > https://github.com/apache/pulsar/issues/13306 > > > > > > Pasted below for quoting convenience. > > > > > > > > > > ## Motivation > > > > In Pulsar 2.8, we have introduced a sett

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-16 Thread Sijie Guo
+1 On Tue, Dec 14, 2021 at 11:20 AM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13306 > > > Pasted below for quoting convenience. > > > > > ## Motivation > > In Pulsar 2.8, we have introduced a setting to control the amount of memory > used by a client instance. > > ``

Re: [DISCUSSION] PIP-119: Enable consistent hashing by default on KeyShared dispatcher

2021-12-16 Thread Sijie Guo
+1 On Tue, Dec 14, 2021 at 10:15 AM Matteo Merli wrote: > Pasted below for quoting convenience. > > > > > ## Motivation > > The consistent hashing implementation to uniformly assign keys to consumers > in the context of a KeyShared subscription, was introduced in > https://github.com/ap

Re: [DISCUSSION] PIP-118: Do not restart brokers when ZooKeeper session expires

2021-12-16 Thread Sijie Guo
+1 On Tue, Dec 14, 2021 at 10:03 AM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13304 > > > Pasted below for quoting convenience. > > --- > > > ## Motivation > > After all the work done for PIP-45 that was already included in 2.8 and 2.9 > releases, it enabled the concept o

Re: [DISCUSSION] PIP-117: Change Pulsar standalone defaults

2021-12-16 Thread Sijie Guo
+1 On Tue, Dec 14, 2021 at 9:18 AM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13302 > > Copying here for quoting convenience > > > > > > ## Motivation > > Pulsar standalone is the "Pulsar in a box" version of a Pulsar cluster, > where > all the components are started with

Re: [DISCUSS] Release Pulsar 2.7.4

2021-12-16 Thread guo jiwei
Hi, After we have fixed some issue like ZookeeperCache NPE, listing namespace exception, and skip some flaky tests (verified locally), now the CI have passed. Skipped flaky tests are tracked here: https://github.com/apache/pulsar/issues/13299 Now we decide to vote for releasing 2.7.4. Regards Jiwe

Re: [VOTE] Apache Pulsar 2.9.1 candidate 2

2021-12-16 Thread Matteo Merli
+1 Checked: * Signatures * Bin distribution: - NOTICE, README, LICENSE - Start standalone service and producer/consumer test * Src distribution: - NOTICE, README, LICENSE - Compile and unit tests - Start standalone service * Checked staging maven repository artifacts

Re: [VOTE] Apache Pulsar 2.9.1 candidate 2

2021-12-16 Thread Enrico Olivelli
I have pushed the docker images to my personal dockehub account eolivelli/pulsar:2.9.1rc2 eolivelli/pulsar-all:2.9.1rc2 Enrico Il Gio 16 Dic 2021, 15:57 Nicolò Boschi ha scritto: > +1 (non binding) > > Checks: > - Checksum and signatures > - Apache Rat check passes > - OWASP check passes (I cr

Re: [DISCUSS] How to handle stale PRs

2021-12-16 Thread Dave Fisher
I just saw another project - https://github.com/openmessaging/benchmark uses probot-stale https://github.com/probot/stale This looks like it has all the features needed to close both stale issues and PRs. It allows labels to be used to prevent closure of certain issues and PRs. Here is their co

Re: [VOTE] Apache Pulsar 2.9.1 candidate 2

2021-12-16 Thread Nicolò Boschi
+1 (non binding) Checks: - Checksum and signatures - Apache Rat check passes - OWASP check passes (I created this PR for fix a false positive https://github.com/apache/pulsar/pull/13364) - Compile from source w JDK11 - Build docker image from source - Run Pulsar standalone and produce-consume from

[VOTE] Apache Pulsar 2.9.1 candidate 2

2021-12-16 Thread Enrico Olivelli
This is the second release candidate for Apache Pulsar, version 2.9.1. The first release candidate was aborted without starting a VOTE because we had to pick up high priority dependency upgrades. It fixes the following issues: https://github.com/apache/pulsar/pulls?q=is%3Apr++label%3Arelease%2F2.

Re: PIP 112: Generate Release Notes Automatically

2021-12-16 Thread Yu
Hi all, This is a follow-up to the last email. Previously, we use markdown files to create issue templates [1]. For the doc_request issue template, I've changed it to a customized issue form by adding a YAML form definition file, which is more intuitive and easy to use. Feel free to comment on